DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: add description to release note
@ 2019-04-18  7:58 Tomasz Jozwiak
  2019-04-18  7:58 ` Tomasz Jozwiak
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Tomasz Jozwiak @ 2019-04-18  7:58 UTC (permalink / raw)
  To: dev, fiona.trahe, tomaszx.jozwiak

Added description about compression QAT PMD improvement

Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
 doc/guides/rel_notes/release_19_05.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst
index b0928a6..624625f 100644
--- a/doc/guides/rel_notes/release_19_05.rst
+++ b/doc/guides/rel_notes/release_19_05.rst
@@ -146,6 +146,9 @@ New Features
 
   Added support for AES-XTS with 128 and 256 bit AES keys.
 
+  Simplify and make more robust QAT compressdev PMD's handling of SGLs with
+  more than 16 segments.
+
 * **Updated AESNI-MB PMD.**
 
   Added support for out-of-place operations.
-- 
2.7.4

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dpdk-dev] [PATCH] doc: add description to release note
  2019-04-18  7:58 [dpdk-dev] [PATCH] doc: add description to release note Tomasz Jozwiak
@ 2019-04-18  7:58 ` Tomasz Jozwiak
  2019-04-18 11:46 ` Trahe, Fiona
  2019-05-03 16:15 ` [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs Fiona Trahe
  2 siblings, 0 replies; 12+ messages in thread
From: Tomasz Jozwiak @ 2019-04-18  7:58 UTC (permalink / raw)
  To: dev, fiona.trahe, tomaszx.jozwiak

Added description about compression QAT PMD improvement

Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
 doc/guides/rel_notes/release_19_05.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst
index b0928a6..624625f 100644
--- a/doc/guides/rel_notes/release_19_05.rst
+++ b/doc/guides/rel_notes/release_19_05.rst
@@ -146,6 +146,9 @@ New Features
 
   Added support for AES-XTS with 128 and 256 bit AES keys.
 
+  Simplify and make more robust QAT compressdev PMD's handling of SGLs with
+  more than 16 segments.
+
 * **Updated AESNI-MB PMD.**
 
   Added support for out-of-place operations.
-- 
2.7.4


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add description to release note
  2019-04-18  7:58 [dpdk-dev] [PATCH] doc: add description to release note Tomasz Jozwiak
  2019-04-18  7:58 ` Tomasz Jozwiak
@ 2019-04-18 11:46 ` Trahe, Fiona
  2019-04-18 11:46   ` Trahe, Fiona
  2019-05-03 16:15 ` [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs Fiona Trahe
  2 siblings, 1 reply; 12+ messages in thread
From: Trahe, Fiona @ 2019-04-18 11:46 UTC (permalink / raw)
  To: Jozwiak, TomaszX, dev



> -----Original Message-----
> From: Jozwiak, TomaszX
> Sent: Thursday, April 18, 2019 8:59 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>
> Subject: [PATCH] doc: add description to release note
> 
> Added description about compression QAT PMD improvement
> 
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add description to release note
  2019-04-18 11:46 ` Trahe, Fiona
@ 2019-04-18 11:46   ` Trahe, Fiona
  0 siblings, 0 replies; 12+ messages in thread
From: Trahe, Fiona @ 2019-04-18 11:46 UTC (permalink / raw)
  To: Jozwiak, TomaszX, dev



> -----Original Message-----
> From: Jozwiak, TomaszX
> Sent: Thursday, April 18, 2019 8:59 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>
> Subject: [PATCH] doc: add description to release note
> 
> Added description about compression QAT PMD improvement
> 
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs
  2019-04-18  7:58 [dpdk-dev] [PATCH] doc: add description to release note Tomasz Jozwiak
  2019-04-18  7:58 ` Tomasz Jozwiak
  2019-04-18 11:46 ` Trahe, Fiona
@ 2019-05-03 16:15 ` Fiona Trahe
  2019-05-03 16:15   ` Fiona Trahe
  2019-05-09 15:24   ` Mcnamara, John
  2 siblings, 2 replies; 12+ messages in thread
From: Fiona Trahe @ 2019-05-03 16:15 UTC (permalink / raw)
  To: dev; +Cc: thomas, akhil.goyal, tomaszx.jozwiak, Fiona Trahe

Added release note entry for QAT compression PMD
Clarified that previous entry was for QAT sym crypto PMD

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
 doc/guides/rel_notes/release_19_05.rst | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst
index 8c51db910..278c0ab21 100644
--- a/doc/guides/rel_notes/release_19_05.rst
+++ b/doc/guides/rel_notes/release_19_05.rst
@@ -169,7 +169,7 @@ New Features
 
   Added MACSEC hardware offload experimental API.
 
-* **Updated the QuickAssist Technology PMD.**
+* **Updated the QuickAssist Technology (QAT) symmetric crypto PMD.**
 
   Added support for AES-XTS with 128 and 256 bit AES keys.
 
@@ -193,6 +193,11 @@ New Features
   Improved testpmd application performance on ARM platform. For ``macswap``
   forwarding mode, NEON intrinsics were used to do swap to save CPU cycles.
 
+* **Updated the Intel QuickAssist Technology (QAT) compression PMD.**
+
+  Simplified and made more robust QAT compressdev PMD's handling of SGLs with
+  more than 16 segments.
+
 
 Removed Items
 -------------
-- 
2.13.6

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs
  2019-05-03 16:15 ` [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs Fiona Trahe
@ 2019-05-03 16:15   ` Fiona Trahe
  2019-05-09 15:24   ` Mcnamara, John
  1 sibling, 0 replies; 12+ messages in thread
From: Fiona Trahe @ 2019-05-03 16:15 UTC (permalink / raw)
  To: dev; +Cc: thomas, akhil.goyal, tomaszx.jozwiak, Fiona Trahe

Added release note entry for QAT compression PMD
Clarified that previous entry was for QAT sym crypto PMD

Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
 doc/guides/rel_notes/release_19_05.rst | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst
index 8c51db910..278c0ab21 100644
--- a/doc/guides/rel_notes/release_19_05.rst
+++ b/doc/guides/rel_notes/release_19_05.rst
@@ -169,7 +169,7 @@ New Features
 
   Added MACSEC hardware offload experimental API.
 
-* **Updated the QuickAssist Technology PMD.**
+* **Updated the QuickAssist Technology (QAT) symmetric crypto PMD.**
 
   Added support for AES-XTS with 128 and 256 bit AES keys.
 
@@ -193,6 +193,11 @@ New Features
   Improved testpmd application performance on ARM platform. For ``macswap``
   forwarding mode, NEON intrinsics were used to do swap to save CPU cycles.
 
+* **Updated the Intel QuickAssist Technology (QAT) compression PMD.**
+
+  Simplified and made more robust QAT compressdev PMD's handling of SGLs with
+  more than 16 segments.
+
 
 Removed Items
 -------------
-- 
2.13.6


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs
  2019-05-03 16:15 ` [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs Fiona Trahe
  2019-05-03 16:15   ` Fiona Trahe
@ 2019-05-09 15:24   ` Mcnamara, John
  2019-05-09 15:24     ` Mcnamara, John
  2019-05-09 22:39     ` Thomas Monjalon
  1 sibling, 2 replies; 12+ messages in thread
From: Mcnamara, John @ 2019-05-09 15:24 UTC (permalink / raw)
  To: Trahe, Fiona, dev; +Cc: thomas, akhil.goyal, Jozwiak, TomaszX, Trahe, Fiona



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fiona Trahe
> Sent: Friday, May 3, 2019 5:16 PM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; akhil.goyal@nxp.com; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs
> 
> Added release note entry for QAT compression PMD Clarified that previous
> entry was for QAT sym crypto PMD


Acked-by: John McNamara <john.mcnamara@intel.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs
  2019-05-09 15:24   ` Mcnamara, John
@ 2019-05-09 15:24     ` Mcnamara, John
  2019-05-09 22:39     ` Thomas Monjalon
  1 sibling, 0 replies; 12+ messages in thread
From: Mcnamara, John @ 2019-05-09 15:24 UTC (permalink / raw)
  To: Trahe, Fiona, dev; +Cc: thomas, akhil.goyal, Jozwiak, TomaszX, Trahe, Fiona



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fiona Trahe
> Sent: Friday, May 3, 2019 5:16 PM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; akhil.goyal@nxp.com; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs
> 
> Added release note entry for QAT compression PMD Clarified that previous
> entry was for QAT sym crypto PMD


Acked-by: John McNamara <john.mcnamara@intel.com>



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs
  2019-05-09 15:24   ` Mcnamara, John
  2019-05-09 15:24     ` Mcnamara, John
@ 2019-05-09 22:39     ` Thomas Monjalon
  2019-05-09 22:39       ` Thomas Monjalon
  1 sibling, 1 reply; 12+ messages in thread
From: Thomas Monjalon @ 2019-05-09 22:39 UTC (permalink / raw)
  To: Trahe, Fiona; +Cc: dev, Mcnamara, John, akhil.goyal, Jozwiak, TomaszX

> > Added release note entry for QAT compression PMD Clarified that previous
> > entry was for QAT sym crypto PMD
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks

Please try to update release notes in code patches, thanks.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs
  2019-05-09 22:39     ` Thomas Monjalon
@ 2019-05-09 22:39       ` Thomas Monjalon
  0 siblings, 0 replies; 12+ messages in thread
From: Thomas Monjalon @ 2019-05-09 22:39 UTC (permalink / raw)
  To: Trahe, Fiona; +Cc: dev, Mcnamara, John, akhil.goyal, Jozwiak, TomaszX

> > Added release note entry for QAT compression PMD Clarified that previous
> > entry was for QAT sym crypto PMD
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks

Please try to update release notes in code patches, thanks.



^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add description to release note
@ 2019-04-30  7:12 Akhil Goyal
  2019-04-30  7:12 ` Akhil Goyal
  0 siblings, 1 reply; 12+ messages in thread
From: Akhil Goyal @ 2019-04-30  7:12 UTC (permalink / raw)
  To: Tomasz Jozwiak, dev, fiona.trahe

Hi Tomasz,

> 
> 
> Added description about compression QAT PMD improvement
> 
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> ---
>  doc/guides/rel_notes/release_19_05.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_19_05.rst
> b/doc/guides/rel_notes/release_19_05.rst
> index b0928a6..624625f 100644
> --- a/doc/guides/rel_notes/release_19_05.rst
> +++ b/doc/guides/rel_notes/release_19_05.rst
> @@ -146,6 +146,9 @@ New Features
> 
>    Added support for AES-XTS with 128 and 256 bit AES keys.
> 
> +  Simplify and make more robust QAT compressdev PMD's handling of SGLs with
> +  more than 16 segments.
> +
>  * **Updated AESNI-MB PMD.**
> 
>    Added support for out-of-place operations.


This patch is not clear neither from the subject nor from the release note update.
The description that you added here is for QAT compress PMD but it is added in description of QAT crypto PMD.

You should make a separate entry for QAT compress PMD and update the existing one with crypto PMD

Also the patch subject should be "doc: update release note for QAT compress PMD" or something more descriptive.

Thanks,
Akhil

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add description to release note
  2019-04-30  7:12 [dpdk-dev] [PATCH] doc: add description to release note Akhil Goyal
@ 2019-04-30  7:12 ` Akhil Goyal
  0 siblings, 0 replies; 12+ messages in thread
From: Akhil Goyal @ 2019-04-30  7:12 UTC (permalink / raw)
  To: Tomasz Jozwiak, dev, fiona.trahe

Hi Tomasz,

> 
> 
> Added description about compression QAT PMD improvement
> 
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> ---
>  doc/guides/rel_notes/release_19_05.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_19_05.rst
> b/doc/guides/rel_notes/release_19_05.rst
> index b0928a6..624625f 100644
> --- a/doc/guides/rel_notes/release_19_05.rst
> +++ b/doc/guides/rel_notes/release_19_05.rst
> @@ -146,6 +146,9 @@ New Features
> 
>    Added support for AES-XTS with 128 and 256 bit AES keys.
> 
> +  Simplify and make more robust QAT compressdev PMD's handling of SGLs with
> +  more than 16 segments.
> +
>  * **Updated AESNI-MB PMD.**
> 
>    Added support for out-of-place operations.


This patch is not clear neither from the subject nor from the release note update.
The description that you added here is for QAT compress PMD but it is added in description of QAT crypto PMD.

You should make a separate entry for QAT compress PMD and update the existing one with crypto PMD

Also the patch subject should be "doc: update release note for QAT compress PMD" or something more descriptive.

Thanks,
Akhil

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-05-09 22:39 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-18  7:58 [dpdk-dev] [PATCH] doc: add description to release note Tomasz Jozwiak
2019-04-18  7:58 ` Tomasz Jozwiak
2019-04-18 11:46 ` Trahe, Fiona
2019-04-18 11:46   ` Trahe, Fiona
2019-05-03 16:15 ` [dpdk-dev] [PATCH v2] doc: update release notes for QAT PMDs Fiona Trahe
2019-05-03 16:15   ` Fiona Trahe
2019-05-09 15:24   ` Mcnamara, John
2019-05-09 15:24     ` Mcnamara, John
2019-05-09 22:39     ` Thomas Monjalon
2019-05-09 22:39       ` Thomas Monjalon
2019-04-30  7:12 [dpdk-dev] [PATCH] doc: add description to release note Akhil Goyal
2019-04-30  7:12 ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).