From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 2FD141B104 for ; Fri, 3 May 2019 20:09:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2019 11:09:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,426,1549958400"; d="scan'208";a="154518598" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 03 May 2019 11:09:57 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.115]) by IRSMSX152.ger.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0415.000; Fri, 3 May 2019 19:09:56 +0100 From: "Trahe, Fiona" To: "Doherty, Declan" , "ravi1.kumar@amd.com" , "tdu@semihalf.com" , "lironh@marvell.com" , "walan@marvell.com" CC: "De Lara Guarch, Pablo" , "dev@dpdk.org" , "Kusztal, ArkadiuszX" , "Anoob Joseph" , "shallyv@marvell.com" , "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH] doc: add cryptodev gcm iv deprecation notice Thread-Index: AdT/IjH19tx8/wdFTXKfNDUNKM+iJQCt1+vA Date: Fri, 3 May 2019 18:09:55 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589751F08@IRSMSX101.ger.corp.intel.com> References: In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTdlZDhlZWMtYTRjYy00ZGFkLWE1Y2MtMTcyMGUzZmY2MTk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibUZJeXRWZEVmT1NxMUJyelZ5WEZWTUFyNkVOWGh0ZEdzbGVubVwvbllhcEpVSlF6RVkwemxEcEUyTEFHZW1nUmkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 18:10:00 -0000 Forwarding to maintainers of the following crypto PMDs which may be affecte= d by this: mvsam ccp openssl Can you review the 19.05 deprecation notice below and if in agreement, ack = please - 3 acks are needed This is the related API change targeted at 19.08: https://patches.dpdk.org/patch/52886/ > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Tuesday, April 30, 2019 7:59 AM > To: Anoob Joseph ; shallyv@marvell.com > Cc: Trahe, Fiona ; De Lara Guarch, Pablo ; > dev@dpdk.org; Kusztal, ArkadiuszX > Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice >=20 > Hi Anoob/Shally, >=20 > Could you please review this patch and provide Ack. >=20 > Thanks, > Akhil >=20 >=20 > > > > > > This patch adds deprecation notice of changing iv behaviour > > when using Galois Counter Mode of operation. Right now IV of > > all supported sizes can be used. > > > > Signed-off-by: Arek Kusztal > > --- > > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index ba39c2d..76eb166 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -87,3 +87,9 @@ Deprecation Notices > > * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the = xforms > > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, a= nd > > ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data`= `. > > + > > +* cryptodev: support for using IV with all sizes is added, J0 still ca= n > > + be used but only when IV length in following structs ``rte_crypto_au= th_xform``, > > + ``rte_crypto_aead_xform`` is set to zero. When IV length is greater = or equal > > + to one it means it represents IV, when is set to zero it means J0 is= used > > + directly, in this case 16 bytes of J0 need to be passed. > > -- > > 2.1.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5F57CA0AC5 for ; Fri, 3 May 2019 20:10:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5BDDC1B105; Fri, 3 May 2019 20:10:01 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 2FD141B104 for ; Fri, 3 May 2019 20:09:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2019 11:09:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,426,1549958400"; d="scan'208";a="154518598" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by FMSMGA003.fm.intel.com with ESMTP; 03 May 2019 11:09:57 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.115]) by IRSMSX152.ger.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0415.000; Fri, 3 May 2019 19:09:56 +0100 From: "Trahe, Fiona" To: "Doherty, Declan" , "ravi1.kumar@amd.com" , "tdu@semihalf.com" , "lironh@marvell.com" , "walan@marvell.com" CC: "De Lara Guarch, Pablo" , "dev@dpdk.org" , "Kusztal, ArkadiuszX" , "Anoob Joseph" , "shallyv@marvell.com" , "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH] doc: add cryptodev gcm iv deprecation notice Thread-Index: AdT/IjH19tx8/wdFTXKfNDUNKM+iJQCt1+vA Date: Fri, 3 May 2019 18:09:55 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589751F08@IRSMSX101.ger.corp.intel.com> References: In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTdlZDhlZWMtYTRjYy00ZGFkLWE1Y2MtMTcyMGUzZmY2MTk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibUZJeXRWZEVmT1NxMUJyelZ5WEZWTUFyNkVOWGh0ZEdzbGVubVwvbllhcEpVSlF6RVkwemxEcEUyTEFHZW1nUmkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: add cryptodev gcm iv deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190503180955.M1pU4Kq8xaRuk5GBZKNbh-mndnHES01OGEqcUuSDUGs@z> Forwarding to maintainers of the following crypto PMDs which may be affecte= d by this: mvsam ccp openssl Can you review the 19.05 deprecation notice below and if in agreement, ack = please - 3 acks are needed This is the related API change targeted at 19.08: https://patches.dpdk.org/patch/52886/ > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Tuesday, April 30, 2019 7:59 AM > To: Anoob Joseph ; shallyv@marvell.com > Cc: Trahe, Fiona ; De Lara Guarch, Pablo ; > dev@dpdk.org; Kusztal, ArkadiuszX > Subject: RE: [PATCH] doc: add cryptodev gcm iv deprecation notice >=20 > Hi Anoob/Shally, >=20 > Could you please review this patch and provide Ack. >=20 > Thanks, > Akhil >=20 >=20 > > > > > > This patch adds deprecation notice of changing iv behaviour > > when using Galois Counter Mode of operation. Right now IV of > > all supported sizes can be used. > > > > Signed-off-by: Arek Kusztal > > --- > > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index ba39c2d..76eb166 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -87,3 +87,9 @@ Deprecation Notices > > * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the = xforms > > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, a= nd > > ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data`= `. > > + > > +* cryptodev: support for using IV with all sizes is added, J0 still ca= n > > + be used but only when IV length in following structs ``rte_crypto_au= th_xform``, > > + ``rte_crypto_aead_xform`` is set to zero. When IV length is greater = or equal > > + to one it means it represents IV, when is set to zero it means J0 is= used > > + directly, in this case 16 bytes of J0 need to be passed. > > -- > > 2.1.0