From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 414E8A0471 for ; Fri, 21 Jun 2019 13:59:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4319F1D5BD; Fri, 21 Jun 2019 13:58:59 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7D2A01D5B9 for ; Fri, 21 Jun 2019 13:58:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2019 04:58:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,400,1557212400"; d="scan'208";a="165631755" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga006.jf.intel.com with ESMTP; 21 Jun 2019 04:58:54 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.80]) by irsmsx110.ger.corp.intel.com ([169.254.15.217]) with mapi id 14.03.0439.000; Fri, 21 Jun 2019 12:58:54 +0100 From: "Trahe, Fiona" To: Akhil Goyal , "Kusztal, ArkadiuszX" , "dev@dpdk.org" , "shally.verma@caviumnetworks.com" CC: "Trahe, Fiona" Thread-Topic: [PATCH] cryptodev: extend api of asymmetric crypto by sessionless Thread-Index: AQHVGkUHWWASMFfof0mYfFRjYZRUS6akoF0AgAF30JA= Date: Fri, 21 Jun 2019 11:58:53 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435897A26ED@IRSMSX101.ger.corp.intel.com> References: <20190603194411.8352-1-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzExOTBjYzUtM2JkZi00YWM2LWJiNzYtNmQxNTE3MGI1NzE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYU1KTDFkV2dNWmZXWm1JZmhLeEJ5bktwSW13TzIxQm8yWjBCR3hJMUg0VE1XSXZqZmozOHNIRlVNbit3OWhhMyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] cryptodev: extend api of asymmetric crypto by sessionless X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Arek, Shally, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Thursday, June 20, 2019 3:17 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Trahe, Fiona ; shally.verma@caviumnetworks.com > Subject: RE: [PATCH] cryptodev: extend api of asymmetric crypto by sessio= nless > > > > Asymmetric cryptography algorithms may more likely use > > sessionless API so there is need to extend API. > > > > Signed-off-by: Arek Kusztal > > --- > Acked-by: Akhil Goyal [Fiona] The code is ok but I think a little more is needed. As all PMDs don't support sessionless, this needs to be handled as an optio= nal capability. And in future some PMDs may only support SESSIONLESS and some only support = WITH_SESSION. So I propose adding 2 feature flags to the API RTE_CRYPTODEV_FF_ASYM_WTH_SESSION RTE_CRYPTODEV_FF_ASYM_SESSIONLESS and including in this patch the PMD and UT changes to set and test the firs= t flag. We'll follow up with SESSIONLESS QAT implementation and UTs in a separate p= atchset. Also documentation updates should go with this API patch, i.e. - update section 16.7.2 in the cryptodev programmers guide - and review th= at doc in case other sections need updating. - fix comment in rte_crypto.h under STATUS_INVALID_SESSION - release note