From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5E9CA0471 for ; Fri, 19 Jul 2019 17:38:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CBCA04D27; Fri, 19 Jul 2019 17:38:19 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 629B02C17 for ; Fri, 19 Jul 2019 17:38:17 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2019 08:38:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,282,1559545200"; d="scan'208,217";a="252187279" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 19 Jul 2019 08:38:14 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.88]) by irsmsx105.ger.corp.intel.com ([169.254.7.164]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 16:38:13 +0100 From: "Trahe, Fiona" To: Ayuj Verma , "Kusztal, ArkadiuszX" , "akhil.goyal@nxp.com" CC: Shally Verma , Sunila Sahu , Kanaka Durga Kotamarthy , "dev@dpdk.org" , "Trahe, Fiona" Thread-Topic: [RFC] mark asym session-buffer non-reuseable Thread-Index: AQHVPJv4Yb3c5wrMZkakDhJbKoGco6bOyK6AgAFJFACAAeb0AIAAHMcg Date: Fri, 19 Jul 2019 15:38:12 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435897C97E6@IRSMSX101.ger.corp.intel.com> References: <1563366852-23118-1-git-send-email-ayverma@marvell.com>, <06EE24DD0B19E248B53F6DC8657831551B280B17@hasmsx109.ger.corp.intel.com>, In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWIwMTllNTYtZWNkNS00OTI3LThkMDgtMWEwYmVlYmY1OWZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaHQydTV4am5JK2d5ZEJMNHRnaHlOaTN4a1o1VG1VVzV2SmplTXJrYlRvS1dnV216NHptOUFoMDZoNkJubDdQTCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC] mark asym session-buffer non-reuseable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" No need as API is still experimental. Howver I'd suggest changing the subject to "declare crypto asym xform immutable" non-reusable is confusing as the session and xform will be re-used on all t= he ops associated with the session. From: Ayuj Verma [mailto:ayverma@marvell.com] Sent: Friday, July 19, 2019 3:51 PM To: Kusztal, ArkadiuszX ; akhil.goyal@nxp.com Cc: Trahe, Fiona ; Shally Verma ; Sunila Sahu ; Kanaka Durga Kotamarthy ; dev@dpdk.org Subject: Re: [RFC] mark asym session-buffer non-reuseable Hi Akhil, Arek, Fiona, Since this require changes in other Asym PMD( qat) apart from openssl (we p= lan to send changes for this), so should we need to send any announcement on ABI breakage here before prop= osing patch v1? Thanks and regards Ayuj Verma ________________________________ From: Ayuj Verma Sent: 18 July 2019 15:17:54 To: Kusztal, ArkadiuszX; akhil.goyal@nxp.com Cc: Trahe, Fiona; Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; dev@d= pdk.org Subject: Re: [RFC] mark asym session-buffer non-reuseable Hi Arek, Please see inline. Thanks and regards Ayuj Verma ________________________________ From: Kusztal, ArkadiuszX > Sent: 17 July 2019 19:40 To: Ayuj Verma; akhil.goyal@nxp.com Cc: Trahe, Fiona; Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; dev@d= pdk.org Subject: RE: [RFC] mark asym session-buffer non-reuseable Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:ayverma@marvell.com] > Sent: Wednesday, July 17, 2019 2:34 PM > To: akhil.goyal@nxp.com > Cc: Kusztal, ArkadiuszX >; Trahe, Fiona > >; shallyv@marvell.co= m; ssahu@marvell.com; > kkotamarthy@marvell.com; dev@dpdk.org; Ayuj Verma > > > Subject: [RFC] mark asym session-buffer non-reuseable > > This RFC proposes changes in asymmetric session usability of transform > structure. In current implementation asym xform is seen as temporary enti= ty > that can be re-used by application once sessions are initialized with it. > > This enforces PMD to copy all key buffers during session setup time. Sinc= e > life-time of sessions are small, so we can hold these buffers with sessio= n, [AK] - what is you expected session lifetime? (2,3,50 packets?) [Ayuj] In practical scenario like SSL, handshake will happen in some 10-15 = packets. > reducing memcpy time by marking these as read-only so that PMDs which > doesn't require any manipulation of xform data can directly use these > buffers in session configure. > > So, sending a proposal to mark xform as non-reusable till lifetime of ses= sion. > This will help PMDs to reduce session setup time. > > Ayuj Verma (1): > lib/crypto: mark asym session-buffer non-reuseable > > doc/guides/prog_guide/cryptodev_lib.rst | 6 ++++++ > lib/librte_cryptodev/rte_cryptodev_pmd.h | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > -- > 1.8.3.1