From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E6ECA046B for ; Thu, 25 Jul 2019 15:14:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A0C4C1C233; Thu, 25 Jul 2019 15:14:45 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 6518E1C231 for ; Thu, 25 Jul 2019 15:14:43 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 06:14:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,306,1559545200"; d="scan'208";a="181462540" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga002.jf.intel.com with ESMTP; 25 Jul 2019 06:14:41 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.88]) by IRSMSX151.ger.corp.intel.com ([169.254.4.41]) with mapi id 14.03.0439.000; Thu, 25 Jul 2019 14:14:40 +0100 From: "Trahe, Fiona" To: "Dybkowski, AdamX" , "dev@dpdk.org" , "shally.verma@caviumnetworks.com" , Sunila Sahu Thread-Topic: [PATCH] compress/zlib: fix coverity warning Thread-Index: AQHVQfxbEU6v/F+89kaOKpup8XPobqbbUY7A Date: Thu, 25 Jul 2019 13:14:40 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435897D0682@IRSMSX101.ger.corp.intel.com> References: <20190724084246.5768-1-adamx.dybkowski@intel.com> In-Reply-To: <20190724084246.5768-1-adamx.dybkowski@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjc3M2M4OTQtZjhhMC00OTkwLWJlZjYtMDk3OGFmZDVlMjM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUGRKZk9yWGNVOU15cHFQMlRjV0t1TjRFQUhiNmZ4VG1XNjJwQ21cL1Q4RjVoUlwvYUR5WlpuU0xpQW1QZDdkekhSIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] compress/zlib: fix coverity warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Including Sunila, the zlib PMD maintainer. > -----Original Message----- > From: Dybkowski, AdamX > Sent: Wednesday, July 24, 2019 9:43 AM > To: dev@dpdk.org; Trahe, Fiona ; shally.verma@cavi= umnetworks.com > Cc: Dybkowski, AdamX > Subject: [PATCH] compress/zlib: fix coverity warning >=20 > Add missing return after setting the error status in case of > invalid flush_flag in the operation. > The issue was found by the coverity scan as the fin_flush variable, > not initialized in such case, was used later in the flow. >=20 > CID 340859: Uninitialized variables (UNINIT) >=20 > Fixes: c7b436ec95fd ("compress/zlib: support burst enqueue/dequeue") >=20 > Signed-off-by: Adam Dybkowski > --- > drivers/compress/zlib/zlib_pmd.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zli= b_pmd.c > index 5a4d47d4d..19f9200c2 100644 > --- a/drivers/compress/zlib/zlib_pmd.c > +++ b/drivers/compress/zlib/zlib_pmd.c > @@ -30,6 +30,7 @@ process_zlib_deflate(struct rte_comp_op *op, z_stream *= strm) > default: > op->status =3D RTE_COMP_OP_STATUS_INVALID_ARGS; > ZLIB_PMD_ERR("Invalid flush value\n"); > + return; > } >=20 > if (unlikely(!strm)) { > -- > 2.17.1