From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E656FA046B for ; Thu, 25 Jul 2019 15:56:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA1B71C361; Thu, 25 Jul 2019 15:56:24 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0ED1A1C352 for ; Thu, 25 Jul 2019 15:56:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 06:56:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,306,1559545200"; d="scan'208";a="369136088" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga005.fm.intel.com with ESMTP; 25 Jul 2019 06:56:21 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.88]) by IRSMSX106.ger.corp.intel.com ([169.254.8.234]) with mapi id 14.03.0439.000; Thu, 25 Jul 2019 14:56:20 +0100 From: "Trahe, Fiona" To: "Dybkowski, AdamX" , "dev@dpdk.org" , "akhil.goyal@nxp.com" CC: "Trahe, Fiona" Thread-Topic: [PATCH] test/compress: fix coverity warnings Thread-Index: AQHVQUYSsbNOprnXOEy34/CkPKREeqbbXnCg Date: Thu, 25 Jul 2019 13:56:20 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435897D06F4@IRSMSX101.ger.corp.intel.com> References: <20190723105349.23622-1-adamx.dybkowski@intel.com> In-Reply-To: <20190723105349.23622-1-adamx.dybkowski@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWM3Y2QzZmQtNzNlNy00NTQyLWE2ZjEtZTA0Y2YzMzU0ZDYxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVmRzbGRhUUJ1Q2pkZWdcL0VGTFdwVERPN3Y5YkJpXC9FZHBaWEFmRFhcL01LRk4xaFwvQ0kxQUJScDc5TGxaYTZoczUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test/compress: fix coverity warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adam, > -----Original Message----- > From: Dybkowski, AdamX > Sent: Tuesday, July 23, 2019 11:54 AM > To: dev@dpdk.org; Trahe, Fiona ; akhil.goyal@nxp.c= om > Cc: Dybkowski, AdamX > Subject: [PATCH] test/compress: fix coverity warnings >=20 > CID 340857: Null pointer dereferences (NULL_RETURNS) >=20 > CID 340856: (CONSTANT_EXPRESSION_RESULT) >=20 > Fixes: 3be12ea52ad8 ("test/compress: improve debug trace setup") >=20 > Signed-off-by: Adam Dybkowski > --- > app/test/test_compressdev.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c > index 65889c242..992eac8e0 100644 > --- a/app/test/test_compressdev.c > +++ b/app/test/test_compressdev.c > @@ -755,6 +755,12 @@ test_deflate_comp_decomp(const struct interim_data_p= arams *int_data, > char *contig_buf =3D NULL; > uint64_t compress_checksum[num_bufs]; >=20 > + if (capa =3D=3D NULL) { > + RTE_LOG(ERR, USER1, > + "Compress device does not support DEFLATE\n"); > + return -1; [Fiona] shouldn't you return -ENOTSUP?