From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED210A046B for ; Fri, 26 Jul 2019 14:55:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 610001C444; Fri, 26 Jul 2019 14:55:24 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 506D71C441 for ; Fri, 26 Jul 2019 14:55:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 05:55:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,310,1559545200"; d="scan'208";a="345817482" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga005.jf.intel.com with ESMTP; 26 Jul 2019 05:55:21 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.88]) by IRSMSX108.ger.corp.intel.com ([169.254.11.229]) with mapi id 14.03.0439.000; Fri, 26 Jul 2019 13:55:20 +0100 From: "Trahe, Fiona" To: "Dybkowski, AdamX" , "dev@dpdk.org" , "akhil.goyal@nxp.com" Thread-Topic: [PATCH] app/compress-perf: prevent output buffer overflow Thread-Index: AQHVQT5bYPvFZCb13UCHb4QF4ftdEKbc4B8g Date: Fri, 26 Jul 2019 12:55:20 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435897D1C1A@IRSMSX101.ger.corp.intel.com> References: <20190723095328.23236-1-adamx.dybkowski@intel.com> In-Reply-To: <20190723095328.23236-1-adamx.dybkowski@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWZiNzhjYzMtNzE0ZS00Y2E4LWEwNjQtZGIzYzk2YzBjZTNiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVVUwVW81bEYxQWwwem5HNmdVZXBFUHUzeFFzUlVUS0d4K0YwdzkrNWtWUUlwVEJ3Q0NmTXZxYVRUMGZQN2RJWiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/compress-perf: prevent output buffer overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dybkowski, AdamX > Sent: Tuesday, July 23, 2019 10:53 AM > To: dev@dpdk.org; Trahe, Fiona ; akhil.goyal@nxp.c= om > Cc: Dybkowski, AdamX > Subject: [PATCH] app/compress-perf: prevent output buffer overflow >=20 > This patch fixes the issue of memory overwrite after the end of > the output buffer by calculating its size as the number of all > segments multipled by the output segment size. > Additionally buffer overflow errors returned by PMD driver are > detected and shown, ending the test. >=20 > Also the output buffer size multiplier was increased from 105% > to 110% to allow running the tests on noncompressible files that > expand to over 107% of original size during the compression. >=20 > The changes were made in the verification part of the flow and > they don't affect the benchmark results. >=20 > Fixes: 424dd6c8c1 ("app/compress-perf: add weak functions for multicore t= est") >=20 > Signed-off-by: Adam Dybkowski Acked-by: Fiona Trahe