DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
@ 2019-09-06 11:57 Arek Kusztal
  2019-09-08  6:18 ` [dpdk-dev] [EXT] " Shally Verma
  2019-10-04  3:31 ` Anoob Joseph
  0 siblings, 2 replies; 9+ messages in thread
From: Arek Kusztal @ 2019-09-06 11:57 UTC (permalink / raw)
  To: dev; +Cc: akhil.goyal, fiona.trahe, shallyv, anoobj, Arek Kusztal

This commit adds asymmetric session-less option to
rte_crypto_asym_op. Feature flag for sessionless is added
to rte_cryptodev.

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++--
 lib/librte_cryptodev/rte_cryptodev.h   | 2 ++
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h
index 4fbef2f..0d34ce8 100644
--- a/lib/librte_cryptodev/rte_crypto_asym.h
+++ b/lib/librte_cryptodev/rte_crypto_asym.h
@@ -522,8 +522,13 @@ struct rte_crypto_dsa_op_param {
  *
  */
 struct rte_crypto_asym_op {
-	struct rte_cryptodev_asym_session *session;
-	/**< Handle for the initialised session context */
+	RTE_STD_C11
+	union {
+		struct rte_cryptodev_asym_session *session;
+		/**< Handle for the initialised session context */
+		struct rte_crypto_asym_xform *xform;
+		/**< Session-less API crypto operation parameters */
+	};
 
 	__extension__
 	union {
diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index e175b83..c6ffa3b 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -448,6 +448,8 @@ rte_cryptodev_asym_get_xform_enum(enum rte_crypto_asym_xform_type *xform_enum,
 /**< Support RSA Private Key OP with CRT (quintuple) Keys */
 #define RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED		(1ULL << 19)
 /**< Support encrypted-digest operations where digest is appended to data */
+#define RTE_CRYPTODEV_FF_ASYM_SESSIONLESS		(1ULL << 20)
+/**< Support asymmetric session-less operations */
 
 
 /**
-- 
2.1.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
  2019-09-06 11:57 [dpdk-dev] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless Arek Kusztal
@ 2019-09-08  6:18 ` " Shally Verma
  2019-09-09 10:23   ` Trahe, Fiona
  2019-10-03 14:28   ` Akhil Goyal
  2019-10-04  3:31 ` Anoob Joseph
  1 sibling, 2 replies; 9+ messages in thread
From: Shally Verma @ 2019-09-08  6:18 UTC (permalink / raw)
  To: Arek Kusztal, dev; +Cc: akhil.goyal, fiona.trahe, Anoob Joseph

Hi Arek

Only these changes looks good to me but do you have working PMD to back this? Also, documentation updates?

Thanks
Shally

> -----Original Message-----
> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Sent: Friday, September 6, 2019 5:28 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Shally Verma
> <shallyv@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Arek
> Kusztal <arkadiuszx.kusztal@intel.com>
> Subject: [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by
> sessionless
> 
> External Email
> 
> ----------------------------------------------------------------------
> This commit adds asymmetric session-less option to rte_crypto_asym_op.
> Feature flag for sessionless is added to rte_cryptodev.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
>  lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++--
>  lib/librte_cryptodev/rte_cryptodev.h   | 2 ++
>  2 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
> b/lib/librte_cryptodev/rte_crypto_asym.h
> index 4fbef2f..0d34ce8 100644
> --- a/lib/librte_cryptodev/rte_crypto_asym.h
> +++ b/lib/librte_cryptodev/rte_crypto_asym.h
> @@ -522,8 +522,13 @@ struct rte_crypto_dsa_op_param {
>   *
>   */
>  struct rte_crypto_asym_op {
> -	struct rte_cryptodev_asym_session *session;
> -	/**< Handle for the initialised session context */
> +	RTE_STD_C11
> +	union {
> +		struct rte_cryptodev_asym_session *session;
> +		/**< Handle for the initialised session context */
> +		struct rte_crypto_asym_xform *xform;
> +		/**< Session-less API crypto operation parameters */
> +	};
> 
>  	__extension__
>  	union {
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> b/lib/librte_cryptodev/rte_cryptodev.h
> index e175b83..c6ffa3b 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -448,6 +448,8 @@ rte_cryptodev_asym_get_xform_enum(enum
> rte_crypto_asym_xform_type *xform_enum,  /**< Support RSA Private Key
> OP with CRT (quintuple) Keys */
>  #define RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED		(1ULL << 19)
>  /**< Support encrypted-digest operations where digest is appended to data
> */
> +#define RTE_CRYPTODEV_FF_ASYM_SESSIONLESS		(1ULL << 20)
> +/**< Support asymmetric session-less operations */
> 
> 
>  /**
> --
> 2.1.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
  2019-09-08  6:18 ` [dpdk-dev] [EXT] " Shally Verma
@ 2019-09-09 10:23   ` Trahe, Fiona
  2019-10-03 14:28   ` Akhil Goyal
  1 sibling, 0 replies; 9+ messages in thread
From: Trahe, Fiona @ 2019-09-09 10:23 UTC (permalink / raw)
  To: Shally Verma, Kusztal, ArkadiuszX, dev
  Cc: akhil.goyal, Anoob Joseph, Trahe, Fiona

Hi Shally, 
QAT implementation and test code was sent on Friday in this and related patches:
http://patches.dpdk.org/patch/58839/
Fiona

> -----Original Message-----
> From: Shally Verma [mailto:shallyv@marvell.com]
> Sent: Sunday, September 8, 2019 7:19 AM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Anoob Joseph
> <anoobj@marvell.com>
> Subject: RE: [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
> 
> Hi Arek
> 
> Only these changes looks good to me but do you have working PMD to back this? Also, documentation
> updates?
> 
> Thanks
> Shally
> 
> > -----Original Message-----
> > From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > Sent: Friday, September 6, 2019 5:28 PM
> > To: dev@dpdk.org
> > Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Shally Verma
> > <shallyv@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Arek
> > Kusztal <arkadiuszx.kusztal@intel.com>
> > Subject: [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by
> > sessionless
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > This commit adds asymmetric session-less option to rte_crypto_asym_op.
> > Feature flag for sessionless is added to rte_cryptodev.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> >  lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++--
> >  lib/librte_cryptodev/rte_cryptodev.h   | 2 ++
> >  2 files changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
> > b/lib/librte_cryptodev/rte_crypto_asym.h
> > index 4fbef2f..0d34ce8 100644
> > --- a/lib/librte_cryptodev/rte_crypto_asym.h
> > +++ b/lib/librte_cryptodev/rte_crypto_asym.h
> > @@ -522,8 +522,13 @@ struct rte_crypto_dsa_op_param {
> >   *
> >   */
> >  struct rte_crypto_asym_op {
> > -	struct rte_cryptodev_asym_session *session;
> > -	/**< Handle for the initialised session context */
> > +	RTE_STD_C11
> > +	union {
> > +		struct rte_cryptodev_asym_session *session;
> > +		/**< Handle for the initialised session context */
> > +		struct rte_crypto_asym_xform *xform;
> > +		/**< Session-less API crypto operation parameters */
> > +	};
> >
> >  	__extension__
> >  	union {
> > diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> > b/lib/librte_cryptodev/rte_cryptodev.h
> > index e175b83..c6ffa3b 100644
> > --- a/lib/librte_cryptodev/rte_cryptodev.h
> > +++ b/lib/librte_cryptodev/rte_cryptodev.h
> > @@ -448,6 +448,8 @@ rte_cryptodev_asym_get_xform_enum(enum
> > rte_crypto_asym_xform_type *xform_enum,  /**< Support RSA Private Key
> > OP with CRT (quintuple) Keys */
> >  #define RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED		(1ULL << 19)
> >  /**< Support encrypted-digest operations where digest is appended to data
> > */
> > +#define RTE_CRYPTODEV_FF_ASYM_SESSIONLESS		(1ULL << 20)
> > +/**< Support asymmetric session-less operations */
> >
> >
> >  /**
> > --
> > 2.1.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
  2019-09-08  6:18 ` [dpdk-dev] [EXT] " Shally Verma
  2019-09-09 10:23   ` Trahe, Fiona
@ 2019-10-03 14:28   ` Akhil Goyal
  1 sibling, 0 replies; 9+ messages in thread
From: Akhil Goyal @ 2019-10-03 14:28 UTC (permalink / raw)
  To: Shally Verma, Arek Kusztal, dev; +Cc: fiona.trahe, Anoob Joseph

Hi Shally,

Any more comments on this patch.
If not please Ack.

Regards,
Akhil

> -----Original Message-----
> From: Shally Verma <shallyv@marvell.com>
> Sent: Sunday, September 8, 2019 11:49 AM
> To: Arek Kusztal <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; fiona.trahe@intel.com; Anoob Joseph
> <anoobj@marvell.com>
> Subject: RE: [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by
> sessionless
> 
> Hi Arek
> 
> Only these changes looks good to me but do you have working PMD to back this?
> Also, documentation updates?
> 
> Thanks
> Shally
> 
> > -----Original Message-----
> > From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > Sent: Friday, September 6, 2019 5:28 PM
> > To: dev@dpdk.org
> > Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Shally Verma
> > <shallyv@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Arek
> > Kusztal <arkadiuszx.kusztal@intel.com>
> > Subject: [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by
> > sessionless
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > This commit adds asymmetric session-less option to rte_crypto_asym_op.
> > Feature flag for sessionless is added to rte_cryptodev.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> >  lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++--
> >  lib/librte_cryptodev/rte_cryptodev.h   | 2 ++
> >  2 files changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
> > b/lib/librte_cryptodev/rte_crypto_asym.h
> > index 4fbef2f..0d34ce8 100644
> > --- a/lib/librte_cryptodev/rte_crypto_asym.h
> > +++ b/lib/librte_cryptodev/rte_crypto_asym.h
> > @@ -522,8 +522,13 @@ struct rte_crypto_dsa_op_param {
> >   *
> >   */
> >  struct rte_crypto_asym_op {
> > -	struct rte_cryptodev_asym_session *session;
> > -	/**< Handle for the initialised session context */
> > +	RTE_STD_C11
> > +	union {
> > +		struct rte_cryptodev_asym_session *session;
> > +		/**< Handle for the initialised session context */
> > +		struct rte_crypto_asym_xform *xform;
> > +		/**< Session-less API crypto operation parameters */
> > +	};
> >
> >  	__extension__
> >  	union {
> > diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> > b/lib/librte_cryptodev/rte_cryptodev.h
> > index e175b83..c6ffa3b 100644
> > --- a/lib/librte_cryptodev/rte_cryptodev.h
> > +++ b/lib/librte_cryptodev/rte_cryptodev.h
> > @@ -448,6 +448,8 @@ rte_cryptodev_asym_get_xform_enum(enum
> > rte_crypto_asym_xform_type *xform_enum,  /**< Support RSA Private Key
> > OP with CRT (quintuple) Keys */
> >  #define RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED		(1ULL << 19)
> >  /**< Support encrypted-digest operations where digest is appended to data
> > */
> > +#define RTE_CRYPTODEV_FF_ASYM_SESSIONLESS		(1ULL << 20)
> > +/**< Support asymmetric session-less operations */
> >
> >
> >  /**
> > --
> > 2.1.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
  2019-09-06 11:57 [dpdk-dev] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless Arek Kusztal
  2019-09-08  6:18 ` [dpdk-dev] [EXT] " Shally Verma
@ 2019-10-04  3:31 ` Anoob Joseph
  2019-10-04 10:55   ` Akhil Goyal
  1 sibling, 1 reply; 9+ messages in thread
From: Anoob Joseph @ 2019-10-04  3:31 UTC (permalink / raw)
  To: Arek Kusztal, dev; +Cc: akhil.goyal, fiona.trahe, Shally Verma

> -----Original Message-----
> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Sent: Friday, September 6, 2019 5:28 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Shally Verma
> <shallyv@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Arek
> Kusztal <arkadiuszx.kusztal@intel.com>
> Subject: [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by
> sessionless
> 
> External Email
> 
> ----------------------------------------------------------------------
> This commit adds asymmetric session-less option to rte_crypto_asym_op.
> Feature flag for sessionless is added to rte_cryptodev.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
>  lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++--
>  lib/librte_cryptodev/rte_cryptodev.h   | 2 ++
>  2 files changed, 9 insertions(+), 2 deletions(-)
> 

Acked-by: Anoob Joseph <anoobj@marvell.com>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
  2019-10-04  3:31 ` Anoob Joseph
@ 2019-10-04 10:55   ` Akhil Goyal
  2019-10-04 11:33     ` Akhil Goyal
  0 siblings, 1 reply; 9+ messages in thread
From: Akhil Goyal @ 2019-10-04 10:55 UTC (permalink / raw)
  To: Anoob Joseph, Arek Kusztal, dev; +Cc: fiona.trahe, Shally Verma

> >
> > ----------------------------------------------------------------------
> > This commit adds asymmetric session-less option to rte_crypto_asym_op.
> > Feature flag for sessionless is added to rte_cryptodev.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> >  lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++--
> >  lib/librte_cryptodev/rte_cryptodev.h   | 2 ++
> >  2 files changed, 9 insertions(+), 2 deletions(-)
> >
> 
> Acked-by: Anoob Joseph <anoobj@marvell.com>

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
  2019-10-04 10:55   ` Akhil Goyal
@ 2019-10-04 11:33     ` Akhil Goyal
  2019-10-08 13:47       ` Trahe, Fiona
  0 siblings, 1 reply; 9+ messages in thread
From: Akhil Goyal @ 2019-10-04 11:33 UTC (permalink / raw)
  To: Akhil Goyal, Anoob Joseph, Arek Kusztal, dev; +Cc: fiona.trahe, Shally Verma


> 
> > >
> > > ----------------------------------------------------------------------
> > > This commit adds asymmetric session-less option to rte_crypto_asym_op.
> > > Feature flag for sessionless is added to rte_cryptodev.
> > >
> > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > > ---
> > >  lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++--
> > >  lib/librte_cryptodev/rte_cryptodev.h   | 2 ++
> > >  2 files changed, 9 insertions(+), 2 deletions(-)
> > >
> >
> > Acked-by: Anoob Joseph <anoobj@marvell.com>
> 
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> Applied to dpdk-next-crypto
> 
> Thanks.

This patch is taken back from the tree.

This patch need updates to "doc/guides/prog_guide/cryptodev_lib.rst"
For sessionless support in asymmetric operations.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
  2019-10-04 11:33     ` Akhil Goyal
@ 2019-10-08 13:47       ` Trahe, Fiona
  0 siblings, 0 replies; 9+ messages in thread
From: Trahe, Fiona @ 2019-10-08 13:47 UTC (permalink / raw)
  To: Akhil Goyal, Anoob Joseph, Kusztal, ArkadiuszX, dev
  Cc: Shally Verma, Trahe, Fiona

Hi Arek, Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Friday, October 4, 2019 12:34 PM
> To: Akhil Goyal <akhil.goyal@nxp.com>; Anoob Joseph <anoobj@marvell.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; Shally Verma <shallyv@marvell.com>
> Subject: RE: [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
> 
> 
> >
> > > >
> > > > ----------------------------------------------------------------------
> > > > This commit adds asymmetric session-less option to rte_crypto_asym_op.
> > > > Feature flag for sessionless is added to rte_cryptodev.
> > > >
> > > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > > > ---
> > > >  lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++--
> > > >  lib/librte_cryptodev/rte_cryptodev.h   | 2 ++
> > > >  2 files changed, 9 insertions(+), 2 deletions(-)
> > > >
> > >
> > > Acked-by: Anoob Joseph <anoobj@marvell.com>
> >
> > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> >
> > Applied to dpdk-next-crypto
> >
> > Thanks.
> 
> This patch is taken back from the tree.
> 
> This patch need updates to "doc/guides/prog_guide/cryptodev_lib.rst"
> For sessionless support in asymmetric operations.

Documentation updates also needed in crypto devices Supported Feature Flag matrix

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless
@ 2019-10-03 14:54 Shally Verma
  0 siblings, 0 replies; 9+ messages in thread
From: Shally Verma @ 2019-10-03 14:54 UTC (permalink / raw)
  To: Kusztal, ArkadiuszX, Akhil Goyal, dev; +Cc: Anoob Joseph, Trahe, Fiona



Sent from Workspace ONE Boxer
On 03-Oct-2019 7:58 PM, Akhil Goyal <akhil.goyal@nxp.com> wrote:
>
> Hi Shally,
>
> Any more comments on this patch.
> If not please Ack.
>
> Regards,
> Akhil
>
> > -----Original Message-----
> > From: Shally Verma <shallyv@marvell.com>
> > Sent: Sunday, September 8, 2019 11:49 AM
> > To: Arek Kusztal <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> > Cc: Akhil Goyal <akhil.goyal@nxp.com>; fiona.trahe@intel.com; Anoob Joseph
> > <anoobj@marvell.com>
> > Subject: RE: [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by
> > sessionless
> >
> > Hi Arek
> >
> > Only these changes looks good to me but do you have working PMD to back this?
> > Also, documentation updates?
> >
> > Thanks
> > Shally
> >
> > > -----Original Message-----
> > > From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > > Sent: Friday, September 6, 2019 5:28 PM
> > > To: dev@dpdk.org
> > > Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Shally Verma
> > > <shallyv@marvell.com>; Anoob Joseph <anoobj@marvell.com>; Arek
> > > Kusztal <arkadiuszx.kusztal@intel.com>
> > > Subject: [EXT] [PATCH v2] cryptodev: extend api of asymmetric crypto by
> > > sessionless
> > >
> > > External Email
> > >
> > > ----------------------------------------------------------------------
> > > This commit adds asymmetric session-less option to rte_crypto_asym_op.
> > > Feature flag for sessionless is added to rte_cryptodev.
> > >
> > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > > ---

Acked-by: Shally Verma < shallyv@marvell.com>

> > >  lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++--
> > >  lib/librte_cryptodev/rte_cryptodev.h   | 2 ++
> > >  2 files changed, 9 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
> > > b/lib/librte_cryptodev/rte_crypto_asym.h
> > > index 4fbef2f..0d34ce8 100644
> > > --- a/lib/librte_cryptodev/rte_crypto_asym.h
> > > +++ b/lib/librte_cryptodev/rte_crypto_asym.h
> > > @@ -522,8 +522,13 @@ struct rte_crypto_dsa_op_param {
> > >   *
> > >   */
> > >  struct rte_crypto_asym_op {
> > > -   struct rte_cryptodev_asym_session *session;
> > > -   /**< Handle for the initialised session context */
> > > +   RTE_STD_C11
> > > +   union {
> > > +           struct rte_cryptodev_asym_session *session;
> > > +           /**< Handle for the initialised session context */
> > > +           struct rte_crypto_asym_xform *xform;
> > > +           /**< Session-less API crypto operation parameters */
> > > +   };
> > >
> > >      __extension__
> > >      union {
> > > diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> > > b/lib/librte_cryptodev/rte_cryptodev.h
> > > index e175b83..c6ffa3b 100644
> > > --- a/lib/librte_cryptodev/rte_cryptodev.h
> > > +++ b/lib/librte_cryptodev/rte_cryptodev.h
> > > @@ -448,6 +448,8 @@ rte_cryptodev_asym_get_xform_enum(enum
> > > rte_crypto_asym_xform_type *xform_enum,  /**< Support RSA Private Key
> > > OP with CRT (quintuple) Keys */
> > >  #define RTE_CRYPTODEV_FF_DIGEST_ENCRYPTED          (1ULL << 19)
> > >  /**< Support encrypted-digest operations where digest is appended to data
> > > */
> > > +#define RTE_CRYPTODEV_FF_ASYM_SESSIONLESS          (1ULL << 20)
> > > +/**< Support asymmetric session-less operations */
> > >
> > >
> > >  /**
> > > --
> > > 2.1.0
>


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 11:57 [dpdk-dev] [PATCH v2] cryptodev: extend api of asymmetric crypto by sessionless Arek Kusztal
2019-09-08  6:18 ` [dpdk-dev] [EXT] " Shally Verma
2019-09-09 10:23   ` Trahe, Fiona
2019-10-03 14:28   ` Akhil Goyal
2019-10-04  3:31 ` Anoob Joseph
2019-10-04 10:55   ` Akhil Goyal
2019-10-04 11:33     ` Akhil Goyal
2019-10-08 13:47       ` Trahe, Fiona
2019-10-03 14:54 Shally Verma

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox