DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] compress/isal: create shorter qp name
@ 2019-08-06  9:09 Adam Dybkowski
  2019-08-06  9:27 ` Daly, Lee
  2019-09-10 15:29 ` Trahe, Fiona
  0 siblings, 2 replies; 4+ messages in thread
From: Adam Dybkowski @ 2019-08-06  9:09 UTC (permalink / raw)
  To: dev, fiona.trahe, paul.e.luse; +Cc: Adam Dybkowski

This patch shortens the queue pair name created when initializing
the queue pair of the ISAL PIM, based on the device and qp ids.
The patch idea of shortening the queue pair name was proposed
by Luse, Paul E <<paul.e.luse@intel.com>

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 drivers/compress/isal/isal_compress_pmd_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c
index 77ac6fcf2..31c455991 100644
--- a/drivers/compress/isal/isal_compress_pmd_ops.c
+++ b/drivers/compress/isal/isal_compress_pmd_ops.c
@@ -216,7 +216,7 @@ isal_comp_pmd_qp_set_unique_name(struct rte_compressdev *dev,
 struct isal_comp_qp *qp)
 {
 	unsigned int n = snprintf(qp->name, sizeof(qp->name),
-			"isal_compression_pmd_%u_qp_%u",
+			"isal_comp_pmd_%u_qp_%u",
 			dev->data->dev_id, qp->id);
 
 	if (n >= sizeof(qp->name))
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] compress/isal: create shorter qp name
  2019-08-06  9:09 [dpdk-dev] [PATCH] compress/isal: create shorter qp name Adam Dybkowski
@ 2019-08-06  9:27 ` Daly, Lee
  2019-08-06  9:33   ` Dybkowski, AdamX
  2019-09-10 15:29 ` Trahe, Fiona
  1 sibling, 1 reply; 4+ messages in thread
From: Daly, Lee @ 2019-08-06  9:27 UTC (permalink / raw)
  To: Dybkowski, AdamX, dev, Trahe, Fiona, Luse, Paul E; +Cc: Dybkowski, AdamX

Hi Adam,

Take care to add the maintainer of the code you are changing to your email, a list can be found in the MAINTAINERS file. 
This will hopefully ensure a response to the change. 
Thanks.
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adam Dybkowski
> Sent: Tuesday, August 6, 2019 10:10 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Luse, Paul E
> <paul.e.luse@intel.com>
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [dpdk-dev] [PATCH] compress/isal: create shorter qp name
> 
> This patch shortens the queue pair name created when initializing the queue
> pair of the ISAL PIM, based on the device and qp ids.
> The patch idea of shortening the queue pair name was proposed by Luse,
> Paul E <<paul.e.luse@intel.com>
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
>  drivers/compress/isal/isal_compress_pmd_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c
> b/drivers/compress/isal/isal_compress_pmd_ops.c
> index 77ac6fcf2..31c455991 100644
> --- a/drivers/compress/isal/isal_compress_pmd_ops.c
> +++ b/drivers/compress/isal/isal_compress_pmd_ops.c
> @@ -216,7 +216,7 @@ isal_comp_pmd_qp_set_unique_name(struct
> rte_compressdev *dev,  struct isal_comp_qp *qp)  {
>  	unsigned int n = snprintf(qp->name, sizeof(qp->name),
> -			"isal_compression_pmd_%u_qp_%u",
> +			"isal_comp_pmd_%u_qp_%u",
>  			dev->data->dev_id, qp->id);
> 
>  	if (n >= sizeof(qp->name))
> --
> 2.17.1
Acked-by: Lee Daly <lee.daly@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] compress/isal: create shorter qp name
  2019-08-06  9:27 ` Daly, Lee
@ 2019-08-06  9:33   ` Dybkowski, AdamX
  0 siblings, 0 replies; 4+ messages in thread
From: Dybkowski, AdamX @ 2019-08-06  9:33 UTC (permalink / raw)
  To: Daly, Lee, dev, Trahe, Fiona, Luse, Paul E

> -----Original Message-----
> From: Daly, Lee
> Sent: Tuesday, 6 August, 2019 11:28
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>; dev@dpdk.org;
> Trahe, Fiona <fiona.trahe@intel.com>; Luse, Paul E <paul.e.luse@intel.com>
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] compress/isal: create shorter qp name
> 
> Hi Adam,
> 
> Take care to add the maintainer of the code you are changing to your email,
> a list can be found in the MAINTAINERS file.
> This will hopefully ensure a response to the change.
> Thanks.

Sure, will do next time.
Thanks for the quick ACK, Lee.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] compress/isal: create shorter qp name
  2019-08-06  9:09 [dpdk-dev] [PATCH] compress/isal: create shorter qp name Adam Dybkowski
  2019-08-06  9:27 ` Daly, Lee
@ 2019-09-10 15:29 ` Trahe, Fiona
  1 sibling, 0 replies; 4+ messages in thread
From: Trahe, Fiona @ 2019-09-10 15:29 UTC (permalink / raw)
  To: Dybkowski, AdamX, dev, Luse, Paul E, akhil.goyal; +Cc: Trahe, Fiona



> -----Original Message-----
> From: Dybkowski, AdamX
> Sent: Tuesday, August 6, 2019 10:10 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Luse, Paul E <paul.e.luse@intel.com>
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH] compress/isal: create shorter qp name
> 
> This patch shortens the queue pair name created when initializing
> the queue pair of the ISAL PIM, based on the device and qp ids.
> The patch idea of shortening the queue pair name was proposed
> by Luse, Paul E <<paul.e.luse@intel.com>
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-06  9:09 [dpdk-dev] [PATCH] compress/isal: create shorter qp name Adam Dybkowski
2019-08-06  9:27 ` Daly, Lee
2019-08-06  9:33   ` Dybkowski, AdamX
2019-09-10 15:29 ` Trahe, Fiona

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox