From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0A83A0613 for ; Mon, 23 Sep 2019 11:46:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8F281B96B; Mon, 23 Sep 2019 11:46:38 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 997F44CE4 for ; Mon, 23 Sep 2019 11:46:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 02:46:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,539,1559545200"; d="scan'208";a="182482258" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga008.jf.intel.com with ESMTP; 23 Sep 2019 02:46:34 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.129]) by irsmsx105.ger.corp.intel.com ([169.254.7.164]) with mapi id 14.03.0439.000; Mon, 23 Sep 2019 10:46:33 +0100 From: "Trahe, Fiona" To: "Dybkowski, AdamX" , "dev@dpdk.org" , "Trybula, ArturX" , "akhil.goyal@nxp.com" CC: "Trahe, Fiona" Thread-Topic: [PATCH v2 2/3] compress/qat: add stateful decompression Thread-Index: AQHVb7F3bDMqd/wBNE68FY9OX8pvl6c5Bltg Date: Mon, 23 Sep 2019 09:46:33 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B43589820F3A@IRSMSX101.ger.corp.intel.com> References: <20190826074501.10653-1-adamx.dybkowski@intel.com> <20190920124452.29449-1-adamx.dybkowski@intel.com> <20190920124452.29449-3-adamx.dybkowski@intel.com> In-Reply-To: <20190920124452.29449-3-adamx.dybkowski@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDYxZTU3MGYtMGU3YS00ZTA2LTgyY2ItZmMxMGI0YjI1YjMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieUlNY1pkUGhvMks3dEwrOEpKeWNHVVZkOVg2WWdvMjJGVFFmNWZ5Qis0ZEo4UWpRQUUzaVBvYUl5UzVwdXRVaiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/3] compress/qat: add stateful decompression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adam, > -----Original Message----- > From: Dybkowski, AdamX > Sent: Friday, September 20, 2019 1:45 PM > To: dev@dpdk.org; Trahe, Fiona ; Trybula, ArturX > ; akhil.goyal@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 2/3] compress/qat: add stateful decompression >=20 > This patch adds the stateful decompression feature > to the DPDK QAT PMD. >=20 > Signed-off-by: Adam Dybkowski > --- > doc/guides/compressdevs/features/default.ini | 37 +-- > doc/guides/compressdevs/features/qat.ini | 21 +- > doc/guides/compressdevs/qat_comp.rst | 5 + > doc/guides/rel_notes/release_19_11.rst | 4 + > drivers/compress/qat/qat_comp.c | 256 +++++++++++++++++-- > drivers/compress/qat/qat_comp.h | 32 +++ > drivers/compress/qat/qat_comp_pmd.c | 166 +++++++++++- > drivers/compress/qat/qat_comp_pmd.h | 2 + > 8 files changed, 462 insertions(+), 61 deletions(-) >=20 > diff --git a/doc/guides/compressdevs/features/default.ini > b/doc/guides/compressdevs/features/default.ini > index 829e4df61..5b783b842 100644 > --- a/doc/guides/compressdevs/features/default.ini > +++ b/doc/guides/compressdevs/features/default.ini > @@ -6,21 +6,22 @@ > ; the features table in the documentation. > ; > [Features] > -HW Accelerated =3D > -CPU SSE =3D > -CPU AVX =3D > -CPU AVX2 =3D > -CPU AVX512 =3D > -CPU NEON =3D > -Stateful =3D > -Pass-through =3D > -OOP SGL In SGL Out =3D > -OOP SGL In LB Out =3D > -OOP LB In SGL Out =3D > -Deflate =3D > -LZS =3D > -Adler32 =3D > -Crc32 =3D > -Adler32&Crc32 =3D > -Fixed =3D > -Dynamic =3D > +HW Accelerated =3D > +Stateful Decompression =3D > +CPU SSE =3D > +CPU AVX =3D > +CPU AVX2 =3D > +CPU AVX512 =3D > +CPU NEON =3D > +Stateful =3D [Fiona] Pease move Stateful Decompression down after this and rename this t= o Stateful Compression And check if any other driver ini files need corresponding update - though = I don't expect so, as I don't think any stateful support there yet. And as you're sending a v3, please add sections for v2 changes and v3 chang= es in the cover letter.