From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60AFDA2F18 for ; Thu, 3 Oct 2019 14:42:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DA9C1BFDD; Thu, 3 Oct 2019 14:42:03 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id EA5EF1BFD9 for ; Thu, 3 Oct 2019 14:42:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2019 05:42:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,252,1566889200"; d="scan'208";a="393190770" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga006.fm.intel.com with ESMTP; 03 Oct 2019 05:41:59 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.129]) by irsmsx110.ger.corp.intel.com ([169.254.15.189]) with mapi id 14.03.0439.000; Thu, 3 Oct 2019 13:41:59 +0100 From: "Trahe, Fiona" To: "Dybkowski, AdamX" , "dev@dpdk.org" CC: "Trahe, Fiona" , "Kusztal, ArkadiuszX" , "akhil.goyal@nxp.com" Thread-Topic: [PATCH v2 1/3] test/crypto: add more AES GCM tests for QAT PMD Thread-Index: AQHVdUtV9CKIQ5UxaE6sqftJTQhEsKdI5Egg Date: Thu, 3 Oct 2019 12:41:58 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B4358982AD01@IRSMSX101.ger.corp.intel.com> References: <20190906144751.3420-1-adamx.dybkowski@intel.com> <20190927154739.26404-1-adamx.dybkowski@intel.com> <20190927154739.26404-2-adamx.dybkowski@intel.com> In-Reply-To: <20190927154739.26404-2-adamx.dybkowski@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDZkZTY0ZDktNjE0MC00YjFhLWExYjAtNzdkNDA1MzMzMGM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9ZUDBieUlJSmc1SUpLbEt1YWZYeG13aVRjcFBHSXFYbmZ0ZEp3T3hublRMaFB5RURJYnpYZCtPZWZ1MHIwcWcifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/3] test/crypto: add more AES GCM tests for QAT PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adam, > -----Original Message----- > From: Dybkowski, AdamX > Sent: Friday, September 27, 2019 4:48 PM > To: dev@dpdk.org; Trahe, Fiona ; Kusztal, Arkadius= zX > ; akhil.goyal@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH v2 1/3] test/crypto: add more AES GCM tests for QAT PMD >=20 > This patch adds 256-bit AES GCM tests for QAT PMD > (which already existed for AESNI and OpenSSL) and also adds > a number of negative unit tests for AES GCM for QAT PMD, in order > to verify authenticated encryption and decryption with modified data. >=20 > Signed-off-by: Adam Dybkowski > --- These are a great set of tests to add, thanks. However, I find the silent terminology misleading. as the fn is not silent,= other errors may print, debug may print and depending on the flag passed i= n the compare error may print. Also, if the test fails for some other reason than the one it should, this = will be missed. What you want to do is catch specific expected errors so I'd suggest follow= ing: leave test_authenticated_encryption() name as is. Add a fail_expected enum to crypto_unittest_params, with elements like NONE= , DIGEST_CORRUPT, ENCRYPTED_DATA_CORRUPT, UNENCRYPTED_DATA_CORRUPT Don't suppress the errors, instead in wrapper fns, print "Negative test - e= rrors are expected" at top of each negative test, corrupt the input and set= the appropriate fail. In test_authenticated_encryption() and test_authenticated_encryption() use = the enum to check for the expected failure. Does that make sense?