Re: [dpdk-dev] [PATCH v2 0/5] Add session-less, RSA, RSA-CRT to QAT

["Trahe, Fiona" <fiona.trahe@intel.com>]

Hi Akhil,
Arek will add RSA signature tests with padding-none option.
I will review and ack after this
Fiona

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Tuesday, October 15, 2019 11:23 AM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org; Trahe, Fiona
> <fiona.trahe@intel.com>
> Subject: RE: [PATCH v2 0/5] Add session-less, RSA, RSA-CRT to QAT
> 
> Hi Arek,
> >
> > This patchset adds session-less option, RSA algorithm, RSA-CRT algorithm
> > to Intel QuickAssist Technology PMD.
> >
> > This patchset depends on the
> > [v5] cryptodev: extend api of asymmetric crypto by session-less [1]
> >
> > [1]
> > http://patchwork.dpdk.org/patch/60882/
> >
> Could you please rebase this patch so that compilation can be tested by CI.
> The dependent patch is merged.
> Also please update the patch titles as below.
> 
> @fiona.trahe@intel.com: could you please review this series and provide Ack
> 
> > v2:
> > - fixed alg size problem in crt
> > - fixed rsa capabilities
> > - added rsa test cases
> >
> > Arek Kusztal (5):
> >   crypto/qat: add sessionless implementation to asym pmd
> crypto/qat: support asymmetric sessionless ops
> 
> >   crypto/qat: add rsa implementation to asym pmd
> crypto/qat: support RSA
> >   crypto/qat: add rsa crt implementation to asym pmd
> crypto/qat: support RSA CRT
> >   test/crypto: add sessionless to asymmetric mod exp
> test/crypto: support sessionless in asymmetric cases
> >   test/crypto: add rsa tests to qat
> test/crypto: add RSA cases in QAT
> 
> Also please add more meaningful patch description.
> 
> >
> >  app/test/test_cryptodev_asym.c                     | 182 ++++--
> >  app/test/test_cryptodev_rsa_test_vectors.h         | 213 +++++++
> >  doc/guides/cryptodevs/features/qat.ini             |   4 +
> >  doc/guides/rel_notes/release_19_11.rst             |   8 +
> >  .../qat/qat_adf/qat_pke_functionality_arrays.h     |  27 +
> >  drivers/crypto/qat/qat_asym.c                      | 616 ++++++++++++++++-----
> >  drivers/crypto/qat/qat_asym.h                      |  29 +-
> >  drivers/crypto/qat/qat_asym_capabilities.h         |  21 +
> >  drivers/crypto/qat/qat_asym_pmd.c                  |   5 +-
> >  9 files changed, 925 insertions(+), 180 deletions(-)
> >
> > --
> > 2.1.0