From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18FC2A328D for ; Tue, 22 Oct 2019 14:00:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D4C231BEB8; Tue, 22 Oct 2019 14:00:51 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 6FB384C8E for ; Tue, 22 Oct 2019 14:00:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2019 05:00:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,326,1566889200"; d="scan'208";a="349034841" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga004.jf.intel.com with ESMTP; 22 Oct 2019 05:00:47 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.76]) by irsmsx105.ger.corp.intel.com ([169.254.7.210]) with mapi id 14.03.0439.000; Tue, 22 Oct 2019 13:00:46 +0100 From: "Trahe, Fiona" To: Akhil Goyal , "dev@dpdk.org" CC: "Kusztal, ArkadiuszX" , "Dybkowski, AdamX" , "Trahe, Fiona" Thread-Topic: [PATCH] cryptodev: clarify wireless inputs in digest-encrypted cases Thread-Index: AQHViMy2EJ9WMGQvJkOnOcP4iq9hIqdmevUAgAATcCA= Date: Tue, 22 Oct 2019 12:00:46 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435A217B6E0@IRSMSX101.ger.corp.intel.com> References: <1571744076-7623-1-git-send-email-fiona.trahe@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODVkYzc4YmYtNzYzNy00Mjk3LWFlOTctMzllZWQxYWM1YTQ4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYmYwZGlYMzZxTFRkSkxkd0NWSXRKWGk2NkJxUVNrQk80cGg5OG56VnlZRHdaNDY2UHZNRTc0a216YjNvZTV0aSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] cryptodev: clarify wireless inputs in digest-encrypted cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > Sent: Tuesday, October 22, 2019 12:49 PM > To: Trahe, Fiona ; dev@dpdk.org > Cc: Kusztal, ArkadiuszX ; Dybkowski, AdamX > > Subject: RE: [PATCH] cryptodev: clarify wireless inputs in digest-encrypt= ed cases >=20 > Hi Fiona, >=20 > > > > Clarify constraints on fields specified in bits for wireless > > algorithms in digest-encrypted case. > > > > Signed-off-by: Fiona Trahe > > --- > > lib/librte_cryptodev/rte_crypto_sym.h | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > > > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h > > b/lib/librte_cryptodev/rte_crypto_sym.h > > index bc8da24..0204d37 100644 > > --- a/lib/librte_cryptodev/rte_crypto_sym.h > > +++ b/lib/librte_cryptodev/rte_crypto_sym.h > > @@ -703,6 +703,13 @@ struct rte_crypto_sym_op { > > * auth.data.length and is typically > > * equal to auth.data.offset + > > * auth.data.length + digest_length. > > + * - for wireless algorithms, i.e. > > + * SNOW 3G, KASUMI and ZUC, as the > > + * cipher.data.length, > > + * cipher.data.offset, > > + * auth.data.length and > > + * auth.data.offset are in bits, they > > + * must be 8-bit multiples. >=20 > What is the meaning of 'they' here? > cipher.data.length, cipher.data.offset, auth.data.length and auth.data.of= fset are in bits > and may or may not be multiple of 8bits. This is documented in their comm= ents. >=20 [Fiona] This added note is an extra bullet under the explanation for Digest= -encrypted cases. In these cases only those fields listed MUST be 8-bit multiples. Can you suggest a change that would make that clearer? =20 >=20 > > * > > * Note, that for security reasons, it > > * is PMDs' responsibility to not > > -- > > 1.7.0.7