From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82CCCA328D for ; Tue, 22 Oct 2019 16:47:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E48E21BEF8; Tue, 22 Oct 2019 16:47:02 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A21051BEF1 for ; Tue, 22 Oct 2019 16:46:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2019 07:46:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,327,1566889200"; d="scan'208";a="200806080" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga003.jf.intel.com with ESMTP; 22 Oct 2019 07:46:56 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.76]) by irsmsx105.ger.corp.intel.com ([169.254.7.210]) with mapi id 14.03.0439.000; Tue, 22 Oct 2019 15:46:55 +0100 From: "Trahe, Fiona" To: Akhil Goyal , "dev@dpdk.org" CC: "Kusztal, ArkadiuszX" , "Dybkowski, AdamX" , "Trahe, Fiona" Thread-Topic: [PATCH v2] cryptodev: clarify wireless inputs in digest-encrypted cases Thread-Index: AQHViNt6tc425oDsK0mPUcMk7xv76qdmlY0AgAAki1A= Date: Tue, 22 Oct 2019 14:46:54 +0000 Message-ID: <348A99DA5F5B7549AA880327E580B435A217BA58@IRSMSX101.ger.corp.intel.com> References: <1571744076-7623-1-git-send-email-fiona.trahe@intel.com> <1571750416-11742-1-git-send-email-fiona.trahe@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzlkNjMxYTgtYjRiYy00MTc2LTk4YzUtZTY3ZWQwYzA4ZWU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQUp5Q2xKeFlTcm5cL3Z6Q0ZxNm1ESkxsVmdQSVdBOG1mcnp1M2tBQmZlV093VGJpY2ZBdnFJZTJkc1VGNkNwZXIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: clarify wireless inputs in digest-encrypted cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, October 22, 2019 2:24 PM > To: Trahe, Fiona ; dev@dpdk.org > Cc: Kusztal, ArkadiuszX ; Dybkowski, AdamX > > Subject: RE: [PATCH v2] cryptodev: clarify wireless inputs in digest-encr= ypted cases >=20 >=20 >=20 > > > > Clarify constraints on fields specified in bits for wireless > > algorithms in digest-encrypted case. > > > > v2 changes: > > - added note on each of the affected parameter fields > > > > Signed-off-by: Fiona Trahe > > --- > > lib/librte_cryptodev/rte_crypto_sym.h | 23 +++++++++++++++++++---- > > 1 files changed, 19 insertions(+), 4 deletions(-) > > > //snip// >=20 > > @@ -703,6 +711,13 @@ struct rte_crypto_sym_op { > > * auth.data.length and is typically > > * equal to auth.data.offset + > > * auth.data.length + digest_length. > > + * - for wireless algorithms, i.e. > > + * SNOW 3G, KASUMI and ZUC, as the > > + * cipher.data.length, > > + * cipher.data.offset, > > + * auth.data.length and > > + * auth.data.offset are in bits, they > > + * must be 8-bit multiples. >=20 > Why do you need this change? This is redundant information. [Fiona] I think it's useful that it's under the digest-encrypted case notes= . So ok as is and is good to have info in both places people may look. However if we want to avoid duplication, then I'd prefer to keep here and a= dd a note under the specific params to direct to check here. Like: *= and ZUC @ RTE_CRYPTO_CIPHER_ZUC_EEA3, - * this field should be in bits. + * this field should be in bits. See also + * notes about digest-encrypted case. */