From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBBC9A0C4C; Tue, 5 Oct 2021 18:49:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB91F413DD; Tue, 5 Oct 2021 18:49:37 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 387DD4138A for ; Tue, 5 Oct 2021 18:49:36 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id D1801580FF8; Tue, 5 Oct 2021 12:49:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 05 Oct 2021 12:49:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= ED309/BtdTTucojxd/Aee2z576uJPDev5KxOhMXPHgE=; b=gm60JXlIY8+VBRAc gQRx5tyjz+7/cXt+/ee7hjOd9ISg7cbjKOUx/5oSaje/vJbjwSnBsDqGH1ziq8By NlPmzMJKrkMmHsY34yuMG9+yvDbqB3yr2Q1666UpmU6/EvAbVK/dZTbxfMH0XskJ z2Yw5Xu2OyieucySpZITY8RhFEIFv1EaP/dIqoOWEvVSUm81NH92SKhJdaVmLRyD OILbVR0dnsos43MjTUi4h/3U8RduX8iCXCzWF5pu5R4Ky6pEk0BNirsKOBxYwUDe 9F3FBBbxXrRDPI/eP+Oit+M9zAWEAhafPYzAr7qrp6++2xpeCZMKzhMPGAfKNBiO If6OGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ED309/BtdTTucojxd/Aee2z576uJPDev5KxOhMXPH gE=; b=OoNb2hSsQPcqxpWpyKA5s1NM1kJec2tzzHDKHt+5BndA8IVrlhhWhcBCr AA3U4OkKtme0GrftWiRjVrmcFwudyKYuwvkAZybUj7XFNKmZHb0qxyodv8rj5rJQ WMkUqKRYK0S/aRfAKT/ov1Fgz4XxjDZuqQckaZVbu+ZgrnnTcaVK5FgmVPmRpYhF p1rySJRhPL4HFG6HQvL1taMRI6Fb20IW7ymJlG7j3Sm5bN459v5ftuY5tGpXN2ze PuUv7AB788J73vxNerilqPSRDG2vRSuc7vEHfpxapEMU0MZpi6OnLLHz7lXAxPnD 3J+lEyTvCcIAjx5DNyZyXnp/fGm4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelgedguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Oct 2021 12:49:26 -0400 (EDT) From: Thomas Monjalon To: "Ananyev, Konstantin" Cc: "dev@dpdk.org" , "Li, Xiaoyun" , "anoobj@marvell.com" , "jerinj@marvell.com" , "ndabilpuram@marvell.com" , "adwivedi@marvell.com" , "shepard.siegel@atomicrules.com" , "ed.czeck@atomicrules.com" , "john.miller@atomicrules.com" , "irusskikh@marvell.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "rahul.lakkireddy@chelsio.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "Wang, Haiyue" , "Daley, John" , "hyonkim@cisco.com" , "Zhang, Qi Z" , "Wang, Xiao W" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "oulijun@huawei.com" , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "sthemmin@microsoft.com" , "longli@microsoft.com" , "heinrich.kuhn@corigine.com" , "kirankumark@marvell.com" , "andrew.rybchenko@oktetlabs.ru" , "mczekaj@marvell.com" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" , "maxime.coquelin@redhat.com" , "Xia, Chenbo" , "Yigit, Ferruh" , "mdr@ashroe.eu" , "Jayatheerthan, Jay" Date: Tue, 05 Oct 2021 18:49:24 +0200 Message-ID: <3492515.AmsB7BIxPL@thomas> In-Reply-To: References: <20211001140255.5726-1-konstantin.ananyev@intel.com> <2309344.bJfOgahzzc@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/7] ethdev: allocate max space for internal queue array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/10/2021 18:45, Ananyev, Konstantin: > > > At queue configure stage always allocate space for maximum possible > > > number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. > > > That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer > > > pointer to internal queue data without extra checking of current number > > > of configured queues. > > > > What is the memory usage overhead per port? > > (2*sizeof(uintptr_t))* RTE_MAX_QUEUES_PER_PORT > With RTE_MAX_QUEUES_PER_PORT==1024 (default value) it is 16KB per port. Please add it in the commit log. > > We should consider cases with thousand of virtual ports. > > For 1K ports (with 1K queues each) it will be 16MB. OK it looks reasonnable.