From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3E31A0518; Fri, 19 Jun 2020 17:43:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 89E9D1BEDE; Fri, 19 Jun 2020 17:43:37 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2A1E21BEB7 for ; Fri, 19 Jun 2020 17:43:36 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8017A5C0073; Fri, 19 Jun 2020 11:43:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 19 Jun 2020 11:43:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= kZBGN/niqwUEp9eI8SBmATwjoVaBcF3F7rkNJSijheo=; b=ZH+5iI2vk2vjnzCh HvFxq7QyZSjvGUeW09cEClXAwDlUkXZciAblxIIwQptiJKc0XnKGThsQ2qLjsEJP HaowofbwjdKJELwQyhQ6r+2wNjRKMOS0b9P+5c5bXo9nPYbx0vwqD1Lbu9HCdEuO JMulj+bcAh3Gbku9Z2C2WuUcfoeqqjVGcXpqplWAKt59rNM9loxJrW/q2BLalX3C 6vPmVCHc66kwnMOrd6pjqXwDnISyB+rA95NaCSuV/iyJU/3bWDdRlNQIpqTWEI8R xNTsFAEOX9tHhhavFxV71FoSNaQgE0FhRixpOE9MEnVCJFrjNxcG7xAG0F90leRZ GlWzOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=kZBGN/niqwUEp9eI8SBmATwjoVaBcF3F7rkNJSijh eo=; b=Ni04kxaQntEbDnKgmPblwSKK9Ei255Ff6C6Ddy+3TGllk+/JTB+SiH8Og DZpL6oHKKJj80x98m2FI3Hty+TfJbRvll/SfZsvRWhts0CVHe0JiRe0OwbMyQB7j Q7GEn8wz6E+pEzqujhJGVAVV3wekPAiIJBWR6H55zzBy/AmTz22PJA6Q6LGPp1Wk tD6Fh8wam44DhIiOwueuktpfUEbptKy2RN+wVULHA9Y8WmFGQwoH3P6Wv/XuAn5p 3oSGONo/usdPz1WroV7QzXCvgiQ/EM84v0iB82OMA4i03I00oqmMt7TCnSABiqnz QaI714dLLEnmbG5/WD73qkD+x1ggw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejiedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8554130624CC; Fri, 19 Jun 2020 11:43:33 -0400 (EDT) From: Thomas Monjalon To: Dharmik Thakkar Cc: Ferruh Yigit , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , John McNamara , Marko Kovacevic , dpdk-dev , nd , "Richardson, Bruce" Date: Fri, 19 Jun 2020 17:43:32 +0200 Message-ID: <34965300.jtcX6sOceb@thomas> In-Reply-To: <4246D30E-F8C7-48B4-843D-30FC1EFC0095@arm.com> References: <20200508223829.3228-3-dharmik.thakkar@arm.com> <2923078.vE1UA2jcWa@thomas> <4246D30E-F8C7-48B4-843D-30FC1EFC0095@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 2/2] doc: include config options in testpmd user guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/06/2020 17:38, Dharmik Thakkar: > + Bruce >=20 > > On Jun 17, 2020, at 2:48 PM, Thomas Monjalon wrot= e: > >=20 > > 17/06/2020 20:21, Ferruh Yigit: > >> On 5/20/2020 4:20 AM, Dharmik Thakkar wrote: > >>> Update testpmd documentation to include RECORD configuration options, > >>> CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and > >>> CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS. > >>>=20 > >>> Signed-off-by: Dharmik Thakkar > >>> Reviewed-by: Honnappa Nagarahalli > >>> Reviewed-by: Phil Yang > >>> --- > >>> v3: > >>> - Replace config/common_base with build/.config (Thomas) > >>>=20 > >>> v2: > >>> - Remove extra '#'. > >>> --- > >>> doc/guides/testpmd_app_ug/build_app.rst | 12 ++++++++++++ > >>> 1 file changed, 12 insertions(+) > >>>=20 > >>> diff --git a/doc/guides/testpmd_app_ug/build_app.rst b/doc/guides/tes= tpmd_app_ug/build_app.rst > >>> index d1ca9f3d19a9..8c9aaa83187f 100644 > >>> --- a/doc/guides/testpmd_app_ug/build_app.rst > >>> +++ b/doc/guides/testpmd_app_ug/build_app.rst > >>> @@ -21,6 +21,18 @@ The basic compilation steps are: > >>>=20 > >>> export RTE_TARGET=3Dx86_64-native-linux-gcc > >>>=20 > >>> +#. If required, enable configuration options. For example: > >>> + > >>> + .. code-block:: console > >>> + > >>> + cd to the top-level DPDK directory > >>> + sed -i 's,\(CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES\)=3Dn,\1= =3Dy,' build/.config > >>> + sed -i 's,\(CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS\)=3Dn,\1= =3Dy,' build/.config > >>> + > >>> + Enabling CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES enables measurem= ent of CPU cycles. > >>> + > >>> + Enabling CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS enables display = of RX and TX bursts. > >>> + > >>> #. Build the application: > >>>=20 > >>> .. code-block:: console > >>>=20 > >>=20 > >> Hi Dharmik, > >>=20 > >> This patch waiting to address the Thomas comment on document how to en= able those > >> config options in meson. @Thomas, can you please correct if I got it w= rong? > >=20 > > If the doc is only about make, it will be removed in 2 months. > > So yes, I think it doesn't make sense to be merged as is. > >=20 >=20 > Make sense. >=20 > With meson, I see multiple ways to enable configuration options: >=20 > 1] macro in $(RTE_SDK)/config/rte_config.h > 2] using dpdk_conf.set() in $(RTE_SDK)/config/meson.build >=20 > I=E2=80=99d appreciate some suggestions on the best way to enable these o= ptions. Neither 1 nor 2 because both are source files. Configuration must be done in the build directory. We use "meson -D" to configure options listed in meson_options.txt The real question is which option we accept to be added.