From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52E68A0547; Wed, 29 Sep 2021 18:21:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD9A5410EA; Wed, 29 Sep 2021 18:20:59 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 95E95410E5 for ; Wed, 29 Sep 2021 18:20:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F07A75C00C2; Wed, 29 Sep 2021 12:20:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 29 Sep 2021 12:20:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 1HnagKHiX2qNAuHfyMBUhRicnszziOjuLclVrOpRiAc=; b=XjrrEdDDtrJX6RjG 4JTlX4+CKSz1C/Ls+ft6BgzSJ5owxuDRhAWBt8JahDrgpX9YeI081B7WBNux8xSg s/XFiFwaVWFu2nVvWg23q1Vl6gQH2F22wDNEyM62HTtESgJJCDSH8LVbr5/ijH4n cFL3L1lNtFRSECap6sCOqmU6uNYRTKwsrNywZvtu8L6WEBsJfla7gdDy1tPBqawd IpaMMVw0CuguxWj5IebwjSWLNno1fMXX2XH0vMYbTCc3GQWTW5hc+ppNinqaiUmz cOF3jwqeXYGrfpKgUB5ZXLmVrHg/cCLG09r2D310SBRukD/0GqdNuKU8GXhba4t8 X4EQJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=1HnagKHiX2qNAuHfyMBUhRicnszziOjuLclVrOpRi Ac=; b=NlhUPsgTKAbOwI2PivS0jb/Bw4DQmFKyA2yjAn2loxtphbO4doY5jA22d ejJjP8bTx44klpaSs9cH47MwVO9/lfeJN94FAA3AwfOXYEAqGHT1viBNXPx3LRyS 19A914K055nKs/E/CqyCtE/NW36LAjBG4glMR65M2zP9BnCPTvHxTWf4nalUekDC ztJIyzP3mDcMXWxHCvPIB6fxCbnQgIKYFbkbz63ESR/FjPDXJziIAhKetT5d7vvu AU23pGoEDlWadJQnBMja3gAYYGFlJwSampyeqWOyBrV4djXRMjQfaGbcyUPuqWNW S3HBmLTVr+2x/H2R19pWD+eeocIIg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekvddgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeekgeetffeiteekheeugeeghfetkeeukedtfeefkeffvddvudeu hffgffeigfevnecuffhomhgrihhnpehfrhgvvggsshgurdhorhhgnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Sep 2021 12:20:56 -0400 (EDT) From: Thomas Monjalon To: Srikanth K Cc: Matan Azrad , Viacheslav Ovsiienko , dev@dpdk.org, Vag Singh , Anand Thulasiram , asafp@nvidia.com, shys@nvidia.com Date: Wed, 29 Sep 2021 18:20:55 +0200 Message-ID: <3498914.nWIOhJD1b8@thomas> In-Reply-To: References: <20210927133450.10653-1-srikanth.k@oneconvergence.com> <2862022.4b9u9FZ0aI@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/09/2021 17:56, Srikanth K: > Hi Thomas, > > PFA the test report. It covers all the features that were tested across > various platforms. > > The features mentioned in the test report depend on a modified FreeBSD > OFED. There is an ongoing review of these changes by the FreeBSD community. > https://reviews.freebsd.org/p/vag.singh_oneconvergence.com/ OK, this dependency is very important to notify in this patchset. For next version, please add it in the cover letter. The supported features (MTU, MAC, VLAN, RSS, fragments, jumbo, stats and trust mode) should be listed in the cover letter as well as in the mlx5 documentation. Please follow what was done for Windows. About the patches organization, please do not fix or remove something which was added in a previous patch. You need to have logical steps done in each patch without going backward. Please start with enabling compilation in first patch, so each step can be tested. Thanks