From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (szxga02-in.huawei.com [45.249.212.188]) by dpdk.org (Postfix) with ESMTP id EB0705F25 for ; Wed, 14 Mar 2018 12:51:05 +0100 (CET) Received: from DGGEMM405-HUB.china.huawei.com (unknown [172.30.72.56]) by Forcepoint Email with ESMTP id AE1C9519D7968 for ; Wed, 14 Mar 2018 19:51:00 +0800 (CST) Received: from DGGEMM513-MBS.china.huawei.com ([169.254.4.39]) by DGGEMM405-HUB.china.huawei.com ([10.3.20.213]) with mapi id 14.03.0361.001; Wed, 14 Mar 2018 19:50:54 +0800 From: wangyunjian To: "Rybalchenko, Kirill" , "dev@dpdk.org" CC: caihe Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister by adding retry Thread-Index: AQHTu4Q6fuOB8zRWf0iQcDaoS2jagaPPnQrg Date: Wed, 14 Mar 2018 11:50:54 +0000 Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60C749269@dggemm513-mbs.china.huawei.com> References: <1520924004-15708-1-git-send-email-wangyunjian@huawei.com> <696B43C21188DF4F9C9091AAE4789B824E2D62F3@IRSMSX108.ger.corp.intel.com> In-Reply-To: <696B43C21188DF4F9C9091AAE4789B824E2D62F3@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.24.66] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister by adding retry X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 11:51:07 -0000 > -----Original Message----- > From: Rybalchenko, Kirill [mailto:kirill.rybalchenko@intel.com] > Sent: Wednesday, March 14, 2018 7:04 PM > To: wangyunjian ; dev@dpdk.org > Cc: caihe > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister= by > adding retry >=20 > Hi Yunjian, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of wangyunjian > > Sent: Tuesday 13 March 2018 06:53 > > To: dev@dpdk.org > > Cc: caihe@huawei.com; Yunjian Wang > > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix intr callback unregister > > by adding retry > > > > From: Yunjian Wang > > > > The nic's interrupt source has some active callbacks, when the port hot= plug. > > Add a retry to give more port's a chance to uninit before returning an = error. > > > > Fixes: d42aaf30008b ("i40e: support port hotplug") > > > > Signed-off-by: Yunjian Wang > > --- > > v2: > > * Fix return value check > > --- > > drivers/net/i40e/i40e_ethdev.c | 16 ++++++++++++++-- > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 508b417..0a29fdd 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -1533,6 +1533,7 @@ void i40e_flex_payload_reg_set_default(struct > > i40e_hw *hw) > > struct rte_flow *p_flow; > > int ret; > > uint8_t aq_fail =3D 0; > > + int retries =3D 0; > > > > PMD_INIT_FUNC_TRACE(); > > > > @@ -1575,8 +1576,19 @@ void i40e_flex_payload_reg_set_default(struct > > i40e_hw *hw) > > rte_intr_disable(intr_handle); > > > > /* register callback func to eal lib */ >=20 >=20 > It's not a part of your patch, but I believe it makes sense to fix this: > /* unregister callback func from eal lib */ Thanks, I will send the v3 to fix this later. >=20 > > - rte_intr_callback_unregister(intr_handle, > > - i40e_dev_interrupt_handler, dev); > > + do { > > + ret =3D rte_intr_callback_unregister(intr_handle, > > + i40e_dev_interrupt_handler, dev); > > + if (ret >=3D 0) { > > + break; > > + } else if (ret !=3D -EAGAIN) { > > + PMD_INIT_LOG(ERR, > > + "intr callback unregister failed: %d", > > + ret); > > + return ret; > > + } > > + i40e_msec_delay(100); > > + } while (retries++ < 5); > > > > i40e_rm_ethtype_filter_list(pf); > > i40e_rm_tunnel_filter_list(pf); > > -- > > 1.8.3.1 > >