From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 5455DA0597;
	Wed,  8 Apr 2020 03:25:14 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id BE8C31BE8E;
	Wed,  8 Apr 2020 03:25:13 +0200 (CEST)
Received: from huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by dpdk.org (Postfix) with ESMTP id 299932BE2;
 Wed,  8 Apr 2020 03:25:12 +0200 (CEST)
Received: from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.53])
 by Forcepoint Email with ESMTP id DF66637A959607694E27;
 Wed,  8 Apr 2020 09:25:10 +0800 (CST)
Received: from DGGEMM422-HUB.china.huawei.com (10.1.198.39) by
 DGGEMM406-HUB.china.huawei.com (10.3.20.214) with Microsoft SMTP Server (TLS)
 id 14.3.487.0; Wed, 8 Apr 2020 09:25:10 +0800
Received: from DGGEMM533-MBX.china.huawei.com ([169.254.5.250]) by
 dggemm422-hub.china.huawei.com ([10.1.198.39]) with mapi id 14.03.0487.000;
 Wed, 8 Apr 2020 09:25:00 +0800
From: wangyunjian <wangyunjian@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
CC: "dev@dpdk.org" <dev@dpdk.org>, "keith.wiles@intel.com"
 <keith.wiles@intel.com>, "Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
 xudingke <xudingke@huawei.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev]  [PATCH v3 4/5] net/tap: fix close a valid fd
Thread-Index: AQHWDOy9qRff/b4zTk+p5iKInQIBVahubpiQ
Date: Wed, 8 Apr 2020 01:24:59 +0000
Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60CF5C5F2@DGGEMM533-MBX.china.huawei.com>
References: <1586233406-10268-1-git-send-email-wangyunjian@huawei.com>
 <20200407075600.0d83b7a1@hermes.lan>
In-Reply-To: <20200407075600.0d83b7a1@hermes.lan>
Accept-Language: en-US
Content-Language: zh-CN
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.173.251.152]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH v3 4/5] net/tap: fix close a valid fd
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, April 7, 2020 10:56 PM
> To: wangyunjian <wangyunjian@huawei.com>
> Cc: dev@dpdk.org; keith.wiles@intel.com; Lilijun (Jerry)
> <jerry.lilijun@huawei.com>; xudingke <xudingke@huawei.com>;
> stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 4/5] net/tap: fix close a valid fd
>=20
> On Tue, 7 Apr 2020 12:23:26 +0800
> wangyunjian <wangyunjian@huawei.com> wrote:
>=20
> > The internals is freed and setted NULL in the rte_eth_dev_release_port(=
)
>=20
> The word "setted" is awkward in this phrase.
> Better wording would be:
>=20
> The internal structure is freed and set to NULL in rte_eth_dev_release_po=
rt()

OK, I will fix it in v4.

Thanks
Yunjian