From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C5DEA04DB; Fri, 16 Oct 2020 00:47:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9F9581DE7A; Fri, 16 Oct 2020 00:47:25 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CA68A1DE79 for ; Fri, 16 Oct 2020 00:47:23 +0200 (CEST) IronPort-SDR: UE1S29d5fQxWX8iwLJVMCEqGom9U7/XxtQkHrZTYTK1lsoQfNTyruubW2mg1loDxQliXBy8cLs 3UBiPhPP49uw== X-IronPort-AV: E=McAfee;i="6000,8403,9775"; a="166580987" X-IronPort-AV: E=Sophos;i="5.77,380,1596524400"; d="scan'208";a="166580987" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 15:47:21 -0700 IronPort-SDR: M8p3Cz67GMxIHHsn+H/MTxwOKxPwo/9DrH2hOURB4qC/SFoBfDN6Msru6dr4FH3YNtGkwr1yBO e3doi9YhH7LA== X-IronPort-AV: E=Sophos;i="5.77,380,1596524400"; d="scan'208";a="464469444" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.84.112]) ([10.251.84.112]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2020 15:47:20 -0700 To: Gregory Etelson , dev@dpdk.org Cc: matan@nvidia.com, rasland@nvidia.com, elibr@nvidia.com, ozsh@nvidia.com References: <20200625160348.26220-1-getelson@mellanox.com> <20201015124154.13357-1-getelson@nvidia.com> From: Ferruh Yigit Message-ID: <34a0eac7-1f08-80b5-2e09-7fd6aed7add4@intel.com> Date: Thu, 15 Oct 2020 23:47:15 +0100 MIME-Version: 1.0 In-Reply-To: <20201015124154.13357-1-getelson@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 0/3] Tunnel Offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/15/2020 1:41 PM, Gregory Etelson wrote: > Tunnel Offload API provides hardware independent, unified model > to offload tunneled traffic. Key model elements are: > - apply matches to both outer and inner packet headers > during entire offload procedure; > - restore outer header of partially offloaded packet; > - model is implemented as a set of helper functions. > > v2: > * documentation updates > * MLX5 PMD implementation for tunnel offload > * testpmd updates for tunnel offload > > v3: > * documentation updates > * MLX5 PMD updates > * testpmd updates > > v4: > * updated patch: allow negative values in flow rule types > > v5: > * rebase to next-net > > Eli Britstein (1): > ethdev: tunnel offload model > > Gregory Etelson (2): > ethdev: allow negative values in flow rule types > app/testpmd: add commands for tunnel offload API > 32 build fails [1], can you please check? Also there are a few typos [2]. [1] ../app/test-pmd/config.c: In function ‘port_flow_tunnel_list’: ../app/test-pmd/config.c:1580:18: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Werror=format=] 1580 | printf(" id=%lu", flt->tunnel.tun_id); | ~~^ ~~~~~~~~~~~~~~~~~~ | | | | | uint64_t {aka long long unsigned int} | long unsigned int | %llu [2] ### ethdev: allow negative values in flow rule types WARNING:TYPO_SPELLING: 'becase' may be misspelled - perhaps 'because'? #17: actions do not fit into this scheme becase PMD type values are total: 0 errors, 1 warnings, 72 lines checked ### app/testpmd: add commands for tunnel offload API WARNING:TYPO_SPELLING: 'argumens' may be misspelled - perhaps 'arguments'? #87: FILE: app/test-pmd/cmdline_flow.c:79: + /* Tunnel argumens. */