From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id A43AA5F21 for ; Tue, 2 Oct 2018 16:38:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2018 07:38:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,332,1534834800"; d="scan'208";a="93971239" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.113]) ([10.237.220.113]) by fmsmga004.fm.intel.com with ESMTP; 02 Oct 2018 07:32:23 -0700 To: Jeff Guo , stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, arybchenko@solarflare.com, wenzhuo.lu@intel.com, jerin.jacob@caviumnetworks.com Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, helin.zhang@intel.com References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <1538483726-96411-1-git-send-email-jia.guo@intel.com> <1538483726-96411-4-git-send-email-jia.guo@intel.com> From: "Burakov, Anatoly" Message-ID: <34b1d516-14b7-876b-7cd9-3854dbc2d0a9@intel.com> Date: Tue, 2 Oct 2018 15:32:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1538483726-96411-4-git-send-email-jia.guo@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v12 3/7] bus: add sigbus handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 14:38:23 -0000 On 02-Oct-18 1:35 PM, Jeff Guo wrote: > When a device is hot-unplugged, a sigbus error will occur of the datapath > can still read/write to the device. A handler is required here to capture > the sigbus signal and handle it appropriately. > > This patch introduces a bus ops to handle sigbus errors. Each bus can > implement its own case-dependent logic to handle the sigbus errors. > > Signed-off-by: Jeff Guo > Acked-by: Shaopeng He > --- > v12->v11: > no change. > --- > lib/librte_eal/common/include/rte_bus.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h > index 1bb53dc..201454a 100644 > --- a/lib/librte_eal/common/include/rte_bus.h > +++ b/lib/librte_eal/common/include/rte_bus.h > @@ -182,6 +182,21 @@ typedef int (*rte_bus_parse_t)(const char *name, void *addr); > typedef int (*rte_bus_hot_unplug_handler_t)(struct rte_device *dev); > > /** > + * Implement a specific sigbus handler, which is responsible for handling > + * the sigbus error which is either original memory error, or specific memory > + * error that caused of device be hot-unplugged. When sigbus error be captured, > + * it could call this function to handle sigbus error. > + * @param failure_addr > + * Pointer of the fault address of the sigbus error. > + * > + * @return > + * 0 for success handle the sigbus. > + * 1 for no bus handle the sigbus. I think the comment here should be reworded. I can't parse "no bus handle the sigbus" - what does that mean, and how is it different from an error? -- Thanks, Anatoly