From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDA4E458CD; Mon, 2 Sep 2024 11:55:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07AFD4066D; Mon, 2 Sep 2024 11:55:22 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 5FAFD400EF for ; Mon, 2 Sep 2024 11:55:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725270902; x=1756806902; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FUP9ngeIEEJTyR1PbNFK3mZZejG4FJHAInjiEjTkX+E=; b=CTgI3NlFRTPEWIF+cP2W3MRPb3fKe484PUrGYJxv7aP7gVFhKCuJ5/pW 8BhDE81gT1SZ7BWIZ6ziLDNc/a6Jd/LRZI+whNN7W209WwHyafUve0dST 2anppvKNAg6CMIJv3gt2AAD59eTJCSJcFOlxQ/tFI5byUU/Jj7iZc+Ocg 3ZwVgb+R4S6gWJdGAqy2+ZdXVJDzYohxv57MpFW355nvwAYH0O480zMEh T7FFCKGhzPKtklrAOU29YnoHA36uFGwxl1JxW+X7Uo1mP+TTc4M81FGEa +1E9FSuwQAhz9N+dlMt98q+6e/2o4FpcNJ2zmu+gwtr56HTG4mlCdIyyl A==; X-CSE-ConnectionGUID: cVMDkSyxT8a7QIChP7gZsA== X-CSE-MsgGUID: 5InNISk7TSCCTGsgCea4ww== X-IronPort-AV: E=McAfee;i="6700,10204,11182"; a="26747184" X-IronPort-AV: E=Sophos;i="6.10,195,1719903600"; d="scan'208";a="26747184" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2024 02:55:01 -0700 X-CSE-ConnectionGUID: gR1jWIW6Rse0faX3jdDMEw== X-CSE-MsgGUID: 7Q39ZdVeSEi+Se2dM2GqGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,195,1719903600"; d="scan'208";a="64597874" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by fmviesa009.fm.intel.com with ESMTP; 02 Sep 2024 02:55:00 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: bruce.richardson@intel.com Subject: [PATCH v1 05/30] net/i40e/base: don't set flags in i40e_init_shared_code Date: Mon, 2 Sep 2024 10:54:17 +0100 Message-ID: <34e61f3c50fff77a65733bae1ec5bce22d1d29d1.1725270827.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The functionality to set i40e_hw's flags was moved to its own function in AQ a while ago: commit 37b091c75b13 ("net/i40e/base: extend PHY access AQ command") However, the setting of hw->flags for X722 was not removed, even though it has become unnecessary. Signed-off-by: Anatoly Burakov --- drivers/net/i40e/base/i40e_common.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index e4de508aea..451cc2c1c7 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -980,9 +980,6 @@ enum i40e_status_code i40e_init_shared_code(struct i40e_hw *hw) else hw->pf_id = (u8)(func_rid & 0x7); - if (hw->mac.type == I40E_MAC_X722) - hw->flags |= I40E_HW_FLAG_AQ_SRCTL_ACCESS_ENABLE | - I40E_HW_FLAG_NVM_READ_REQUIRES_LOCK; /* NVMUpdate features structure initialization */ hw->nvmupd_features.major = I40E_NVMUPD_FEATURES_API_VER_MAJOR; hw->nvmupd_features.minor = I40E_NVMUPD_FEATURES_API_VER_MINOR; -- 2.43.5