From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39BF441C7F; Mon, 13 Feb 2023 03:44:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82A49410F2; Mon, 13 Feb 2023 03:44:33 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 0A37740EE7 for ; Mon, 13 Feb 2023 03:44:31 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PFTBp0tH5znW5F; Mon, 13 Feb 2023 10:42:10 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 13 Feb 2023 10:44:28 +0800 Subject: Re: [PATCH] ethdev: telemetry xstats support hide zero To: Ferruh Yigit , , CC: , , References: <20230209030755.48028-1-fengchengwen@huawei.com> <5e68e212-4391-e32a-91c1-2fd1874e758c@amd.com> From: fengchengwen Message-ID: <34eb7f1b-0e36-70f1-4184-44e49cc3b30f@huawei.com> Date: Mon, 13 Feb 2023 10:44:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/2/10 19:55, Ferruh Yigit wrote: > On 2/10/2023 1:23 AM, fengchengwen wrote: >> On 2023/2/10 7:30, Ferruh Yigit wrote: >>> On 2/9/2023 3:07 AM, Chengwen Feng wrote: >>>> The number of xstats may be large, after the hide zero option is added, >>>> only non-zero values can be displayed. >>>> >>> >>> Hi Chengwen, >>> >>> No objection on the functionality, we have similar config option in >>> testpmd too, but I have some question on telemetry side of things: >>> >>> 1) optional parameters, I don't know if there is a defined way to handle >>> this in telemetry but with current method only one optional parameter >>> can be supported and it has to be the last one. In the feature if a new >>> mandatory option required, this changes the user interface. To prevent >>> this, is it possible to use "key=value" syntax, like >>> "/ethdev/xstats,0,hide_zero=true" >>> >>> This way order or existence of multiple options doesn't matter. >> >> Yes, KV (just like PMD's runtime parameters) is more flexible for multiple optional parameters. >> AFAIK, only some dmadev commands have optional parameters (which using this patch way to identify). >> >> Until there are more parameters, I think we can keep the status quo. >> > > I think better to start using it with first optional parameter, which is > this patch, otherwise it will be pushing the work to next contributor. v2 implements it, please review, thanks. > >>> >>> >>> 2) Where should be this functionality, it is possible to filter out zero >>> values either in dpdk side or telemetry client side. >>> Just for this one I think both options are OK, but if there is a >>> possibility to have multiple and complex filtering, I think that should >>> go to the client side since this is not really task of the dpdk library. >> >> Agree. >> This patch just target who using telemetry.py directly, it's valuable in this scenario. >> If clients supports filtering, they could use original way (don't add options). >> > > OK, I don't have strong option, if there is no objection we can have > this functionality in dpdk side. > >> Thanks. >> >>> >>> >>>> Signed-off-by: Chengwen Feng >>>> --- ...