From: Thomas Monjalon <thomas@monjalon.net>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org, ophirmu@mellanox.com, qi.z.zhang@intel.com,
ferruh.yigit@intel.com, ktraynor@redhat.com
Subject: Re: [dpdk-dev] [PATCH v5 5/5] eal: simplify parameters of hotplug functions
Date: Thu, 04 Oct 2018 13:46:54 +0200 [thread overview]
Message-ID: <3504838.42QrpyPWfC@xps> (raw)
In-Reply-To: <20181004094437.yx4tfebyxbsfp6ry@bidouze.vm.6wind.com>
04/10/2018 11:44, Gaëtan Rivet:
> On Thu, Oct 04, 2018 at 01:10:46AM +0200, Thomas Monjalon wrote:
> > --- a/lib/librte_eal/common/eal_common_dev.c
> > +++ b/lib/librte_eal/common/eal_common_dev.c
> > @@ -129,46 +129,61 @@ int rte_eal_dev_detach(struct rte_device *dev)
> >
> > int
> > rte_eal_hotplug_add(const char *busname, const char *devname,
> > - const char *devargs)
> > + const char *drvargs)
> > {
> > - struct rte_bus *bus;
> > - struct rte_device *dev;
> > - struct rte_devargs *da;
> > int ret;
> > + char *devargs = NULL;
> > + int size, length = -1;
> >
> > - bus = rte_bus_find_by_name(busname);
> > - if (bus == NULL) {
> > - RTE_LOG(ERR, EAL, "Cannot find bus (%s)\n", busname);
> > - return -ENOENT;
> > - }
> > + do { /* 2 iterations: first is to know string length */
> > + size = length + 1;
> > + length = snprintf(devargs, size, "%s:%s,%s", busname, devname, drvargs);
> > + if (length >= size)
> > + devargs = malloc(length + 1);
> > + if (devargs == NULL)
> > + return -ENOMEM;
> > + } while (size == 0);
>
> I don't see a good reason for writing it this way.
> You use an additional state (size) and complicate something that is
> pretty straightforward. To make sure no error was written here, I had to
> do step-by-step careful reading, this should not be required by clean
> code.
>
> You should remove this loop, which then allow removing size, and forces using
> simple code-flow.
The only reason for this loop is to avoid duplicating the snprintf format
in two calls.
It could be replaced by this:
length = snprintf(devargs, 0, "%s:%s,%s", busname, devname, drvargs);
if (length < 0)
return -EINVAL;
devargs = malloc(length + 1);
if (devargs == NULL)
return -ENOMEM;
snprintf(devargs, length + 1, "%s:%s,%s", busname, devname, drvargs);
Any preference?
next prev parent reply other threads:[~2018-10-04 11:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 22:27 [dpdk-dev] [RFC] " Thomas Monjalon
2018-09-26 21:47 ` [dpdk-dev] [PATCH v2 0/4] eal: simplify devargs and " Thomas Monjalon
2018-09-26 21:47 ` [dpdk-dev] [PATCH v2 1/4] devargs: remove deprecated functions Thomas Monjalon
2018-09-26 21:47 ` [dpdk-dev] [PATCH v2 2/4] devargs: simplify parameters of removal function Thomas Monjalon
2018-09-27 8:24 ` Ophir Munk
2018-09-27 21:31 ` Thomas Monjalon
2018-09-26 21:47 ` [dpdk-dev] [PATCH v2 3/4] eal: remove experimental flag of hotplug functions Thomas Monjalon
2018-09-26 21:47 ` [dpdk-dev] [PATCH v2 4/4] eal: simplify parameters " Thomas Monjalon
2018-09-28 16:21 ` [dpdk-dev] [PATCH v3 0/4] eal: simplify devargs and " Thomas Monjalon
2018-09-28 16:21 ` [dpdk-dev] [PATCH v3 1/4] devargs: remove deprecated functions Thomas Monjalon
2018-10-01 11:24 ` Andrew Rybchenko
2018-10-01 17:10 ` Thomas Monjalon
2018-09-28 16:21 ` [dpdk-dev] [PATCH v3 2/4] devargs: simplify parameters of removal function Thomas Monjalon
2018-10-01 11:25 ` Andrew Rybchenko
2018-10-01 19:47 ` Thomas Monjalon
2018-09-28 16:21 ` [dpdk-dev] [PATCH v3 3/4] eal: remove experimental flag of hotplug functions Thomas Monjalon
2018-10-01 11:26 ` Andrew Rybchenko
2018-10-01 19:54 ` Thomas Monjalon
2018-10-02 10:28 ` Ferruh Yigit
2018-10-03 8:42 ` Thomas Monjalon
2018-09-28 16:21 ` [dpdk-dev] [PATCH v3 4/4] eal: simplify parameters " Thomas Monjalon
2018-10-01 11:26 ` Andrew Rybchenko
2018-10-01 20:03 ` Thomas Monjalon
2018-10-01 20:52 ` [dpdk-dev] [PATCH v4 0/4] eal: simplify devargs and " Thomas Monjalon
2018-10-01 20:52 ` [dpdk-dev] [PATCH v4 1/4] devargs: remove deprecated functions Thomas Monjalon
2018-10-01 20:52 ` [dpdk-dev] [PATCH v4 2/4] devargs: simplify parameters of removal function Thomas Monjalon
2018-10-01 20:52 ` [dpdk-dev] [PATCH v4 3/4] eal: remove experimental flag of hotplug functions Thomas Monjalon
2018-10-01 20:52 ` [dpdk-dev] [PATCH v4 4/4] eal: simplify parameters " Thomas Monjalon
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 0/5] eal: simplify devargs and " Thomas Monjalon
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 1/5] devargs: remove deprecated functions Thomas Monjalon
2018-10-04 9:19 ` Gaëtan Rivet
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 2/5] devargs: simplify parameters of removal function Thomas Monjalon
2018-10-04 9:21 ` Gaëtan Rivet
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 3/5] eal: add bus pointer in device structure Thomas Monjalon
2018-10-04 9:31 ` Gaëtan Rivet
2018-10-04 9:48 ` Thomas Monjalon
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 4/5] eal: remove experimental flag of hotplug functions Thomas Monjalon
2018-10-04 9:33 ` Gaëtan Rivet
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 5/5] eal: simplify parameters " Thomas Monjalon
2018-10-04 9:44 ` Gaëtan Rivet
2018-10-04 11:46 ` Thomas Monjalon [this message]
2018-10-04 11:51 ` Gaëtan Rivet
2018-10-07 9:32 ` [dpdk-dev] [PATCH v6 0/5] eal: simplify devargs and " Thomas Monjalon
2018-10-07 9:32 ` [dpdk-dev] [PATCH v6 1/5] devargs: remove deprecated functions Thomas Monjalon
2018-10-07 9:32 ` [dpdk-dev] [PATCH v6 2/5] devargs: simplify parameters of removal function Thomas Monjalon
2018-10-07 9:32 ` [dpdk-dev] [PATCH v6 3/5] eal: add bus pointer in device structure Thomas Monjalon
2018-10-07 9:32 ` [dpdk-dev] [PATCH v6 4/5] eal: remove experimental flag of hotplug functions Thomas Monjalon
2018-10-07 9:32 ` [dpdk-dev] [PATCH v6 5/5] eal: simplify parameters " Thomas Monjalon
2018-10-08 21:45 ` [dpdk-dev] [PATCH v6 0/5] eal: simplify devargs and " Stephen Hemminger
2018-10-11 12:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3504838.42QrpyPWfC@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=ktraynor@redhat.com \
--cc=ophirmu@mellanox.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).