From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id CE0D6326B for ; Tue, 4 Apr 2017 14:25:55 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id t20so8137199wra.1 for ; Tue, 04 Apr 2017 05:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:user-agent:mime-version :content-transfer-encoding; bh=mYI8AlSSM2CleTbAxrZkgyBGfKkt64s16yYjiFlcfx8=; b=xo6LIvgPl1/gV0AJ12gzrsDTCD7BdzIDPDsRL/iK+C01OEKI6vvyKRYXdwULXBFZWd 3cABwe+8GyuMnOccV4aeDJSToddehN3TFoaod9WET/vazdkjhR5iCkXahGipZFbAdvt2 EkpNgCJHlNeaAJ8YLELjZY6BkiJKf2k3LlRVzsWoVPyp8g+Y9/D291TPtaHfHpSIRy7F pdZl1U8hvJKMpjarPHfBLIppX8M4kOScQA+65FrapLUP0bSAdMLZvCpzXTlYdHEGZ/tI D+F+AdxUwtTS9d6E0RZFzEkNPWc2kHiOshIa+kkA5NYGj/sa7PSM834sy0T/iWr12Mj8 I+QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=mYI8AlSSM2CleTbAxrZkgyBGfKkt64s16yYjiFlcfx8=; b=NH9l4juWs0KpT6DSxlSv/3JBc/qbpvbAC2n9NhJrsUOiJqf49jkyEXeVJAlISObs+T tPgVFuDAqBrYg3REp74V2+stRgxC+3IAvk7Cprvuwz8eAD2dUsNa0b/0WnYsIBQgbM2N 27MoVqm+9Ih/N/ApWPNgVz3a/fd4D+UCbbcWgk/GyjCmHImcdStHwMt+hCBxpPQGDCGQ ZhWdFsKN4Y6ugscb/O3wvDjcCi1aA7E75/0Oc1JvTj2qYlEaOEE6uLN5fq5OgQEgP6nQ SpEp0yCe5dVaP9QyCXw4+zaVoh5tmkPSIha38vy3JTLS1NJ1TsnLy4Uxb/P/r8uX+Lhz 4qxg== X-Gm-Message-State: AFeK/H08IkEy+lksVzoieiNxwUIj/PkXNZPv6AmZ1gMOYEbSyS7Kwck/ pw1qLylYen20vOe2x+w= X-Received: by 10.28.212.67 with SMTP id l64mr4382065wmg.76.1491308755243; Tue, 04 Apr 2017 05:25:55 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q4sm18171600wme.17.2017.04.04.05.25.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 05:25:54 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org Date: Tue, 04 Apr 2017 14:25:53 +0200 Message-ID: <3506601.nCfr7NKSpQ@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: [dpdk-dev] reminder: each patch must compile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 12:25:56 -0000 Let's remind the obvious: a patch must never break the compilation of any area of code It happens to have some break with some kernels or architectures, but it should be an exception and fixed quickly when it is discovered. I am seeing more and more patches which cannot be applied because of obvious compilation issues. It makes loosing time to everyone. If you are not sure how to test the compilation, devtools/test-build.sh is the recommended tool. It can be configured in ~/.config/dpdk/devel.config to adapt the options to your environment. Example for x86 compilation: if echo $DPDK_TARGET | grep -q '^i686' ; then export DPDK_DEP_ARCHIVE=y export DPDK_DEP_ZLIB=y export DPDK_DEP_PCAP=y export DPDK_DEP_SSL=y export DPDK_DEP_MOFED=y export DPDK_DEP_CFLAGS="-I$mlxdep/include" export DPDK_DEP_LDFLAGS="-L$mlxdep/lib32" export LIBSSO_SNOW3G_PATH=$root/libsso/libsso32-snow3g-0.3.1 export PQOS_INSTALL_PATH=$root/libqos/install/lib32 elif echo $DPDK_TARGET | grep -q '^x86_64' ; then export DPDK_DEP_ARCHIVE=y export DPDK_DEP_ZLIB=y export DPDK_DEP_PCAP=y export DPDK_DEP_SSL=y export DPDK_DEP_MOFED=y export DPDK_DEP_NUMA=y export DPDK_DEP_SZE=y export DPDK_DEP_ISAL_CRYPTO=y export DPDK_DEP_CFLAGS="-I$mlxdep/include -I$szedep/include" export DPDK_DEP_LDFLAGS="-L$mlxdep/lib -L$szedep/lib64 -rpath=$szedep/lib64" export AESNI_MULTI_BUFFER_LIB_PATH=$root/aesni/intel-ipsec-mb export LIBSSO_SNOW3G_PATH=$root/libsso/libsso-snow3g-0.3.1 export LIBSSO_KASUMI_PATH=$root/libsso/libsso-kasumi-0.3.1 export LIBSSO_ZUC_PATH=$root/libsso/libsso-zuc-0.1.1 export PQOS_INSTALL_PATH=$root/libqos/install/lib fi export DPDK_BUILD_TEST_CONFIGS='x86_64-native-linuxapp-clang+shared+next+debug i686-native-linuxapp-gcc+default' You are also welcome to add some automatic checks in the distributed CI, which will be shown in patchwork. Thanks for your attention