From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AC2FA09E0; Sat, 14 Nov 2020 09:47:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B1F17C88E; Sat, 14 Nov 2020 09:47:38 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 8BD06C88A; Sat, 14 Nov 2020 09:47:35 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 3D7B6D19; Sat, 14 Nov 2020 03:47:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 14 Nov 2020 03:47:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= TJjPSPL49Yi50bDfuM/sQSlscahV5vPBHS8P8sxW7DY=; b=n8kLI2GJXl2u1N8f veJ/+MaWbKlRDnRF/sjc5jVDnn4Kvbz5L/QKheYmxjnxBnTL+EB7NagAX5L2LDI5 DDTSQThAiKdx5dSMA4nIy7QBAmkoGzbJhKvvSEBQX4VppbSNFpPeaxqSIqjhYUlj adRjLhJa+i5B0ZPCobRfxZRchbCjwTUHT6hl2WgtVCZ/o6IuLFuNlcYuPgBZjeUP RUP6pFfvEN5MdcjpB/T7rYD8xyUwJ10oBYoxtSV7/RDUZI+BebgoAXpMHyB4O4oo 7PrTRiYTaepehInMUIznULeZuxEg86ssKCo8OiL+Q3jVPoG2DvEiD5B6T3Qutjv+ 9hvFhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=TJjPSPL49Yi50bDfuM/sQSlscahV5vPBHS8P8sxW7 DY=; b=BXZ7A7eWn+MjGnG0zaPghTUFad7Wh6SV23ExTIg3kp96gDraD1+ZQ2/C2 akOejrE6ERZ+oYxLsPcEpthNax3wqXAkMWHYxp/sD6svhNaqkmURwSwbGNGSyxOr Usa/oy9UpLSv74wQllHEEzPxBJ3WVSExqJO8lzAGXeYa61YzqglmMofdJUGqXv9k 7l68M/CJmzSgt0FwNZ2do/dFUbMteUvoSJFEf4SbwIsRie0lx8r2uFy0KkzhW7oV F4fn2d9I2Rl7Y7Oa9rB2qKCKjmgYQypUKJuKK8TuVYAqNLXL3Tc2JSJ4pp9ev1yz PJQ55TZ9BFv6OQPwUkTgqGrg72Jow== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddviedguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B90863064AA6; Sat, 14 Nov 2020 03:47:30 -0500 (EST) From: Thomas Monjalon To: "yang_y_yi@163.com" Cc: "dev@dpdk.org" , "Ananyev, Konstantin" , "yangyi01@inspur.com" , "Hu, Jiayu" , stable@dpdk.org Date: Sat, 14 Nov 2020 09:47:28 +0100 Message-ID: <3509440.tVtxFh5z0Q@thomas> In-Reply-To: References: <20201104042236.125888-1-yang_y_yi@163.com> <20201105025444.140140-1-yang_y_yi@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] gro: fix an error when packet is IPv6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > For VxLAN packets, GRO will mistakenly reassemble them > > if inner L3 is IPv6, inner L4 is TCP or UDP, and outer L3 > > is IPv4 because the value of IS_IPV4_VXLAN_TCP4/UDP4_PKT > > is true for them. > > > > This fix makes sure IS_IPV4_TCP_PKT, IS_IPV4_UDP_PKT, > > IS_IPV4_VXLAN_TCP4_PKT and IS_IPV4_VXLAN_UDP4_PKT can make > > decision precisely. > > > > Fixes: e2d811063673 ("gro: support VXLAN UDP/IPv4") > > Fixes: 1ca5e6740852 ("gro: support UDP/IPv4") > > Fixes: 9e0b9d2ec0f4 ("gro: support VxLAN GRO") > > Fixes: 0d2cbe59b719 ("lib/gro: support TCP/IPv4") > > Signed-off-by: Yi Yang > Acked-by: Jiayu Hu Added missing Cc: stable@dpdk.org Tried to be more precise in the title: "gro: fix packet type detection with IPv6 tunnel" Applied, thanks