* [PATCH] devtools: fix name check with mbox files
@ 2022-11-29 13:59 David Marchand
2022-11-29 21:33 ` Tyler Retzlaff
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2022-11-29 13:59 UTC (permalink / raw)
To: dev; +Cc: stable, Thomas Monjalon, Bruce Richardson
When passing a patch downloaded as mbox, the mail headers were being
scanned which resulted in mailing list and other unrelated mail
addresses being checked against the contributors list.
Filter them by focusing on the mail body (separated from the headers
with the first empty line).
Fixes: e83d41f0694d ("mailmap: add list of contributors")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index be1cb03ea7..1dee094c7a 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -254,7 +254,7 @@ check_names() { # <patch>
old_IFS=$IFS
IFS='
'
- for contributor in $(sed -rn '1,/^--- / {s/.*: (.*<.*@.*>)/\1/p}' $1); do
+ for contributor in $(sed -rn '/^$/,/^--- / {s/.*: (.*<.*@.*>)/\1/p}' $1); do
! grep -qE "^$contributor($| <)" .mailmap || continue
name=${contributor%% <*}
if grep -q "^$name <" .mailmap; then
--
2.38.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] devtools: fix name check with mbox files
2022-11-29 13:59 [PATCH] devtools: fix name check with mbox files David Marchand
@ 2022-11-29 21:33 ` Tyler Retzlaff
2022-12-08 11:19 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Tyler Retzlaff @ 2022-11-29 21:33 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stable, Thomas Monjalon, Bruce Richardson
On Tue, Nov 29, 2022 at 02:59:00PM +0100, David Marchand wrote:
> When passing a patch downloaded as mbox, the mail headers were being
> scanned which resulted in mailing list and other unrelated mail
> addresses being checked against the contributors list.
>
> Filter them by focusing on the mail body (separated from the headers
> with the first empty line).
>
> Fixes: e83d41f0694d ("mailmap: add list of contributors")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] devtools: fix name check with mbox files
2022-11-29 21:33 ` Tyler Retzlaff
@ 2022-12-08 11:19 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2022-12-08 11:19 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stable, Bruce Richardson, Tyler Retzlaff
29/11/2022 22:33, Tyler Retzlaff:
> On Tue, Nov 29, 2022 at 02:59:00PM +0100, David Marchand wrote:
> > When passing a patch downloaded as mbox, the mail headers were being
> > scanned which resulted in mailing list and other unrelated mail
> > addresses being checked against the contributors list.
> >
> > Filter them by focusing on the mail body (separated from the headers
> > with the first empty line).
> >
> > Fixes: e83d41f0694d ("mailmap: add list of contributors")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-08 11:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-29 13:59 [PATCH] devtools: fix name check with mbox files David Marchand
2022-11-29 21:33 ` Tyler Retzlaff
2022-12-08 11:19 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).