From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48AAEA04FA; Wed, 5 Feb 2020 15:14:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 27BC21C133; Wed, 5 Feb 2020 15:14:03 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id D02071C014 for ; Wed, 5 Feb 2020 15:14:01 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id E9FDC71FE; Wed, 5 Feb 2020 09:14:00 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 05 Feb 2020 09:14:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=hJkxQvzfZVOwjhmzaq7UDD/mmYzOxVDq238vnpMlgrQ=; b=i1yRZB5mS8MI RrtUCV+B4cpfbj4eUqgzvXg9rv4B503a+dmiXW8NxhcQTCqobxzG/gC5XaN/27Bs Hf3ANROqrJ4SueVkP9XyqU1epMSY1fJ5n6bFDQKoFqgxlUVnf2z5urDCbGAP+kjW 2QrCbCoJ3/sh3z0eOnbO2KYKHIKXX5U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=hJkxQvzfZVOwjhmzaq7UDD/mmYzOxVDq238vnpMlg rQ=; b=ynNI4LRuyHdqkYgwG7Yrm/N7kq07czn2Ux0Gy7fV2tcSMtL+9D56Acrno Cf1G92J0O6j3MXWXdmWyEFpFxz1sKILwHDRvmopdNQPlah6US1KN9rfOL/tJGykf ovHAvMcchj+eQrhsMIa9WTpXDEXd8u6sdHK9F3EaTTUhUfXdSBmmacQi//NTjMwR 33iS1RuQVEFvs11gcV+NErCoGqysrjIxRE9ra+HP1hBuW1gJg6mJ+tnDb5lKJBQ/ 3mN+LIqE9E94AcE5ENHrQfTN3I6D033BrryHVZf8lZXtvjHOPFgKmX65iayPi+Ve TON2F5ITMGZ6PR1dqDmVyeARYN7lQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrhedugdeitdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepshhouhhrtggvfigrrhgvrdhorhhgpdguphgukhdrohhrghenucfkphepjeej rddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 09FC03060A88; Wed, 5 Feb 2020 09:13:57 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, bruce.richardson@intel.com, kevin.laatz@intel.com, aconole@redhat.com, nhorman@tuxdriver.com, akhil.goyal@nxp.com, anoobj@marvell.com, bluca@debian.org, fiona.trahe@intel.com, ferruh.yigit@intel.com, Arek Kusztal Date: Wed, 05 Feb 2020 15:13:56 +0100 Message-ID: <35132338.XM6RcZxFsP@xps> In-Reply-To: <20200202210835.29791-1-david.marchand@redhat.com> References: <20191220152058.10739-1-david.marchand@redhat.com> <20200202210835.29791-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 0/3] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/02/2020 22:08, David Marchand: > Here is the current state of the ABI checks. > > libabigail has some issues when mixing dump and so files compiled with > clang [1], so for now, all checks are done on dumps only. > libabigail 1.0-rc3 in Xenial reported issues that disappear with the > version 1.2 in Bionic. > > To avoid getting warnings on internal types like [2], the checks now make > use of the public headers part of a dpdk installation (patch 2 and 3 to > prepare for this). > > Some internal rte_hash headers were installed by meson, so patch 1 fixes > this. > > The most important point, abidiff complains on the rc1 cryptodev changes: > - Chacha20-Poly1305 AEAD support, > - ECPM and ECDSA support > > A suppression rule has been put on the internal type rte_cryptodev_ops. > But other changes are an ABI breakage afaiu. I put suppression rules on > them so that we can run the checks, but some action must be taken for > 20.02 if my analysis is confirmed. The suppression rules for Chacha-Poly are removed, and Chacha-Poly commits are reverted while merging this series. > Special thanks to Dodji the libabigail maintainer for helping on this > topic. > > 1: https://sourceware.org/bugzilla/show_bug.cgi?id=25409 > 2: http://inbox.dpdk.org/dev/CAJFAV8yFKoDZROX9Mkyp7pDMvXw3e7mHwxjfrcjD5ZoFB2tZ8w@mail.gmail.com/ Applied, thanks