From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 576351B34A for <dev@dpdk.org>; Tue, 7 Nov 2017 03:43:22 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D94F520CE0; Mon, 6 Nov 2017 21:43:21 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 06 Nov 2017 21:43:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=7Y6PGbVAXqViepPCvBz1yvYHgg rSosxncwOwXHXidBw=; b=dBEFuKT/DeTwup3R4bei5hbKUm2UL0xz+Pp69VnfBb LSzPqjbzpWSS4ACWOQPfNLKIkbTbUS8SdO8KyLjZfP10mw4nY/pEltDu9OrQokpF Uw/XbOZ6Ap1OdUywTBtYAXxTO4Nr627ywWeuRZC1NrqebDZ/0UfVsRw+puQbTT5c Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7Y6PGb VAXqViepPCvBz1yvYHggrSosxncwOwXHXidBw=; b=GoNNj2tfYroK4BHgeaonto WofHhd6WEGsXkiKxQC80+sZPFllJewoVFFxnFmCMIGZ0soRsJGczKllcmqPFBy0a hy/WjoOcBkQ7s43bts5bMEcvWDxlaDlCD9o3+PcddmzdBI68TC5U9PfRVIg8rNJI 3Qplw/Ru/WFDgeK0BcLmsGQjDTx9dLmktxVC56Mm1RF/FW8oPPfYTxq+RgCq6qc8 6Z/RZ7wgXjUJGBrJCBEzexmah58ys1cayL9bZ+oH0AXGa2JAoXXrlst84UUdSmh1 F42HHnZlwZegsvcz0AxqcvlLYQEhJeoEY53nuoYQc291EwEifwsSGWnmTe2w9t3w == X-ME-Sender: <xms:yR0BWg2esP5e_AH36qkXijoY8yBK4neaPKcyL0I7Z2ts-bvdIoALsw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 926767F988; Mon, 6 Nov 2017 21:43:21 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Jianfeng Tan <jianfeng.tan@intel.com> Cc: dev@dpdk.org, jblunck@infradead.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com Date: Tue, 07 Nov 2017 03:43:20 +0100 Message-ID: <35142719.60LRBhkl3K@xps> In-Reply-To: <1509352136-49972-4-git-send-email-jianfeng.tan@intel.com> References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1509352136-49972-1-git-send-email-jianfeng.tan@intel.com> <1509352136-49972-4-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v11 3/4] bus/vdev: move to vdev bus to drivers/bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 07 Nov 2017 02:43:22 -0000 Hi Jianfeng, This patch needs a rebase and some changes as described below. Would you have time to fix it quickly please? 30/10/2017 09:28, Jianfeng Tan: > create mode 100644 lib/librte_eal/common/.eal_common_dev.c.swp [...] > create mode 100644 test/test/autotest_data.pyc > create mode 100644 test/test/autotest_test_funcs.pyc These files should not be in the patch. > --- a/config/common_base > +++ b/config/common_base > @@ -814,3 +814,8 @@ CONFIG_RTE_APP_CRYPTO_PERF=y > # Compile the eventdev application > # > CONFIG_RTE_APP_EVENTDEV=y > + > +# > +# Compile the vdev bus > +# > +CONFIG_RTE_LIBRTE_VDEV_BUS=y Please move this option in a more logical position. > --- a/drivers/crypto/Makefile > +++ b/drivers/crypto/Makefile > @@ -32,6 +32,7 @@ > include $(RTE_SDK)/mk/rte.vars.mk > > core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_cryptodev > +core-libs += librte_bus_vdev The library dependencies have changed. You must add the dependency to LDLIBS in each PMD Makefile. > --- a/lib/librte_eal/linuxapp/eal/Makefile > +++ b/lib/librte_eal/linuxapp/eal/Makefile > -LIBABIVER := 6 > +LIBABIVER := 7 No need to bump again the EAL version in 17.11. > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -101,6 +101,7 @@ _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += -lrte_mempool_ring > _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) += -lrte_ring > _LDLIBS-$(CONFIG_RTE_LIBRTE_PCI) += -lrte_pci > _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) += -lrte_eal > +_LDLIBS-$(CONFIG_RTE_LIBRTE_VDEV_BUS) += -lrte_bus_vdev I suggest to move by one line just before -lrte_eal.