From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f180.google.com (mail-wj0-f180.google.com [209.85.210.180]) by dpdk.org (Postfix) with ESMTP id E53342BB3 for ; Tue, 6 Dec 2016 14:32:38 +0100 (CET) Received: by mail-wj0-f180.google.com with SMTP id xy5so321090598wjc.0 for ; Tue, 06 Dec 2016 05:32:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=s7DyGWKYBh1J51h9GFf4N3NzpwxmgcbZRoWm48hHjRY=; b=OUxsZWu1ttuWHBnvV23fMn8KHPBmTgYT9hE8DZj10soC9CGjzOPiIfuFm0msBYKLVQ yARal1uEmCRXS/t9aQNYj0OXAS7khDTowminMoboFqrNt3zPygEpPf529QCh0ZYgXh6B 6Hfwnq1bT5v4/0mSZHAB37sXnw08B54+3e62JgEERPJdE+cXnoNGi2M1fYKxb+4hxKQG 97e2/QWXc+zK3COQagHlA3nvj+FcxFmtJkNVy1OlV1cH980NiFVQjPIKNq25r9DHVEFd OBdzWm6nNwD5SGic0ZVTUK1rMbMplFAjV0ul/0Dq1kb7/bOIVTV4+AHvo7gghmhOfG4+ VfIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=s7DyGWKYBh1J51h9GFf4N3NzpwxmgcbZRoWm48hHjRY=; b=RjIT3k8uD7IInRT5lV3UCAZCS8B/wy5El68hfgnb1l2/iwJYHzUnseJJ31I0rqsKfo 84IikWObOSvltpvh4YvZjgACB6qxnaliS5FzKDNPj/9PiHsMruIzc12TFSB4eoJ+H7X0 cAN/+ZQQNig96WU1hGUZEVv2e1hYYfViyAaSC9vZ+zcDXR//drKR/xxu+VBAI/RlLUEC 6Gmxzpxmh70qPSXSIioDAqZFbix5UuXJrd71m4brKa7EiM1ayk0TGbN//vv9hiRFLvrs 75uXZ/5wjnP//mCDa7ou/kTx3vBGbEOGMQx58VtwNq0C9kbNQRcHjbV5oO02il4lTC6c PNrg== X-Gm-Message-State: AKaTC00SCFZA5EsADMC0w4aTpXET52j0l7nN01+i78Y38a+u8bs8v8HtWWyq0NxHYtnDCP+H X-Received: by 10.194.80.42 with SMTP id o10mr64501994wjx.65.1481031158326; Tue, 06 Dec 2016 05:32:38 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id c202sm4434451wme.1.2016.12.06.05.32.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Dec 2016 05:32:37 -0800 (PST) From: Thomas Monjalon To: "Yigit, Ferruh" Cc: dev@dpdk.org, "Mcnamara, John" , "De Lara Guarch, Pablo" , "Wu, Jingjing" Date: Tue, 06 Dec 2016 14:32:36 +0100 Message-ID: <3514749.EJIcXcugSX@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20161202013727.2117-1-ferruh.yigit@intel.com> <20161202015845.7121-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: unify help strings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2016 13:32:39 -0000 > > Formatted as: > > cmd fixed_string fixed|string|options : Description > > > > If there is no description, final colon emitted. > > > > Signed-off-by: Ferruh Yigit > > > Good refactoring work to give consistency. It might be worth having a look at the testpmd docs to see if some of the same improvements can be made there as well. That could be a separate patch. > > > .f = cmd_config_rss_hash_key_parsed, > > .data = NULL, > > - .help_str = > > - "port config X rss-hash-key ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|" > > - "ipv4-sctp|ipv4-other|ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|" > > - "ipv6-sctp|ipv6-other|l2-payload|" > > - "ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex " > > - "\n", > > + .help_str = "port config rss-hash-key " > > + "ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|ipv4-other|" > > + "ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|ipv6-other|" > > + "l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex " > > + "", > > /hex/hexa/ fixed > Apart from that: > > Acked-by: John McNamara Applied, thanks