From: Kevin Traynor <ktraynor@redhat.com>
To: Yuanhan Liu <yliu@fridaylinux.org>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dpdk stable <stable@dpdk.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] 16.11.3 (LTS) patches review and test
Date: Mon, 21 Aug 2017 16:25:17 +0100 [thread overview]
Message-ID: <35153d01-fca2-8844-09d0-107199e0a01f@redhat.com> (raw)
In-Reply-To: <20170821092326.GQ9612@yliu-home>
On 08/21/2017 10:23 AM, Yuanhan Liu wrote:
> On Mon, Aug 21, 2017 at 09:23:24AM +0100, Ferruh Yigit wrote:
>>>> I think this one should go in too, as OVS hits this and writes back the
>>>> wrong watermark value to the shared register which can cause problems
>>>> for other ports. I've applied and tested it with DPDK 16.11.
>>>>
>>>> commit 0e61ab56e01655f02bfe4e6249e032e864b0f5dd
>>>> Author: Qi Zhang <qi.z.zhang@intel.com>
>>>> Date: Thu Aug 10 18:48:07 2017 +0800
>>>>
>>>> net/i40e: fix flow control watermark mismatch
>>>>
>>>> Flow control watermark is not read out correctly,
>>>> that may cause an application who not intend to change
>>>> watermark but does change it with a rte_eth_dev_flow_ctrl_set
>>>> call right after rte_eth_dev_flow_ctrl_get.
>>>
>>> Weird, I couldn't find this commit:
>>>
>>> $ git show 0e61ab56e01655f02bfe4e6249e032e864b0f5dd
>>> fatal: bad object 0e61ab56e01655f02bfe4e6249e032e864b0f5dd
>>
>> The commit is in next-net. Not sure how to proceed, any idea?
>
> I see. Thanks. So it's not merged to Thomas tree yet. I normally take
> commits from there. Because I add a tag like following every time I
> pick a commit:
>
> [ upstream commit 5b9b65b14e05c106bb8229c0fe0b347315da7d00 ]
>
oops, I didn't think about that :/
> If I take commits directly from next-* tree, the commit could have
> been changed while merging to Thomas tree, for two reasons:
>
> - the next-* could have done a rebase
> - we don't do "git merge" at Thomas tree
>
>
> However, if that commit is urgent, I think I could make it for 16.11.3
> release with following tag:
>
> [ next-net commit 0e61ab56e01655f02bfe4e6249e032e864b0f5dd ]
>
> If not, I will postone it to 16.11.4.
>
> --yliu
>
Given that it took 9 months for the bug to be found, I think postponing
to DPDK 16.11.4 is better than upsetting the dpdk-stable commit log to
reference multiple repos.
thanks,
Kevin.
prev parent reply other threads:[~2017-08-21 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 10:45 [dpdk-dev] " Yuanhan Liu
2017-08-18 17:29 ` [dpdk-dev] [dpdk-stable] " Kevin Traynor
2017-08-21 3:40 ` Yuanhan Liu
2017-08-21 8:23 ` Ferruh Yigit
2017-08-21 9:23 ` Yuanhan Liu
2017-08-21 15:25 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35153d01-fca2-8844-09d0-107199e0a01f@redhat.com \
--to=ktraynor@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).