From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9342B374 for ; Tue, 27 Jun 2017 10:28:53 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1EBC321695; Tue, 27 Jun 2017 04:28:53 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 27 Jun 2017 04:28:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=z1Auc9j/+TNtAIV JHK01kt8mFWX2vGatyqhY3yE0U+s=; b=HdHG2kGNSRKLfSmXw5Xj7Poli+4JngS rW38wHYuAzgokhZGxsn579F4iKwwVxOPAbFxCvHKb4UxGg693kzqBZ0sl6PK9eI7 YW0zd+NSSAhRDW91vNdr4U8p3G+uROO7xbI5k/BZZKPeulA4v31bFiHQE0tZWEHF XtbrygO+dOLk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=z1Auc9j/+TNtAIVJHK01kt8mFWX2vGatyqhY3yE0U+s=; b=KvrId/HX J593gJYm/7vK6Yss9IY9WzSlcKAhzpzxMAKR7LAslfqRze1RphhuOCX5Rw5vJGX3 OfPTT3CRXxPTC/5YLNqNq74IRyIRBJ0Eb8bNjmlVv1f+JRxQNMNaBrk+cCHSax3n qx7tmGz7JKg8gw5GTdh0+r7WXEKwpog4coY7Af49eFScDy9kQ1xOM9LRUYeqyHAG iW7avqEMsoogP+fhpX03ucVuH8TTsCl5rgxhaEZfjikJOCy24Wg4cvBI5GRgM+4L Jju9E/t9O3p6SHGSzbqbfbXZb6UJ1I0GlZ2I9p7+b/3mY1ABsss8CO368bLZe/iE QwImO25eriQm1g== X-ME-Sender: X-Sasl-enc: 1cxZl22Hp+ALkC4nVTMX8vuZM7Up2IVtGED71BLrQ9zr 1498552132 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C74917E74F; Tue, 27 Jun 2017 04:28:52 -0400 (EDT) From: Thomas Monjalon To: "Wu, Jingjing" Cc: dev@dpdk.org, Vasily Philipov , Adrien Mazarguil , =?ISO-8859-1?Q?N=E9lio?= Laranjeiro Date: Tue, 27 Jun 2017 10:28:51 +0200 Message-ID: <3515786.3Gc2XbLCYg@xps> In-Reply-To: <9BB6961774997848B5B42BEC655768F810DAC7A8@SHSMSX103.ccr.corp.intel.com> References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com> <9BB6961774997848B5B42BEC655768F810DAC7A8@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 08:28:53 -0000 22/06/2017 03:13, Wu, Jingjing: > From: Vasily Philipov [mailto:vasilyf@mellanox.com] > > From: Wu, Jingjing [mailto:jingjing.wu@intel.com] > > > > > > > +/* > > > > * Avoids to check link status when starting/stopping a port. > > > > */ > > > > uint8_t no_link_check = 0; /* check by default */ @@ -1422,6 > > > > +1427,15 @@ static void eth_event_callback(uint8_t port_id, > > > > if (port->need_reconfig > 0) { > > > > port->need_reconfig = 0; > > > > > > > > + if (isolated_mode) { > > > > + int ret = port_flow_isolate(pi, 1); > > > > + if (ret) { > > > > + printf("Failed to apply isolated" > > > > + " mode on port %d\n", pi); > > > > + return -1; > > > > + } > > > > + } > > > > + > > > Should it block the app startup if isolated-mode setting fails? > > > > if isolated mode cannot be enabled on any port, that port cannot be initialized > > and that causes testpmd to quit, at least it won't go against the user's wishes > > If so, I prefer the isolated_mode to be port's argument but not global one. > How about to add a command to configure the isolate mode? There is already a command to configure isolate mode per-port: http://dpdk.org/patch/25320 http://dpdk.org/doc/guides/testpmd_app_ug/testpmd_funcs.html#flow-syntax I think it does not make sense to replicate this per-port command in command line parameters. All the other parameters are global: http://dpdk.org/doc/guides/testpmd_app_ug/run_app.html#testpmd-command-line-options The idea here is to have a global isolate mode with a general option.