From: Thomas Monjalon <thomas@monjalon.net>
To: jerinj@marvell.com, ndabilpuram@marvell.com
Cc: kirankumark@marvell.com, yanzhirun_163@163.com, dev@dpdk.org,
Huichao Cai <chcchc88@163.com>
Subject: Re: [PATCH v5 1/1] graph: improve node layout
Date: Fri, 15 Nov 2024 15:23:41 +0100 [thread overview]
Message-ID: <3517551.QJadu78ljV@thomas> (raw)
In-Reply-To: <20241115015558.3080-1-chcchc88@163.com>
Is it good to go?
15/11/2024 02:55, Huichao Cai:
> The members "dispatch" and "xstat_off" of the structure "rte_node"
> can be min cache aligned to make room for future expansion and to
> make sure have better performance. Add corresponding comments.
>
> Signed-off-by: Huichao Cai <chcchc88@163.com>
> ---
> doc/guides/rel_notes/release_24_11.rst | 2 ++
> lib/graph/rte_graph_worker_common.h | 10 +++++++---
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst
> index 5063badf39..32800e8cb0 100644
> --- a/doc/guides/rel_notes/release_24_11.rst
> +++ b/doc/guides/rel_notes/release_24_11.rst
> @@ -491,6 +491,8 @@ ABI Changes
> added new structure ``rte_node_xstats`` to ``rte_node_register`` and
> added ``xstat_off`` to ``rte_node``.
>
> +* graph: The members ``dispatch`` and ``xstat_off`` of the structure ``rte_node`` have been
> + marked as RTE_CACHE_LINE_MIN_SIZE bytes aligned.
>
> Known Issues
> ------------
> diff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_worker_common.h
> index a518af2b2a..d3ec88519d 100644
> --- a/lib/graph/rte_graph_worker_common.h
> +++ b/lib/graph/rte_graph_worker_common.h
> @@ -104,16 +104,20 @@ struct __rte_cache_aligned rte_node {
> /** Original process function when pcap is enabled. */
> rte_node_process_t original_process;
>
> + /** Fast schedule area for mcore dispatch model. */
> union {
> - /* Fast schedule area for mcore dispatch model */
> - struct {
> + alignas(RTE_CACHE_LINE_MIN_SIZE) struct {
> unsigned int lcore_id; /**< Node running lcore. */
> uint64_t total_sched_objs; /**< Number of objects scheduled. */
> uint64_t total_sched_fail; /**< Number of scheduled failure. */
> } dispatch;
> };
> +
> + /** Fast path area cache line 1. */
> + alignas(RTE_CACHE_LINE_MIN_SIZE)
> rte_graph_off_t xstat_off; /**< Offset to xstat counters. */
> - /* Fast path area */
> +
> + /** Fast path area cache line 2. */
> __extension__ struct __rte_cache_aligned {
> #define RTE_NODE_CTX_SZ 16
> union {
>
next prev parent reply other threads:[~2024-11-15 14:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 8:04 [PATCH] graph: optimize graph search when scheduling nodes Huichao cai
2024-11-07 9:37 ` [EXTERNAL] " Jerin Jacob
2024-11-08 1:39 ` Huichao Cai
2024-11-08 12:22 ` Jerin Jacob
2024-11-08 13:38 ` David Marchand
2024-11-11 5:38 ` Jerin Jacob
2024-11-12 8:51 ` David Marchand
2024-11-12 9:35 ` Jerin Jacob
2024-11-12 12:57 ` Huichao Cai
2024-11-13 9:22 ` Huichao Cai
2024-11-14 7:09 ` Jerin Jacob
2024-11-11 4:03 ` [PATCH v2] graph: mcore: optimize graph search Huichao Cai
2024-11-11 5:46 ` [EXTERNAL] " Jerin Jacob
2024-11-13 9:19 ` Huichao Cai
2024-11-13 7:35 ` [PATCH v3 1/2] " Huichao Cai
2024-11-13 7:35 ` [PATCH v3 2/2] graph: add alignment to the member of rte_node Huichao Cai
2024-11-14 7:14 ` [EXTERNAL] " Jerin Jacob
2024-11-14 8:45 ` [PATCH v4 1/2] graph: mcore: optimize graph search Huichao Cai
2024-11-14 8:45 ` [PATCH v4 2/2] graph: add alignment to the member of rte_node Huichao Cai
2024-11-14 10:05 ` [EXTERNAL] " Jerin Jacob
2024-11-14 12:06 ` Huichao Cai
2024-11-14 13:04 ` Jerin Jacob
2024-11-15 1:55 ` [PATCH v5 1/1] graph: improve node layout Huichao Cai
2024-11-15 14:23 ` Thomas Monjalon [this message]
2024-11-15 15:57 ` [EXTERNAL] " Jerin Jacob
2024-11-19 10:31 ` Thomas Monjalon
2024-12-13 2:21 ` [PATCH v5] graph: mcore: optimize graph search Huichao Cai
2024-12-13 14:36 ` David Marchand
2024-12-16 1:43 ` [PATCH v6] " Huichao Cai
2024-12-16 14:49 ` David Marchand
2024-12-17 9:04 ` David Marchand
2024-12-20 2:05 ` Huichao Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3517551.QJadu78ljV@thomas \
--to=thomas@monjalon.net \
--cc=chcchc88@163.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=yanzhirun_163@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).