From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBA4645D13; Fri, 15 Nov 2024 15:23:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BA2C42FF3; Fri, 15 Nov 2024 15:23:47 +0100 (CET) Received: from fhigh-b4-smtp.messagingengine.com (fhigh-b4-smtp.messagingengine.com [202.12.124.155]) by mails.dpdk.org (Postfix) with ESMTP id 909C642FE5 for ; Fri, 15 Nov 2024 15:23:45 +0100 (CET) Received: from phl-compute-12.internal (phl-compute-12.phl.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id A3C2C2540086; Fri, 15 Nov 2024 09:23:44 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Fri, 15 Nov 2024 09:23:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1731680624; x=1731767024; bh=7A/0tb/3X1ltbK7HaJCkB6KhbFYIi1udjnABXVUWRp8=; b= LCLfmqwX90jDou/MJtUcx3caEETOti9JjruA91G0Po66HjORMXD1VnM4Cntx2Iea SY3JcfQ0HbSODkGGvo5mLGfLWwk6bGRIFpC4yX2GM0MdYxfJoWGCjEaDyvPX62R2 cyosISX5ra9yXxEh790lLjk1jsGM9l+62/FapNUfTmd/OEul4ODj2x0oXXJ4P87S 2dsl9PDlihSXkA/Cj8uSTAvUlf2ahH52or3fUz47CULm2nto84aTkpoqAdX7R3jL 9AjX+XxtQhxZdhaBpyw649HQgtLdthi92xhS/dpQM7/WYZNDNAG78eiEs7kJ2Nag pNOc8V+7lLDDzOmnO5RYIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731680624; x= 1731767024; bh=7A/0tb/3X1ltbK7HaJCkB6KhbFYIi1udjnABXVUWRp8=; b=D lIx9/c92GhpsANLRQdiWG9zHFQ8Jt9/Kkj/dyLYLYouI5SKr8DZpSHu7DMXQ/RZk hOM9r3Fw73Uf+DzwlyJOhckodNn4ueHsZXdPeN1FDxuBTmBHfj57avxhUJVCqFWU 6ee+hLE5K6o3Ts70DocNyfqZLT5+LbDXuBJGdX7uIQgVLXJKHn19ZSXb+eM+R13q kQmV4DxcmpXPaiOGTmlxsf9KhfCT9N0rPuxoYOg/9R1c9+4gLYyuSkbdKJK5xp5D A5seMLNzws7Es/PlR4LjFkQCLX72itJJR0+BRtOZVVwlaMXH9vdMln6kw7mu0ypJ SQdpMmqJTqnHdrrW2NrjQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrvdeggdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhephffvvefuff fkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhho nhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpe ejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeekgfdvuefgfeekjeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrsh esmhhonhhjrghlohhnrdhnvghtpdhnsggprhgtphhtthhopeeipdhmohguvgepshhmthhp ohhuthdprhgtphhtthhopehjvghrihhnjhesmhgrrhhvvghllhdrtghomhdprhgtphhtth hopehnuggrsghilhhpuhhrrghmsehmrghrvhgvlhhlrdgtohhmpdhrtghpthhtohepkhhi rhgrnhhkuhhmrghrkhesmhgrrhhvvghllhdrtghomhdprhgtphhtthhopeihrghniihhih hruhhnpgduieefseduieefrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhg pdhrtghpthhtoheptghhtggthhgtkeekseduieefrdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Nov 2024 09:23:42 -0500 (EST) From: Thomas Monjalon To: jerinj@marvell.com, ndabilpuram@marvell.com Cc: kirankumark@marvell.com, yanzhirun_163@163.com, dev@dpdk.org, Huichao Cai Subject: Re: [PATCH v5 1/1] graph: improve node layout Date: Fri, 15 Nov 2024 15:23:41 +0100 Message-ID: <3517551.QJadu78ljV@thomas> In-Reply-To: <20241115015558.3080-1-chcchc88@163.com> References: <20241114084519.5128-2-chcchc88@163.com> <20241115015558.3080-1-chcchc88@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Is it good to go? 15/11/2024 02:55, Huichao Cai: > The members "dispatch" and "xstat_off" of the structure "rte_node" > can be min cache aligned to make room for future expansion and to > make sure have better performance. Add corresponding comments. > > Signed-off-by: Huichao Cai > --- > doc/guides/rel_notes/release_24_11.rst | 2 ++ > lib/graph/rte_graph_worker_common.h | 10 +++++++--- > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst > index 5063badf39..32800e8cb0 100644 > --- a/doc/guides/rel_notes/release_24_11.rst > +++ b/doc/guides/rel_notes/release_24_11.rst > @@ -491,6 +491,8 @@ ABI Changes > added new structure ``rte_node_xstats`` to ``rte_node_register`` and > added ``xstat_off`` to ``rte_node``. > > +* graph: The members ``dispatch`` and ``xstat_off`` of the structure ``rte_node`` have been > + marked as RTE_CACHE_LINE_MIN_SIZE bytes aligned. > > Known Issues > ------------ > diff --git a/lib/graph/rte_graph_worker_common.h b/lib/graph/rte_graph_worker_common.h > index a518af2b2a..d3ec88519d 100644 > --- a/lib/graph/rte_graph_worker_common.h > +++ b/lib/graph/rte_graph_worker_common.h > @@ -104,16 +104,20 @@ struct __rte_cache_aligned rte_node { > /** Original process function when pcap is enabled. */ > rte_node_process_t original_process; > > + /** Fast schedule area for mcore dispatch model. */ > union { > - /* Fast schedule area for mcore dispatch model */ > - struct { > + alignas(RTE_CACHE_LINE_MIN_SIZE) struct { > unsigned int lcore_id; /**< Node running lcore. */ > uint64_t total_sched_objs; /**< Number of objects scheduled. */ > uint64_t total_sched_fail; /**< Number of scheduled failure. */ > } dispatch; > }; > + > + /** Fast path area cache line 1. */ > + alignas(RTE_CACHE_LINE_MIN_SIZE) > rte_graph_off_t xstat_off; /**< Offset to xstat counters. */ > - /* Fast path area */ > + > + /** Fast path area cache line 2. */ > __extension__ struct __rte_cache_aligned { > #define RTE_NODE_CTX_SZ 16 > union { >