From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 34C0434F3 for ; Sat, 15 Sep 2018 23:07:05 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D2C3B1CE0; Sat, 15 Sep 2018 17:07:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 15 Sep 2018 17:07:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=QdpEjPd3z1roH2ccdlbDght45D 4cgTWQsd5wDGpF7qc=; b=NA/UiKwiGTpPZh9ETfVKZPazUMp+u5+mU+VB3NJJlF X31zKyElRzAjJcF8hiFKeTtX5xHkf1i30ghIirEdmJ0X0kqkVsiVwXc2zLCH+3vA QHys1b77TvHQ85MdSfkQXhXCNh992XveVsNARRxeha4MjMbkNs8C3+nuT3ETWt/T w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=QdpEjP d3z1roH2ccdlbDght45D4cgTWQsd5wDGpF7qc=; b=kMX6gm+C0fee7w+OAINKe3 HfHKkml4ifD+jppXSXFdsg/FXH7hJHquha61Ifw+uTyOkvBIBdXYhVhWIq0J7eDA vf/qymfj266wI+SGg0UsRU4JPaKv66wrIesIse33Xbnlw9NvaBennCpskStnPtIH oO15P5K/e/RWZD3IFC+nz44gx8hrOuGM1c+2fcfuWhlVtTPp/fa5DfQVLVMdPpQ3 aGKseVwCJjxuAP/K56ckRCSeuB7uRf9NknJXVr2/tsIuxbehTbIGLIawXukEo7yW Cj4cHgAFLBUgVoiPG3AMRCnh13/6+26OhTEG0VQzfbCeDFVAK0rfBrdjnjUHdtgg == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 1C424E4121; Sat, 15 Sep 2018 17:07:01 -0400 (EDT) From: Thomas Monjalon To: Ilya Maximets Cc: Arnon Warshavsky , dev@dpdk.org, Stephen Hemminger , Andrzej Ostruszka Date: Sat, 15 Sep 2018 23:07:00 +0200 Message-ID: <3518082.x84fBL49uy@xps> In-Reply-To: <20180914150818eucas1p299538375ea77dfc477516918818c3ab8~UTLGIgMNr0598905989eucas1p2k@eucas1p2.samsung.com> References: <6831653.AvvoQPlBBt@xps> <20180914150818eucas1p299538375ea77dfc477516918818c3ab8~UTLGIgMNr0598905989eucas1p2k@eucas1p2.samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: don't use bash extension in checkpatches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Sep 2018 21:07:05 -0000 14/09/2018 17:10, Ilya Maximets: > Hi Thomas. > > Beside your questions, > There is another patch that targeted to fix this issue: > http://patches.dpdk.org/patch/44020/ > And one similar to mine that I missed while sending: > http://patches.dpdk.org/patch/43692/ > > So, I'm not sure which one should be accepted and if I need to > update my version. What do you think? Stephen? Andrzej? Generally speaking, I think it's better to avoid bash extensions and comply with POSIX. That's why I support the proposal of moving the awk script in its own file, removing the need for "read -d".