From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E338B2BD8
 for <dev@dpdk.org>; Sun, 16 Sep 2018 11:14:13 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 797F621D27;
 Sun, 16 Sep 2018 05:14:13 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Sun, 16 Sep 2018 05:14:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=f1Mqrfg2CN5JBvcyG0edaZIkkr
 w9lHrdWEHiVZNZmVg=; b=ADroKc5TIgvawQYf5EcCIgH3Y2EvAJlV/oeYOOC0wR
 7xrkNoOTgTH/KNSx57a7UW29KtdPsyvFI5V7hTzp7gn9heejHMfz791xmmTI3o1c
 AVJT4kQ/OY0All+TztHNuInBXy5H60YLZmVQPbXW9hyjZ4f/eLClmDVF4Z1CjkKV
 Y=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=f1Mqrf
 g2CN5JBvcyG0edaZIkkrw9lHrdWEHiVZNZmVg=; b=IsmD49tSMCI96hLH/05Y8i
 Z+5ZrFwwDX84RKhwPlsuVVhEW199ZTjBmLp1nPsGmC8m32pMHigEgaWn6IzevnWI
 FwGMDjvQkFxES+k6nPfdbcpLdZwcJxUZklToB2JnRN5SIJFj0gokRI0KO7mPYqRa
 zAWV3+GRAxTVzC45PIHwEe+FEHhdvi/eMcrLL+HbHxRe1akGTWyCZIyzxsuu+44C
 pnw3Imb9lYjtHOAWd6ewUgMGyGlxfWYAptB4MxVuwBJyRPkxeomfW7JY1B/RoGE6
 jrSy5qvu+AyuIvq+THy15TtDgCA5M1ZQ7FtLFnmp1yTptXiNkM+FIivQg0ieUI9A
 ==
X-ME-Proxy: <xmx:5B6eW4iUy1kdnYtZhEcwwuL_2VorhCHC9_ocAkGtEQj3Tq49siFqjw>
 <xmx:5B6eW9q5HD2Za5to6-j6FVnMP-pJsQ6FmB8rAGo8Uohcq5m4K_45kg>
 <xmx:5B6eW2djTdnho2DO6qRfKJTNTxAV5tM1g1kgP4vFY5mjiwDj7LIzlw>
 <xmx:5B6eWzJzw9-ilN4DWYarZltNer3aE-fsFtnLpAZDkIi9AaJvdPTB0g>
 <xmx:5B6eW7vD0IXS8QQcjgwqh4fXSK0eBlLbk_R-W2UBB1m5duTyIk5AvA>
 <xmx:5R6eWyqqpTIoeYaTRfR9b_Ire3d9imNF1hhNTYBhpprJ-sMV-qwOMg>
X-ME-Sender: <xms:5B6eW-1e4ohGkTj9jZUndj89cjs6uc4eMhcMHmERbPCNvIDc4NfoPQ>
Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114])
 by mail.messagingengine.com (Postfix) with ESMTPA id D75D6102A0;
 Sun, 16 Sep 2018 05:14:11 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Luca Boccassi <bluca@debian.org>,
 Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Date: Sun, 16 Sep 2018 11:14:10 +0200
Message-ID: <3518182.H5eQSvgRL9@xps>
In-Reply-To: <1535650263.11823.18.camel@debian.org>
References: <20180830170701.21443-1-bruce.richardson@intel.com>
 <1535650263.11823.18.camel@debian.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] compat: fix symbol version support with meson
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Sep 2018 09:14:14 -0000

30/08/2018 19:31, Luca Boccassi:
> On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote:
> > For meson builds, the define to enable the symbol version
> > macros in rte_compat.h was missing. This led to symbols being
> > omitted from shared objects. For example, checking rte_distributor.so
> > with objdump and comparing make and meson built versions:
> > 
> > $ objdump -T make-build/lib/librte_distributor.so | grep _flush
> >  0000000000001b60 g    DF .text	00000000000000a7
> > (DPDK_2.0)   rte_distributor_flush
> >  0000000000003f10 g    DF .text	0000000000000434  DPDK_17.05  
> > rte_distributor_flush
> > $ objdump -T meson-build/lib/librte_distributor.so | grep _flush
> >  0000000000001d50 g    DF .text	00000000000000fb  DPDK_2.0    
> > rte_distributor_flush
> > 
> > Adding in the missing define fixes this.
> > 
> > Fixes: 5b9656b157d3 ("lib: build with meson")
> > 
> > Reported-by: Luca Boccassi <bluca@debian.org>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Tested-by: Luca Boccassi <bluca@debian.org>

Cc stable?