Re: [dpdk-dev] [PATCH v4] doc: guidelines for library statistics

[Thomas Monjalon <thomas.monjalon@6wind.com>]

We need a conclusion here.

It seems the policy proposed by Cristian is the best consensus.
If nobody nack in this thread with a counter-proposal,
it will be adopted on Monday.


2015-06-18 16:38, Morten Brørup:
> The suggested solution with only one single flag per library prevents
> implementing statistics with varying granularity for different purposes.
> E.g. a library could have one set of statistics counters for ordinary
> SNMP purposes, and another set of statistics counters for
> debugging/optimization purposes.

It would be difficult to sort a statistic in a category or another.
By the way, it's often better to add its own stats for debugging/optim.

> Multiple flags per library should be possible. A hierarchy of flags per
> library is probably not required.

> And since the compile time flag
> CONFIG_RTE_<LIBRARY_NAME>[_<STATS_COLLECTION_NAME>]_STATS_COLLECT already
> tells the application if the statistics are present or not, the application
> should simply use this flag to determine if statistics are accessible or not.

Yes