From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com (mail-wg0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 126E3C42A for ; Thu, 18 Jun 2015 17:13:24 +0200 (CEST) Received: by wgfq1 with SMTP id q1so19840366wgf.1 for ; Thu, 18 Jun 2015 08:13:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=hQN6mBBAH+PsWHoSYhXvGeDxgKFTtgEdUig9bL9JtY0=; b=gCp9UdO/Exlev2TT97dPkIPP5cgOYxC+ex+gjgfQSqsxPS2aAqHSRqVSLYAoWvJOPd Ys9BzeDR97JkZaMxZFOvcSd5Adr8UA4oM0D8CfvhRb7FAPXsd6rkhUQewKXn6oicutQQ VWIeN98OqRffpHBtS7T9ZHgtXKyhIERXDGFK3R6nYHp4XObkzbWxgX2RGMFnZ/Mev07c Kq8LuJbI/tWtvxd6nn5Nzei4fKGGkdXC3226O1nlRHry5SU4CeRJ1EP5pZhwrxP+JOc4 ICiLPCjSDpaDGhopt9+QfE8+tGd2QQzM4yOxgvWUKpPBtD2EiRJKZhbaQWxntmh0e+2U 4V1A== X-Gm-Message-State: ALoCoQmm57OgPRnkNKjtHXa1Io/lCxQHVedMbP21t/8Xs93YWZXiu1vzemzZAjZjoqRofMxN9woZ X-Received: by 10.180.88.169 with SMTP id bh9mr67221662wib.6.1434640403891; Thu, 18 Jun 2015 08:13:23 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id bg6sm12660889wjc.13.2015.06.18.08.13.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jun 2015 08:13:23 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org Date: Thu, 18 Jun 2015 17:12:21 +0200 Message-ID: <3520895.7kc6tpDi1L@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC358AF171@smartserver.smartshare.dk> References: <98CBD80474FA8B44BF855DF32C47DC358AF171@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Cc: Morten =?ISO-8859-1?Q?Br=F8rup?= Subject: Re: [dpdk-dev] [PATCH v4] doc: guidelines for library statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 15:13:24 -0000 We need a conclusion here. It seems the policy proposed by Cristian is the best consensus. If nobody nack in this thread with a counter-proposal, it will be adopted on Monday. 2015-06-18 16:38, Morten Br=F8rup: > The suggested solution with only one single flag per library prevents= > implementing statistics with varying granularity for different purpos= es. > E.g. a library could have one set of statistics counters for ordinary= > SNMP purposes, and another set of statistics counters for > debugging/optimization purposes. It would be difficult to sort a statistic in a category or another. By the way, it's often better to add its own stats for debugging/optim.= > Multiple flags per library should be possible. A hierarchy of flags p= er > library is probably not required. > And since the compile time flag > CONFIG_RTE_[_]_STATS_COLLECT alr= eady > tells the application if the statistics are present or not, the appli= cation > should simply use this flag to determine if statistics are accessible= or not. Yes