From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B63A6A0588; Tue, 7 Apr 2020 13:59:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D2F112BD8; Tue, 7 Apr 2020 13:59:06 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 73622F12 for ; Tue, 7 Apr 2020 13:59:05 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 17D3F706; Tue, 7 Apr 2020 07:59:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 07 Apr 2020 07:59:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=0NPPts38cfvY4KOC2lnP9tmrp+fj+ZZl4q7E+B3TcYU=; b=OyRDV0AekVa0 P69n+tjIYPaYve6G6RZb6Fu/fuzCOHsQyGyu+KRhF2WWI1TGyTzRNivP/RYf1hg4 yFeZ4glYnHBslQvUs3BtjN4mES/etDVZrNKvXW3RWVE7MNzeNx8jCnGgOiQcpLQQ PdKiVL3p7KPWOZeVlLtu7hLKRvLDz7U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=0NPPts38cfvY4KOC2lnP9tmrp+fj+ZZl4q7E+B3Tc YU=; b=Yv0M/nlIkVIh7pYgpTf9LbLm+uZqy9hwy2lV5DXjPQZ8TT7Q9lg+XMWKH J2iA1EQt7OC0754r2HdDVQOfYiopFbQRvMCbfYNhF4XxOEoP732r3tg7rX5IndoZ 7zF/eK/jJ6hkxXBIgOXsc43kubDGGbV3nNQ43miXxZgXENbMu4Bxl5loBhzjJo/+ cWtoB+vRlS8UOrLuS2NiAhBymUDHm2/1F52Cxog6bllcc1s8lh8fns2nz4ItslZM J0o1qtxi87Kj9QRi1bDuf2H+PH1ILCjvWB0jh/+WQDvoITNBu6pwWqlq9eBYUtB5 i9GwkSw8dBB0HTx8v4i0Yg6hlZpbw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudehgdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrsh esmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BBCC0306D536; Tue, 7 Apr 2020 07:58:59 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Neil Horman , Kevin Laatz , mdr@ashroe.eu Cc: dev Date: Tue, 07 Apr 2020 13:58:57 +0200 Message-ID: <35252260.WIbDr2VvFA@thomas> In-Reply-To: <20200407113311.GB128325@hmswarspite.think-freely.org> References: <20200406193430.81268-1-nhorman@tuxdriver.com> <20200407113311.GB128325@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] Remove abi_versioning.sh from tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/04/2020 13:33, Neil Horman: > On Tue, Apr 07, 2020 at 09:36:17AM +0200, David Marchand wrote: > > On Mon, Apr 6, 2020 at 9:34 PM Neil Horman wrote: > > > > > > Since we've moved away from our initial abi_versioning.sh script, in > > > > abi_versioning.sh does not exist (idem with the patch title). > > I suppose you meant validate-abi.sh. > > > Crud, you're right, I was convoluting terms, sorry. Shall I repost with a > corrected changelog? Not only the commit log, look below how you did not care about the basic usage of the new tool. > > > favor of check_abi.sh, which uses libabigail, remove the old script from > > > > check-abi.sh > > > > > the tree, and update the docs accordingly [...] > > > --- a/doc/guides/contributing/abi_versioning.rst > > > +++ b/doc/guides/contributing/abi_versioning.rst The maintainer of doc/guides/contributing/abi_*.rst is Ray Kinsella so I add him as Cc. [...] > > > -The syntax of the ``validate-abi.sh`` utility is:: > > > +The syntax of the ``check-abi.sh`` utility is:: > > > > > > - ./devtools/validate-abi.sh > > > + ./devtools/check-abi.sh > > > > The new script is not a direct replacement. > > It won't take git revisions, but build directories where versions of > > dpdk have been compiled. > > > > devtools/test-build.sh and devtools/test-meson-builds.sh illustrate its use. > > https://git.dpdk.org/dpdk/tree/devtools/test-meson-builds.sh#n127 David, I think Neil did not take time to understand what changed in ABI tooling. I really wonder who is the real maintainer of ABI tooling and policy. Neil, Ray, I was expecting a better involvement in this major policy enforcement. This is where we are: - Neil asked first for ABI compatibility - Neil created validate-abi.sh - Ray asked for a strict policy - Kevin worked on a new tooling - David completed the tooling work - David integrated ABI checks in Travis There are many people partly involved. I think we need one person truly involved in ABI questions, someone who feels responsible and will take care of details like the documentation update requested above. Please don't rely on David and myself, we are already very busy with making sure every patches are properly reviewed. We need good help on the ABI topic in general.