From: Thomas Monjalon <thomas@monjalon.net>
To: Aaron Conole <aconole@redhat.com>
Cc: dev@dpdk.org, "Ananyev,
Konstantin" <konstantin.ananyev@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] librte_acl: fix undefined behavior
Date: Fri, 02 Aug 2019 22:02:59 +0200 [thread overview]
Message-ID: <3527395.qQVFXp17zI@xps> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772580168A60A7E@irsmsx105.ger.corp.intel.com>
01/08/2019 10:14, Ananyev, Konstantin:
> >
> > Left-shift of an integer constant is represented as 'int' type, but a left
> > shift of 1 by 31 bits in 'int' is undefined. Use the U suffix to force
> > a representation as unsigned.
> >
> > Caught while running with ubsan under gcc.
> >
> > Fixes: dc276b5780c2 ("acl: new library")
> > Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > Signed-off-by: Aaron Conole <aconole@redhat.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied, thanks
prev parent reply other threads:[~2019-08-02 20:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 21:39 [dpdk-dev] [PATCH] " Aaron Conole
2019-07-31 8:16 ` Ananyev, Konstantin
2019-07-31 13:06 ` Aaron Conole
2019-07-31 15:43 ` [dpdk-dev] [PATCH v2] " Aaron Conole
2019-08-01 8:14 ` Ananyev, Konstantin
2019-08-02 20:02 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3527395.qQVFXp17zI@xps \
--to=thomas@monjalon.net \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).