From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF38743D04; Wed, 20 Mar 2024 15:01:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8601B402B9; Wed, 20 Mar 2024 15:01:18 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id D4D994029F for ; Wed, 20 Mar 2024 15:01:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bjAseC7vvHwH+wEwVLwV6PbiW3hUeGmlQsRaBEHV7QEz3Q5+Sc31PsDDNSHZDfdRSo+1Rj7Uini9Picarmp4to0mb48HrK+1JeMs09AwkEDZI62k7cIN8gWSzmvKpOLE2ZlMlZFXIPLle9kIMzDnojai4chVr6TtuUYxw/SdHlDL8ZflCrUdsUV8f67PPpC/nfxL7fSKH2yZhbBZXpIgZRhDJXmeAA6RMtCTo/t22ZBHZA8WNFh5CgL/tYgXfUkCIK+3YnvOprRHYFStCxgDIqe66MHcE4lsUj7+dzeNkdplIi6C092pEkSwvuKyzVZTwD0cvSdD4jM1GDs49CoODg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZQAcoW3t3O9p3wmMVHQZR81LZb4j0jO1whzia/VJ5ts=; b=Pmp7GpXcXjTLkkQnlWxNX0y1NuGWES2Wg52VG0jUSei+hrswz+ekH+z0P1QLtT4C8xxF91r1DRXwcVXqfx3FubER9vN0+tOkr6KBzvNzMRYhN1daVhOogJNkqn1vGpF+yg6ENSCzX5dGrWVXRVGiAN2on0jA5xsoiH73ok/E5wfBKgvsmZkd7Ij0IPtr6eiO+gy8u5IW6vEtGSjSJ1nYpm9nkAWJ6cdRYDe3pJqjp0KDh/aVb76ierfGXx/msCOnZDy6F07fnazzFH1b6Da2P7tuykBTSx5PZlaGxXjQ1C6b6xHWKhr9B8BdmQVIA/Cwm/tBZ/q5iThC6lQ22YHIGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZQAcoW3t3O9p3wmMVHQZR81LZb4j0jO1whzia/VJ5ts=; b=q0pYWrO6qsLqax7mtCCvnoBRwXNoKW/GJSsp0JixTW51K3Dd/uQ3dH3h1PqBpb1WT+/I7mmh0H49U2UFtMgmN0tn+UT/qPDviHdqhQ8aljkNF0o0oTKxqrk/TDLkLgz+anSUU1WJevFYp+nR8SFptMi1mFQ9jGE+5Axz2rbPoWc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by LV3PR12MB9267.namprd12.prod.outlook.com (2603:10b6:408:211::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.34; Wed, 20 Mar 2024 14:01:13 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7386.031; Wed, 20 Mar 2024 14:01:13 +0000 Message-ID: <3535b9a5-54ac-4086-b42a-78a168ae0a87@amd.com> Date: Wed, 20 Mar 2024 14:01:09 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: dump TCI when asking for VLAN insertion Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: Aman Singh , Yuying Zhang References: <20240318080237.2170473-1-david.marchand@redhat.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240318080237.2170473-1-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0069.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|LV3PR12MB9267:EE_ X-MS-Office365-Filtering-Correlation-Id: af751ab2-9185-4558-c71c-08dc48e63420 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qDCICVpmVjsz3pcJ0ZXvYUEVzMx8qeoEgRgtujJOLSkW79ncBTHzYVNbMLjaoVY7KSmwsak6DBL4LOJRxzcoAV+yGoRx38LtztgfRAYi/cOXG9mOt9qoA4mo8OEZzerG/AfksFD7wj2uILf5WFExhTiXxKJI/je7qc2jUEhj9eL5gsx9ksp5LQP9ANhyEupw8LKj7wldfd07kmKRnl/cd1zLa82qg8/6WouR+stw4wwQzKYO+7eVizMqkvMbU/Q/7qlknY9NfElDCd2o10mH/Bj3rEso4SPSpTEmJ+gz6WfgNkSFqdza9aCpBF6fklDdHK7x21i1AtzyRQZIrpon2nMsPw3URumZA4JipCTrAjHwc3waP+BsnmqUkpR+B7jjf5dCGoRZ+qzYWz3z5ppF2lPj4GXZTefaFDiPXLLO736tSeoA+uBS5dR9tOQTGwriJPN++qQ04gdrbolHTmLGyIfkbgYWS2UDDVxluAhvsmI7YbbBsvCoVEKjsxd/yv7Uv0jd34dvXHEQjCMvxVlUX1NeoSu9nMb81NBO+sGRobcQaHLSSWH4oy8XRSXqaqyEpVoMbhmUZuKuTmdMLWAYPOVHj+pZpLY7ZogbLeiBak9NMx8PEX/Kfzzuql3lRC8aaVIzHn1oZXj2llu/0vHZMACm2oHwld5kccV1UnnQNOc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDhCQ3d1Z2ZKZWgxUG1SMHZ6R0tGUjdaZEQ2aHhYdmdpcURTRGY5OFFHNjRx?= =?utf-8?B?endEbGtEaG83ZkhDZUx5NVZaLzhoSi84K1VlV05WbjM0S3kyS0hXYkZHWTg2?= =?utf-8?B?aWp5YUwxWTExcGFxdDVtN2plWWFKSmx5RkdOTStOOFFEa1BveDlmcTBNaitj?= =?utf-8?B?bmY2KzAwYWdUN0RocUFoeDl0WGs4NWxSV28wWFd0WS9UOE5sbVpXTDVPTTQ3?= =?utf-8?B?OXluMjlIL3dXeHlLemI5Z2hOWTVGMHZneFVxSTNQcElqekZmdjdjYWtYSSt5?= =?utf-8?B?UVBBdjBUNm1NZUZrQlFOVC9Xb2FtbEE5TDJGb0ZuZmRBREpvZUgyR2JnbnpM?= =?utf-8?B?Q2FJTjVsa1dJeGZvQU1wRFU4UHJMVlJlVDYxMEFJMVc5OHA4T081TVJTRHFL?= =?utf-8?B?anVjU2MzcVdFcjVscEJ4VThTK2Q0RGpwREZQcHlJdzZiR255T2ZFQTB6TnZJ?= =?utf-8?B?Y2ZqY0t2YWdvaWtLb2NDZzlNcXg1a1IzZjZhandMbHUrTXJPTXQzbG5tMmJa?= =?utf-8?B?eDF5SXdPM3FOV3FmMDhZS211bXA5T3VjaWFOOGxXS2t4cEp5RmJ4QzZMK00w?= =?utf-8?B?VGdTN0k5bmllcXU5dW1VUnpGK0hjV21KWVFFaGo1VUtYQW1uYWNiTWQ2Qmxy?= =?utf-8?B?M1Y2TmFXNU5tSjkyU3lHcnl6VjRGY0gvYjBVME9lQnEzaEhWK0l1NXd6bmND?= =?utf-8?B?VnFaWWtzQ1dvRHYxVHRYVDBManFyakpJSC93VVZ1Nm9oaDZiT2JKdGtlQVBn?= =?utf-8?B?Z1IyQ3ZqT0psQWRSbUZwQjIzOTVZWWE4OTBlNko4blJFcnBBUnBQWUxTZ0hX?= =?utf-8?B?bGpXL3M0ck9LUDl2bVhQWkpiZ3FzMEdHY0NCWGx6RDh6WnhEQXpac0RTcGF3?= =?utf-8?B?V0Q2K3oxelVsNFFLMEl4MTJDWkNqaWp5Q2s3M2ZVMW51S3F2cGhjMXEvZnlC?= =?utf-8?B?dVdVNVdMMWJWZnFYNnBMdGk1dmNaWTdHUzNpVHFNU1J3WVZtSXRPdmZPaEVW?= =?utf-8?B?cXpiWFoxeW45enpRMmFPUTlEWUUvQWVSSWdCMWM3eElLSDNBODVDMHpzQ3FG?= =?utf-8?B?NnZCTFI4MS9zNTFEWjZndGlVTVZrWkh1dkl1KzNxcHgrYlp5eHBlQ2h0VGYv?= =?utf-8?B?bkRMRHhvbUZRb29KM082REg0UG9rTjJwNG5wdFlpRHBhaTc2aXRIZjVpSEVm?= =?utf-8?B?aVJqV2VWN29ubVNLT2ZHZnhkcWhBMVY5ejRaOGtMWHNxTkY3dC85QXErVEJH?= =?utf-8?B?N29LYm52QVRiZTFpOVNVM3RLVWk0STYzQm9hd2lmQXB6YXRVZzRadStCRnRh?= =?utf-8?B?ZXUrVlJwL0thTHl3L1U2VDRQNytSN1VYWVN0Q0RBNnhxVFRzUnZEaUxBMUVO?= =?utf-8?B?VnFLS05XUC9XK1pEbGZOaTV5M1Y1Mzk5T3U5eU43WkF4M3NvUkxoMURoaDlw?= =?utf-8?B?UVZUVFlndzhOemU1bXhJT21zVGRTdlcyQVdHditvUlFHU0twK3M1czNTelo4?= =?utf-8?B?WFNPR3JjK3Y4Tmx6ME1MakpHR205Q0JGUTJZUWhhOXJvRTNYSXNUbXcvRGtD?= =?utf-8?B?M2VPRnVyQmVHK1hWMWdVcm1DYVZMYzdEbHdza2ErNWZyMzc1cnJ0ZTFZUWc5?= =?utf-8?B?K1FNak03WHlXM3RDbCtjYVdFdXhMeFdmNC9ONDA0Y2RZZGFCS3VHNnhqNVky?= =?utf-8?B?ZStpeStzemp4RnhoWEU1VjY5TE5Bby9lU05nb0dEZG9Ia0wrMzhKejJnUncv?= =?utf-8?B?R3pHNG1pR2QrdncyTXM5WTJjdXhLR2p5c3lmdFdYbnk5ZFJXT3dIZXYwNFF5?= =?utf-8?B?UkhrOU5MazF3ZlFDZEF5blhoMFAraE80OU5oelA0MWdzOVErRWVKT1BXelYv?= =?utf-8?B?bU14RkJNSkRhdm5LOHI2cCtvemxoQldQcVRjYzN3WXRReEhSMG9Gbmt4czJ4?= =?utf-8?B?dVhFb1VScFB4R2l5Z0p6WEVSV0RsTFlEbDFlbnRUWlhwamhmQ3M5VXptQTQ0?= =?utf-8?B?ejZ1Qm1lVThMckJ0RXRUalVOOXFvNGl6QlN1SmZ5dkdHb0IxRWVDMW1hQ1VY?= =?utf-8?B?YWppZ2trcXVqWlZGZkt0clZqb1l2cE9UeTVab05XeTdOV3dqRTk4eTZYV0VJ?= =?utf-8?Q?EMp2oKhw3FiYjEFYHdqD4uSMg?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: af751ab2-9185-4558-c71c-08dc48e63420 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 14:01:13.6722 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q5Ld/2qL66uNWj477o7W6YbcQIhaxQLdLM3Qq7rP8XZos4FIGKwm1spymp1+26Q5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9267 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/18/2024 8:02 AM, David Marchand wrote: > I got some report for users that VLAN insertion was not working as the > only thing they could see in verbose mode was a 0x0800 ethertype even > though the RTE_MBUF_F_TX_VLAN flag was shown. > > Dump the VLAN TCI from mbuf metadata when VLAN insertion is requested. > This should enhance the situation. > > Before: > src=76:4E:EA:3F:78:1D - dst=50:7C:6F:3C:10:5B - pool=mb_pool_1 - > type=0x0800 - length=64 - nb_segs=1 - > sw ptype: L2_ETHER L3_IPV4 L4_UDP - > l2_len=14 - l3_len=20 - l4_len=8 - Send queue=0x0 > ol_flags: RTE_MBUF_F_TX_VLAN RTE_MBUF_F_TX_L4_NO_CKSUM > > After: > src=76:4E:EA:3F:78:1D - dst=50:7C:6F:3C:10:5B - pool=mb_pool_1 - > type=0x0800 - length=64 - nb_segs=1 - VLAN tci=0x2a - > sw ptype: L2_ETHER L3_IPV4 L4_UDP - > l2_len=14 - l3_len=20 - l4_len=8 - Send queue=0x0 > ol_flags: RTE_MBUF_F_TX_VLAN RTE_MBUF_F_TX_L4_NO_CKSUM > > Signed-off-by: David Marchand > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.