From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCC7E41BDD; Sun, 5 Feb 2023 18:34:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A89AC40A89; Sun, 5 Feb 2023 18:34:47 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id BE82C40A7D for ; Sun, 5 Feb 2023 18:34:46 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5AD7F5C0257; Sun, 5 Feb 2023 12:34:44 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 05 Feb 2023 12:34:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675618484; x= 1675704884; bh=D99QGgcOkefqEKKQ4GvlB/cns2iGcbEoybxMHakfleI=; b=G 3msq4mqzUeZ0PXZwOchKHlJO5pWo960S9ke6H4NizkTVO5VcrYXgOAQugEzeOpGM mLPk1CH5pcX5kf7yXtO2rK2s6X5XVFszwgSsOqqk2G3uMIERfRbvTJuuhgdBUZzm 1ractSr+3derMXJ6uyqZQzTA45bw9/T3v5xhV7xb2jRlKjf/E6ha3MJUxs2Coqd+ 2rABJhTrZ3luhqbL5Wrl7M4xEHHIAxMJ4tq09KUGHaj9pht1ttOdW+ZnBgA6Qbye xqiLbCpC1F5Gj01qBjvwkydyclnDCDj/I4jRWR2FnEgFRys0bVoTPn5We3jI5zKb 5GyD2ZgzjCK9atTdLDjXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675618484; x= 1675704884; bh=D99QGgcOkefqEKKQ4GvlB/cns2iGcbEoybxMHakfleI=; b=k Ygd4qHs1Y3D/obIR6+g5xPfw+/lhiExTPIS1O840qINLpj2nctjvmAXgk2lm64oJ PmMVdZiyB1LBWYOJgbtIs3vkL47u3G6sllLWV5pzZ/zFJ6EdHDe1YP5krtZeBEUJ +T+gZxoLUlghozvB+LcreoK3yQxdmbDnBkQ1o4Ddfb7NDekndo9xRJQ9gZX7LBpB gRmODj065DVGFgfE6OYDxki35enSJEj6dObyhywi9a2Vgs/d0DUCIOwNceYWu6cU u7K1G8UK+2hVos05uXM5JDHBwLrYhz+exFH5GSwVhLEegr0SZxrzfZo1fnn+tIuG LczAx53BdwXGlHc+3uRkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeggedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepjeejffffgfffkeefffelgfekleetjeffleeludeghfehleff teehveduffdugfdvnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 Feb 2023 12:34:43 -0500 (EST) From: Thomas Monjalon To: "jiangheng (G)" Cc: "dev@dpdk.org" , ferruh.yigit@amd.com Subject: Re: [[PATCH] ] linux/igb_uio: fix build with Linux 5.18 Date: Sun, 05 Feb 2023 18:34:41 +0100 Message-ID: <3536984.R56niFO833@thomas> In-Reply-To: <8b4953ef939d433f8fe19353e9ed3aa7@huawei.com> References: <8b4953ef939d433f8fe19353e9ed3aa7@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 30/01/2023 08:27, jiangheng (G): > Since commit 7968778914 (PCI: Remove the deprecated "pci-dma-compat.h" API) > in 5.18, pci_set_dma_mask() and pci_set_consistent_dma_mask() no longer exist > switch those api to dma_set_mask_and_coherent. > --- > linux/igb_uio/igb_uio.c | 8 ++++++++ > 1 file changed, 8 insertions(+) The patch from Ferruh looks simpler: https://patches.dpdk.org/project/dpdk/patch/20221216115732.3552650-1-ferruh.yigit@amd.com/ > +#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 18, 0) > err = pci_set_dma_mask(dev, DMA_BIT_MASK(64)); > +#else > + err = dma_set_mask_and_coherent(&dev->dev, DMA_BIT_MASK(64)); > +#endif [...] > +#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 18, 0) > err = pci_set_consistent_dma_mask(dev, DMA_BIT_MASK(64)); > +#else > + err = dma_set_mask_and_coherent(&dev->dev, DMA_BIT_MASK(64)); > +#endif