From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Tomasz Duszynski <tdu@semihalf.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
Ivan Malov <ivan.malov@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH v3] ethdev: return diagnostic when setting MAC address
Date: Tue, 10 Apr 2018 15:19:45 +0200 [thread overview]
Message-ID: <35427873.7xcNz5HcYd@xps> (raw)
In-Reply-To: <43422766-0111-4b93-1eb2-39cd6f48a4a1@intel.com>
06/04/2018 18:03, Ferruh Yigit:
> On 4/6/2018 4:34 PM, Olivier Matz wrote:
> > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a
> > return code is added to notify the caller (librte_ether) if an error
> > occurred in the PMD.
> >
> > The new default MAC address is now copied in dev->data->mac_addrs[0]
> > only if the operation is successful.
> >
> > The patch also updates all the PMDs accordingly.
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
next prev parent reply other threads:[~2018-04-10 13:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 15:11 [dpdk-dev] [PATCH] " Olivier Matz
2018-03-05 10:29 ` Adrien Mazarguil
2018-03-06 9:37 ` Tomasz Duszynski
2018-03-16 15:41 ` Andrew Rybchenko
2018-03-26 18:39 ` Ferruh Yigit
2018-03-28 8:24 ` Olivier Matz
2018-04-03 12:41 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2018-04-03 13:02 ` Andrew Rybchenko
2018-04-03 14:57 ` Adrien Mazarguil
2018-04-03 16:26 ` Olivier Matz
2018-04-03 16:19 ` Ferruh Yigit
2018-04-03 16:25 ` Olivier Matz
2018-04-04 8:19 ` Shreyansh Jain
2018-04-06 15:21 ` [dpdk-dev] [PATCH] " Olivier Matz
2018-04-06 15:34 ` Olivier Matz
2018-04-09 8:57 ` Nélio Laranjeiro
2018-04-06 15:34 ` [dpdk-dev] [PATCH v3] " Olivier Matz
2018-04-06 16:03 ` Ferruh Yigit
2018-04-10 13:19 ` Thomas Monjalon [this message]
2018-04-11 16:32 ` [dpdk-dev] [PATCH v4] " Olivier Matz
2018-04-11 19:30 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35427873.7xcNz5HcYd@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=olivier.matz@6wind.com \
--cc=shreyansh.jain@nxp.com \
--cc=tdu@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).