From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 99AA81B7C7 for ; Tue, 10 Apr 2018 15:19:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 29C1B20D2A; Tue, 10 Apr 2018 09:19:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 10 Apr 2018 09:19:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=+palpD2etUeWv9nCOSFVZOlGIX dCrPHbsnYdTs/5054=; b=jHHQPe99txbkKvl16C6q2fHNsiF5VpPBfpMoNuHiuJ sDdFyQLPH5QRhyrrETZiYr0KYjN2g3/+n4yh1eduyAEfeafdufYXJYYAdi9SFRd4 UArZYDf+Jp6si2n6dFJQSi9dK1QxFtm7Wm2T0s4x+TPtoTrG7Ap9b0VbmE9of0YW Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+palpD 2etUeWv9nCOSFVZOlGIXdCrPHbsnYdTs/5054=; b=KMOgZpzHkiczRgwcQzci7L kI1yY3gXxmFPVr2Elm7fa7FqDyi+ie1gyeIgnucocPn08fMUHVYhHsi3PkHB9Kgd kquQ39Pz+xblyQrTiBaHM6JifgR8w1khZLkCLMbWlG7wXq2bpWrjQ2dErY/Kkamp 5A9IXsHK4U6+6knokiQNzB13i6lTBsA51tScpV9R+kOBQGnr8gBzxdpWE87oW4uV uOc4kuVzvPRmWAxn/IZ11dn9PhJ/TkAiJh4LkxcWV0SeBSYhBJzAdvfOlhYbedf7 xkAjfKlxuIbVB3WZoKG5O1hObGNkKnFzUY1cULh8jZTV4igAonNZ/UPxYcjUlVGQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 09EEEE4488; Tue, 10 Apr 2018 09:19:46 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, Ferruh Yigit , Tomasz Duszynski , Andrew Rybchenko , Adrien Mazarguil , Shreyansh Jain , Ivan Malov Date: Tue, 10 Apr 2018 15:19:45 +0200 Message-ID: <35427873.7xcNz5HcYd@xps> In-Reply-To: <43422766-0111-4b93-1eb2-39cd6f48a4a1@intel.com> References: <20180403124103.13124-1-olivier.matz@6wind.com> <20180406153444.23988-1-olivier.matz@6wind.com> <43422766-0111-4b93-1eb2-39cd6f48a4a1@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ethdev: return diagnostic when setting MAC address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 13:19:48 -0000 06/04/2018 18:03, Ferruh Yigit: > On 4/6/2018 4:34 PM, Olivier Matz wrote: > > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > > return code is added to notify the caller (librte_ether) if an error > > occurred in the PMD. > > > > The new default MAC address is now copied in dev->data->mac_addrs[0] > > only if the operation is successful. > > > > The patch also updates all the PMDs accordingly. > > > > Signed-off-by: Olivier Matz > > Signed-off-by: Ivan Malov > > Acked-by: Andrew Rybchenko > > Acked-by: Adrien Mazarguil > > Acked-by: Shreyansh Jain > > Reviewed-by: Ferruh Yigit Acked-by: Thomas Monjalon