From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 87FE61B587 for ; Thu, 11 Oct 2018 14:00:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 306E821ABB; Thu, 11 Oct 2018 08:00:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 11 Oct 2018 08:00:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Sy9agGvx8WBeeUB7pYGVjTm/vGvap1FFWU3KGsSGypU=; b=nlihp9JG9HaK lWMCiW5bL8FVF6GeaALiWsOs79SbUIIpuIKJAEPzay6ps1A5tRQ54yfnQqHQPFEq 3HjaPwUM783Mb1kBLlwfA3ddNNN0Zxkr4UGAKgJslvljQJewcQpityn1KDs3UHpm Xj9fh+PEo1TgVwfg9uowE6D2/VjfpBE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Sy9agGvx8WBeeUB7pYGVjTm/vGvap1FFWU3KGsSGy pU=; b=K6wY4ZvaJ4zpnoD5vq/DSc1ZTnfPWG9QJLv+iavMwsx5d6keSZ6tJ2UkT iJeWkhJfajZilxwOgkFpYNPrSXhGsFjbfeK8TonVuUfOdy8n8oGVJ76UFVGVql2P 5os3xMmDFFcoK4xk+NT7uPfJhkhtYBP8dzeUrL7rG3ZeA3p4ZV/dPdDZTPkTH/8x g55I4e9ci/UxywH6EiMM8C97vzWBLfABXs6CIVwAdaeBEMFEtYfqgJRCvukNmXcg CMx9BGtTGBVkEyhyecxf54uN5MwQTKd3fsdF9ck2fPthKvx/UiVdDCh6PS8lEQoM eBwaiOkj95aqwuB80HqzKYCI5wYig== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B3C2102ED; Thu, 11 Oct 2018 07:59:58 -0400 (EDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, Ferruh Yigit Date: Thu, 11 Oct 2018 13:59:58 +0200 Message-ID: <3543645.ZMkEL9mWDR@xps> In-Reply-To: <20181010201919.GA19761@hmswarspite.think-freely.org> References: <20181010142928.11274-1-nhorman@tuxdriver.com> <1766289.2YrT9N83Jn@xps> <20181010201919.GA19761@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] check-experimental-syms.sh: prevent symbol matches on substrings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 12:00:00 -0000 10/10/2018 22:19, Neil Horman: > On Wed, Oct 10, 2018 at 04:43:14PM +0200, Thomas Monjalon wrote: > > 10/10/2018 16:29, Neil Horman: > > > Thomas attempted to submit this: > > > https://patches.dpdk.org/patch/46311/ > > > > > > The other day, because the other patches being submitted with it were > > > breaking on a false positive from the check-experimental-syms check. > > > > > > The problem was that the experimental symbol check script matched on the > > > regexs "\.text.*$SYM" and "\.text\.experimental.*$SYM" which allows for > > > substring matches, and librte_ethdev recently introduced symbols that > > > are leading substrings of one another (e.g. symbol foo is a substring of > > > symbol foobar), and so we would match on symbols when we shouldn't > > > > > > Instead of dropping the check, fix this properly by matching > > > additionally on the end of line so that symbols are an exact match. > > > > > > Confirmed to build properly on Thomas' submitted patch set with the > > > experimental check patch reverted (so that the checking actually > > > happens) > > > > That's great Neil! > > I would like to push it now. > > May I suggest to remove the details of how I (baldly) reported it? > > > > I suggest this text: > > " > > The experimental symbol check script matched on the regexes > > "\.text.*$SYM" and "\.text\.experimental.*$SYM" which allows for > > substring matches. > > If a symbol is leading substring of another one (e.g. symbol foo > > is a substring of symbol foobar), it would match on symbols > > when it shouldn't. > > > > It is fixed by matching additionally on the end of line > > so that symbols are an exact match. > > " > Sure, if you want to make that change on commit, I'm ok with it. Applied, thanks