From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45B1BA00C2; Fri, 24 Apr 2020 19:17:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 27EF21D41D; Fri, 24 Apr 2020 19:17:34 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id E962A1C435 for ; Fri, 24 Apr 2020 19:17:32 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 41FD95C0641; Fri, 24 Apr 2020 13:17:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 24 Apr 2020 13:17:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= IiKwC6eQ1D9dPenIx6votT27WrLqvk2MlymC60tyjiA=; b=mtqpjPgqNdZey3Iq dU5qQeTyPI9zYtXBB3+UlMVQaapqMTRH5pE0zcSgW8nJE5szpjBer/gK9K7r5Szc 7fv1h1hR0cJZd+t8Zyr+Rncmb6Cs7XQtvbPQI3ZLinjYtvcSiV9bxVrUbTPQrf3M qP6FkwbgsYtR2cvleHj7cJYi9Ptw4ecCmPEAzZitNnMxQmb7WkrzfL3caBk5LLv4 jkK+NQyDZBqtf8H9tFnpaTYLy9WFXhWrHWH46OycyzUXUB8ZseTT2vghwo7JqUqE 7zoScvSah/DHY+WD98dwZ7PyngQ0wd+Fl1vAizR8q0j4tSQ+l7FwX9TkHnNCGjho BdeVPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=IiKwC6eQ1D9dPenIx6votT27WrLqvk2MlymC60tyj iA=; b=jdhY/U5OrKCOCI10PIMazTjFDpzM7HXwBMvWZxzeX3FmVBFO/RmCRMQDh Nxd4OELAztMxPRTSei6G+ODHIFgV7I5OalMom38O4StEgZGi5OYfBAFBjSk3OzII T7SqBVyhVbuT9U+8d0xhgShKbwFPkxxwrNdoWwN0XMtIUV5ftaYmfyUlYlIZxztr NspC9RagC2thj3dPf7z2HJ0ASn/B2syQHKGren53vf6aMbjHb0O+fQ1b7slRt5DC haDD2dEU3gDI6ZRnkYea0AbEAT4gJ7+50/VC3AhzgqxI3JNpkY1j7OWeWaY5TzKL Is23rM7gBfi3F2DXYXjbzYbkpHzHg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrhedugddutdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 589623065D90; Fri, 24 Apr 2020 13:17:31 -0400 (EDT) From: Thomas Monjalon To: Yangchao Zhou , "Medvedkin, Vladimir" Cc: dev@dpdk.org, Bruce Richardson Date: Fri, 24 Apr 2020 19:17:30 +0200 Message-ID: <3545193.07ICAnoMbH@thomas> In-Reply-To: <7c295dc2-1563-4c46-e592-037368c864b8@intel.com> References: <20200417150912.6911-1-zhouyates@gmail.com> <20200420024850.21481-1-zhouyates@gmail.com> <7c295dc2-1563-4c46-e592-037368c864b8@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] lpm: skip table entries update if rules found X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/04/2020 17:44, Medvedkin, Vladimir: > Hi Yangchao, > > Thanks for the patch. > This might be useful for control plane implementations that don't track > inserted routes. > I have just a one nit inlined below. Also, could you do the same for lpm6? > > P.S. Please have a look at rte_fib library, there are more optimizations > compared to lpm library. > > Apart from that, > Acked-by: Vladimir Medvedkin [...] > > /* If rule already exists update its next_hop and return. */ Reduced length of above comment, > > if (lpm->rules_tbl[rule_index].ip == ip_masked) { > > + > > + if (lpm->rules_tbl[rule_index].next_hop == next_hop) > > > Line over 80 characters, please split it by two. and split above line. Applied with requested changes, thanks.