* [dpdk-dev] [PATCH] Use proper mac type for 82576 VF
@ 2014-05-06 11:28 Konstantin Ananyev
2014-05-22 15:32 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Konstantin Ananyev @ 2014-05-06 11:28 UTC (permalink / raw)
To: dev, dev
e1000_vfadapt type corresponds to 82576 VF devices,
check e1000_set_mac_type() for more details.
---
lib/librte_pmd_e1000/igb_rxtx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c
index 6b454a5..7fe1780 100644
--- a/lib/librte_pmd_e1000/igb_rxtx.c
+++ b/lib/librte_pmd_e1000/igb_rxtx.c
@@ -2154,7 +2154,7 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev)
rxdctl &= 0xFFF00000;
rxdctl |= (rxq->pthresh & 0x1F);
rxdctl |= ((rxq->hthresh & 0x1F) << 8);
- if (hw->mac.type == e1000_82576) {
+ if (hw->mac.type == e1000_vfadapt) {
/*
* Workaround of 82576 VF Erratum
* force set WTHRESH to 1
--
1.7.7.6
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] Use proper mac type for 82576 VF
2014-05-06 11:28 [dpdk-dev] [PATCH] Use proper mac type for 82576 VF Konstantin Ananyev
@ 2014-05-22 15:32 ` Thomas Monjalon
2014-05-22 15:39 ` Ananyev, Konstantin
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2014-05-22 15:32 UTC (permalink / raw)
To: Konstantin Ananyev; +Cc: dev
Hi Konstantin,
2014-05-06 12:28, Konstantin Ananyev:
> e1000_vfadapt type corresponds to 82576 VF devices,
> check e1000_set_mac_type() for more details.
You forgot "Signed-off-by:" line.
Please resend.
--
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] Use proper mac type for 82576 VF
2014-05-22 15:32 ` Thomas Monjalon
@ 2014-05-22 15:39 ` Ananyev, Konstantin
2014-05-22 15:44 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Ananyev, Konstantin @ 2014-05-22 15:39 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
Hi Thomas,
I believe I already resent it with signed-off-by.
Thanks
Konstantin
-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: Thursday, May 22, 2014 4:33 PM
To: Ananyev, Konstantin
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Use proper mac type for 82576 VF
Hi Konstantin,
2014-05-06 12:28, Konstantin Ananyev:
> e1000_vfadapt type corresponds to 82576 VF devices,
> check e1000_set_mac_type() for more details.
You forgot "Signed-off-by:" line.
Please resend.
--
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] Use proper mac type for 82576 VF
2014-05-22 15:39 ` Ananyev, Konstantin
@ 2014-05-22 15:44 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2014-05-22 15:44 UTC (permalink / raw)
To: Ananyev, Konstantin; +Cc: dev
2014-05-22 15:39, Ananyev, Konstantin:
> Hi Thomas,
> I believe I already resent it with signed-off-by.
Oh yes, you're right.
Sorry for the noise.
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, May 22, 2014 4:33 PM
> To: Ananyev, Konstantin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] Use proper mac type for 82576 VF
>
> Hi Konstantin,
>
> 2014-05-06 12:28, Konstantin Ananyev:
> > e1000_vfadapt type corresponds to 82576 VF devices,
> > check e1000_set_mac_type() for more details.
>
> You forgot "Signed-off-by:" line.
> Please resend.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] Use proper mac type for 82576 VF e1000_vfadapt type corresponds to 82576 VF devices, check e1000_set_mac_type() for more details.
@ 2014-05-06 14:33 Konstantin Ananyev
2014-05-07 13:12 ` Ivan Boule
0 siblings, 1 reply; 5+ messages in thread
From: Konstantin Ananyev @ 2014-05-06 14:33 UTC (permalink / raw)
To: dev, dev
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
lib/librte_pmd_e1000/igb_rxtx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c
index 6b454a5..7fe1780 100644
--- a/lib/librte_pmd_e1000/igb_rxtx.c
+++ b/lib/librte_pmd_e1000/igb_rxtx.c
@@ -2154,7 +2154,7 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev)
rxdctl &= 0xFFF00000;
rxdctl |= (rxq->pthresh & 0x1F);
rxdctl |= ((rxq->hthresh & 0x1F) << 8);
- if (hw->mac.type == e1000_82576) {
+ if (hw->mac.type == e1000_vfadapt) {
/*
* Workaround of 82576 VF Erratum
* force set WTHRESH to 1
--
1.7.7.6
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] Use proper mac type for 82576 VF e1000_vfadapt type corresponds to 82576 VF devices, check e1000_set_mac_type() for more details.
2014-05-06 14:33 [dpdk-dev] [PATCH] Use proper mac type for 82576 VF e1000_vfadapt type corresponds to 82576 VF devices, check e1000_set_mac_type() for more details Konstantin Ananyev
@ 2014-05-07 13:12 ` Ivan Boule
2014-05-27 15:11 ` [dpdk-dev] [PATCH] Use proper mac type for 82576 VF Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Ivan Boule @ 2014-05-07 13:12 UTC (permalink / raw)
To: Konstantin Ananyev; +Cc: dev
On 05/06/2014 04:33 PM, Konstantin Ananyev wrote:
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
> lib/librte_pmd_e1000/igb_rxtx.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c
> index 6b454a5..7fe1780 100644
> --- a/lib/librte_pmd_e1000/igb_rxtx.c
> +++ b/lib/librte_pmd_e1000/igb_rxtx.c
> @@ -2154,7 +2154,7 @@ eth_igbvf_rx_init(struct rte_eth_dev *dev)
> rxdctl &= 0xFFF00000;
> rxdctl |= (rxq->pthresh & 0x1F);
> rxdctl |= ((rxq->hthresh & 0x1F) << 8);
> - if (hw->mac.type == e1000_82576) {
> + if (hw->mac.type == e1000_vfadapt) {
> /*
> * Workaround of 82576 VF Erratum
> * force set WTHRESH to 1
Acked.
Thanks.
--
Ivan Boule
6WIND Development Engineer
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] Use proper mac type for 82576 VF
2014-05-07 13:12 ` Ivan Boule
@ 2014-05-27 15:11 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2014-05-27 15:11 UTC (permalink / raw)
To: Konstantin Ananyev; +Cc: dev
> > e1000_vfadapt type corresponds to 82576 VF devices,
> > check e1000_set_mac_type() for more details.
> >
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
> Acked-by: Ivan Boule <ivan.boule@6wind.com>
Applied for version 1.7.0 with title:
igbvf: fix mac type for 82576
Thanks
--
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-27 15:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-06 11:28 [dpdk-dev] [PATCH] Use proper mac type for 82576 VF Konstantin Ananyev
2014-05-22 15:32 ` Thomas Monjalon
2014-05-22 15:39 ` Ananyev, Konstantin
2014-05-22 15:44 ` Thomas Monjalon
2014-05-06 14:33 [dpdk-dev] [PATCH] Use proper mac type for 82576 VF e1000_vfadapt type corresponds to 82576 VF devices, check e1000_set_mac_type() for more details Konstantin Ananyev
2014-05-07 13:12 ` Ivan Boule
2014-05-27 15:11 ` [dpdk-dev] [PATCH] Use proper mac type for 82576 VF Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).