From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5B00A00C4; Thu, 31 Oct 2019 15:03:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38C281C24F; Thu, 31 Oct 2019 15:03:24 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 6AB9F1C240 for ; Thu, 31 Oct 2019 15:03:23 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 58F396724; Thu, 31 Oct 2019 10:03:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 31 Oct 2019 10:03:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=2idpLjrkLatsYLt41vX8MHanldXva80p0ZPX8hmT5ok=; b=a5uWyKgeH7Xr ppfZ695tXkars1MpU6USpjdqAj+vwWEkLt01xdtUSKCvQNol/+G15TlXDL06V20e u9Y8PiT9BHIWMqIaC+9cmZz1/0m2BNBXBdUeqCTbvTmzf4ndGC/SFA1/qeVji44y /nzEj8IgCjGYN/VPxZWRUTQzq2jkQXA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2idpLjrkLatsYLt41vX8MHanldXva80p0ZPX8hmT5 ok=; b=eUPEW8f2ZV5Tit2ZK7RLl5apfCwkzBNAKjU2K+qDij1Ewa9Tqayc14vL8 6UimC5duYFVqtIGLquD20R5InrmjibTO/m1fHvwGzpp4KiUvSEHctFWHRdpl4F0h nseh2U/09qk843ckrGK9owfEyuvllJjjVN4lL7R+8BuO/vr9YdcY1oslBQdQSyvj 0ily0IHT6RPtVZwN1Kl99Q30q2da1yZqASL/xPEm6A21sM80/dro4t5M2Xuiz3EA gSowLIfPu+3qXDigFWDp5Ucx0fcOcZ9RmHulkXozazFTg3dCLjCOTwDYvGAEYvwc ZcTNrNM93hmCRzQV5iCwRRs73Kf1Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddthedgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EC78B80059; Thu, 31 Oct 2019 10:03:14 -0400 (EDT) From: Thomas Monjalon To: pbhagavatula@marvell.com Cc: dev@dpdk.org, ferruh.yigit@intel.com, arybchenko@solarflare.com, jerinj@marvell.com, Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Nithin Dabilpuram , Kiran Kumar K , Rasesh Mody , Shahed Shaikh , Maciej Czekaj , Yong Wang Date: Thu, 31 Oct 2019 15:03:13 +0100 Message-ID: <3550547.JxZvSsHgut@xps> In-Reply-To: <20191029153722.4547-5-pbhagavatula@marvell.com> References: <20191029050312.2715-1-pbhagavatula@marvell.com> <20191029153722.4547-1-pbhagavatula@marvell.com> <20191029153722.4547-5-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/10/2019 16:37, pbhagavatula@marvell.com: > From: Pavan Nikhilesh > > Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash > delivery. > > Signed-off-by: Pavan Nikhilesh > Reviewed-by: Andrew Rybchenko > Reviewed-by: Hemant Agrawal > Acked-by: Jerin Jacob > Acked-by: Ajit Khaparde > --- > + if (!(dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_RSS_HASH)) > + dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH; Excuse me, I miss why you need a check before setting the bit.