From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 567DFA04A3; Tue, 16 Jun 2020 10:22:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 309441B94F; Tue, 16 Jun 2020 10:22:40 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 6B3F9199BC for ; Tue, 16 Jun 2020 10:22:38 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id E4D8C5801EB; Tue, 16 Jun 2020 04:22:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 16 Jun 2020 04:22:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= mKZ4+N0XBjy8Lo8LPRuEGX9lU3i5LZPyM353Ow78xY8=; b=AF1xjQY+HgcGgqT9 go7tOWiLBFo7iZvGjqIexkKfVYBIjMPf9H4YtfRa5CNZC5dgS7Fo0texHgiQu+XN ig77oCLuqPdBNvT79bowIomiQbF0Y2Ae+baF03NW/JdWI3tHwh2wVncj4ogtStB5 lpFFY4LvrBMmMNuK4QM/qoHwPxeSjFEKubEP8VD/HX23LJkJsuaYk+w3D0LJm/WM zzo/i3tXsriVy1Ds7R6gMrDPN5EvwnUUR2V1bMwXbgd7nPA15WAq6XMxCZcKCEFj u40DQAtozLELR03LX2yRrNFy/EmQDzPgt8lhQgU0HgQbnMnZfE+FdHMQfwcmGGh8 cE3VRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=mKZ4+N0XBjy8Lo8LPRuEGX9lU3i5LZPyM353Ow78x Y8=; b=aFPUIMeqBzVMlk2f/NaMghKDXx2q9HhP/sT3khBZDQmUbv/yI7YPkv2T6 /XvRdURry2iLJsdib3ZpDsZIqGHfVl6lQWOqte9AuM6RxN7M8rJqQQHitOL15A9v 92pvEn3JAilQjfZKFsurYFW9gzsLYgA9UN91JlT81XechNpNUGNX/tVaYQyvHRsI KzjTTGd/alggEAGLVA3PL9t0igFOcQQcDoWiwUn1Fn9WFRC50NpuBRix+NT+MmpC WXUpt+9gKHNv/r5QCORKMQU2Sn+IPft6llmnWC0kRxgNs4BgC6qP3D0dmM2UN94C 231Z/ODjRhO7XpseClse4on37vUcA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejtddgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 01A8E3280068; Tue, 16 Jun 2020 04:22:35 -0400 (EDT) From: Thomas Monjalon To: Tal Shnaiderman Cc: dev@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com Date: Tue, 16 Jun 2020 10:22:34 +0200 Message-ID: <3555432.PB3PNQyGtD@thomas> In-Reply-To: <20200609103139.22168-4-talshn@mellanox.com> References: <20200609103139.22168-1-talshn@mellanox.com> <20200609103139.22168-4-talshn@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 3/8] pci: build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/06/2020 12:31, talshn@mellanox.com: > From: Tal Shnaiderman > > Added in Windows header file includes > to include off_t type since it is needed by PCI. Why is it added in rte_os.h and not in the file using off_t? > export per_lcore__rte_errno from eal since it is needed by PCI. [...] > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -386,6 +386,9 @@ EXPERIMENTAL { > + # added in 20.08 > + __emutls_v.per_lcore__rte_errno; I think it is not needed.