From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CB7843B39; Sun, 18 Feb 2024 13:24:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6E8E4028A; Sun, 18 Feb 2024 13:24:13 +0100 (CET) Received: from wfout2-smtp.messagingengine.com (wfout2-smtp.messagingengine.com [64.147.123.145]) by mails.dpdk.org (Postfix) with ESMTP id 7B71840262 for ; Sun, 18 Feb 2024 13:24:12 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.west.internal (Postfix) with ESMTP id EEABB1C0009D; Sun, 18 Feb 2024 07:24:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 18 Feb 2024 07:24:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1708259050; x=1708345450; bh=k0Qfo7fJHYzSpP6T6pSokmglRd63+FhqSSflosiPenk=; b= GhNfduiodgVytdDRBslx8YWdnomfGhZFI0vv9iZqbWL8PiJN4MEdgUeOlbaOOdOX YWx6zhOniel7u+MAzEXSZV7pLFxB6pHJKYiE8svhWwUc1XDRnXAG9p075RxIzesd /k32kd0cm128Z8/jU0U+g+BnlmzcSn8QQC7BIkzgRAPvHe8ln9lNKgcb1v1RhJyE 2yu400EF4M79PMsIXS0IYjt0eTQtGtqL9gAOCri8VFXi1psopSYdSXwbB81n/nDm V+8ZJdstE5nxp5DDF+OJIp308yKD+WS4GTTbkpWATPpFxQuDkrSG1BOeQFJ2HHEf LZLqrq9RjlWUL5+FEjkl8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708259050; x= 1708345450; bh=k0Qfo7fJHYzSpP6T6pSokmglRd63+FhqSSflosiPenk=; b=j f3JR9NzKvCb/ZnAK0qG9HbJJDtmVGc40GiKAo849umLk08LLKEjdH+Rc3obW3f6Y 48Ofn43BuqKLyvWnttlHHVK9SPsqjbHCDEkRjH8uOcyjWdLjw0p/ebRvpHY27Am7 crPoBLQ31AEjlEJzGO8BDYgWrDQNo5qA+AeNFrEhvsn/k9XDyFozktKAT1ML0J9D BCdGnQMVGKDXJzZAhHp8M/Zo0O4SCFt0C6AwNsmz3Nq2z6Sl1NaCUkEMZ1uCYZuO g/xM+DNVYLqJJDjTqfl02QqBL4RtNpbU/KkS86+ROVNgIydB4bZq1kfXImL2i/px mW0MY1kgZ1X4OVGNwzr4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeigdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvd elteeufeefheeujefgueetfedttdeikefgkeduhedtgfenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Feb 2024 07:24:09 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org Subject: Re: [PATCH] eal: provide rte attribute macro for GCC attribute Date: Sun, 18 Feb 2024 13:24:08 +0100 Message-ID: <3556729.8hb0ThOEGa@thomas> In-Reply-To: <1708035618-14090-2-git-send-email-roretzla@linux.microsoft.com> References: <1708035618-14090-1-git-send-email-roretzla@linux.microsoft.com> <1708035618-14090-2-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/02/2024 23:20, Tyler Retzlaff: > Provide a new macro __rte_attribute(a) that when directly used > compiles to empty for MSVC and to __attribute__(a) when using GCC/LLVM. > > Replace direct use of __attribute__ in __rte_xxx macros where there is > existing empty expansion of the macro for MSVC allowing removal of > repeated #ifdef RTE_TOOLCHAIN_MSVC per macro to expand empty. I'm not sure it makes sense. I prefer seeing clearly what is empty with MSVC.